From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Kees Cook <keescook@chromium.org>
Cc: Jason Gunthorpe <jgg@ziepe.ca>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>,
Alexander Potapenko <glider@google.com>,
Joe Perches <joe@perches.com>,
Andy Whitcroft <apw@canonical.com>,
"the arch/x86 maintainers" <x86@kernel.org>,
Lars Ellenberg <drbd-dev@lists.linbit.com>,
linux-block@vger.kernel.org, b43-dev@lists.infradead.org,
netdev <netdev@vger.kernel.org>,
linux-wireless <linux-wireless@vger.kernel.org>,
linux-ide@vger.kernel.org, linux-clk <linux-clk@vger.kernel.org>,
linux-spi <linux-spi@vger.kernel.org>,
Linux MM <linux-mm@kvack.org>,
clang-built-linux <clang-built-linux@googlegroups.com>
Subject: Re: [PATCH 09/10] treewide: Remove uninitialized_var() usage
Date: Thu, 4 Jun 2020 21:09:32 +0200 [thread overview]
Message-ID: <CAMuHMdVuzvvHt3j+L+_BSPFs5RgaP3rkknEUmRvTAs5nZ9SGPA@mail.gmail.com> (raw)
In-Reply-To: <202006040757.0DFC3F28E@keescook>
Hi Kees,
On Thu, Jun 4, 2020 at 5:01 PM Kees Cook <keescook@chromium.org> wrote:
> On Thu, Jun 04, 2020 at 10:23:06AM -0300, Jason Gunthorpe wrote:
> > On Wed, Jun 03, 2020 at 04:32:02PM -0700, Kees Cook wrote:
> > > Using uninitialized_var() is dangerous as it papers over real bugs[1]
> > > (or can in the future), and suppresses unrelated compiler warnings
> > > (e.g. "unused variable"). If the compiler thinks it is uninitialized,
> > > either simply initialize the variable or make compiler changes.
> > >
> > > I preparation for removing[2] the[3] macro[4], remove all remaining
> > > needless uses with the following script:
> > >
> > > git grep '\buninitialized_var\b' | cut -d: -f1 | sort -u | \
> > > xargs perl -pi -e \
> > > 's/\buninitialized_var\(([^\)]+)\)/\1/g;
> > > s:\s*/\* (GCC be quiet|to make compiler happy) \*/$::g;'
> > >
> > > drivers/video/fbdev/riva/riva_hw.c was manually tweaked to avoid
> > > pathological white-space.
> > >
> > > No outstanding warnings were found building allmodconfig with GCC 9.3.0
> > > for x86_64, i386, arm64, arm, powerpc, powerpc64le, s390x, mips, sparc64,
> > > alpha, and m68k.
> >
> > At least in the infiniband part I'm confident that old gcc versions
> > will print warnings after this patch.
> >
> > As the warnings are wrong, do we care? Should old gcc maybe just -Wno-
> > the warning?
>
> I *think* a lot of those are from -Wmaybe-uninitialized, but Linus just
> turned that off unconditionally in v5.7:
> 78a5255ffb6a ("Stop the ad-hoc games with -Wno-maybe-initialized")
>
> I'll try to double-check with some older gcc versions. My compiler
> collection is mostly single-axis: lots of arches, not lots of versions. ;)
Nope, support for the good old gcc 4.1 was removed a while ago.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2020-06-04 19:09 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-03 23:31 [PATCH 00/10] Remove uninitialized_var() macro Kees Cook
2020-06-03 23:31 ` [PATCH 01/10] x86/mm/numa: Remove uninitialized_var() usage Kees Cook
2020-06-04 7:58 ` Thomas Gleixner
2020-06-04 11:41 ` Miguel Ojeda
2020-06-04 14:56 ` Kees Cook
2020-06-04 15:22 ` Miguel Ojeda
2020-06-04 14:34 ` Kees Cook
2020-06-04 21:39 ` Thomas Gleixner
2020-06-04 22:39 ` Kees Cook
2020-06-03 23:31 ` [PATCH 02/10] drbd: " Kees Cook
2020-06-04 19:56 ` Nick Desaulniers
2020-06-03 23:31 ` [PATCH 03/10] b43: " Kees Cook
2020-06-04 20:08 ` Nick Desaulniers
2020-06-04 20:18 ` Kees Cook
2020-06-04 20:25 ` Nick Desaulniers
2020-06-05 9:20 ` Kalle Valo
2020-06-03 23:31 ` [PATCH 04/10] rtlwifi: rtl8192cu: " Kees Cook
2020-06-04 20:16 ` Nick Desaulniers
2020-06-05 9:18 ` Kalle Valo
2020-06-03 23:31 ` [PATCH 05/10] ide: " Kees Cook
2020-06-04 19:29 ` Nick Desaulniers
2020-06-04 20:20 ` Kees Cook
2020-06-04 20:29 ` Nick Desaulniers
2020-06-15 19:32 ` Kees Cook
2020-06-04 20:58 ` Sedat Dilek
2020-06-03 23:31 ` [PATCH 06/10] clk: st: " Kees Cook
2020-06-04 4:38 ` Stephen Boyd
2020-06-03 23:32 ` [PATCH 07/10] spi: davinci: " Kees Cook
2020-06-04 19:40 ` Nick Desaulniers
2020-06-03 23:32 ` [PATCH 08/10] checkpatch: Remove awareness of uninitialized_var() macro Kees Cook
2020-06-04 0:02 ` Joe Perches
2020-06-04 1:40 ` Kees Cook
2020-06-04 1:47 ` Joe Perches
2020-06-04 2:44 ` Kees Cook
2020-06-04 2:53 ` Sedat Dilek
2020-06-04 3:46 ` Kees Cook
2020-06-03 23:32 ` [PATCH 09/10] treewide: Remove uninitialized_var() usage Kees Cook
2020-06-04 3:33 ` Nathan Chancellor
2020-06-04 4:02 ` Kees Cook
2020-06-04 10:45 ` Leon Romanovsky
2020-06-04 13:23 ` Jason Gunthorpe
2020-06-04 14:59 ` Kees Cook
2020-06-04 17:57 ` Jason Gunthorpe
2020-06-04 19:09 ` Geert Uytterhoeven [this message]
2020-06-05 9:25 ` Kalle Valo
2020-06-03 23:32 ` [PATCH 10/10] compiler: Remove uninitialized_var() macro Kees Cook
2020-06-04 0:00 ` Bart Van Assche
2020-06-04 0:50 ` Miguel Ojeda
2020-06-04 1:23 ` [PATCH 00/10] " Sedat Dilek
2020-06-04 1:44 ` Kees Cook
2020-06-04 1:46 ` Sedat Dilek
2020-06-04 3:33 ` Nathan Chancellor
2020-06-04 7:26 ` Sedat Dilek
2020-06-04 14:27 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdVuzvvHt3j+L+_BSPFs5RgaP3rkknEUmRvTAs5nZ9SGPA@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=apw@canonical.com \
--cc=b43-dev@lists.infradead.org \
--cc=clang-built-linux@googlegroups.com \
--cc=drbd-dev@lists.linbit.com \
--cc=glider@google.com \
--cc=jgg@ziepe.ca \
--cc=joe@perches.com \
--cc=keescook@chromium.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).