From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4B28C433FE for ; Tue, 11 Oct 2022 12:59:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6C33D6B0072; Tue, 11 Oct 2022 08:59:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 64B216B0073; Tue, 11 Oct 2022 08:59:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4C53F6B0074; Tue, 11 Oct 2022 08:59:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 372B06B0072 for ; Tue, 11 Oct 2022 08:59:42 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id BAEB51A0CBA for ; Tue, 11 Oct 2022 12:59:40 +0000 (UTC) X-FDA: 80008675320.28.2DFCEEF Received: from mail-qv1-f52.google.com (mail-qv1-f52.google.com [209.85.219.52]) by imf09.hostedemail.com (Postfix) with ESMTP id 685DE140029 for ; Tue, 11 Oct 2022 12:59:39 +0000 (UTC) Received: by mail-qv1-f52.google.com with SMTP id i9so8892549qvo.0 for ; Tue, 11 Oct 2022 05:59:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=KCdjWL21q88tuN2VrHSfcRWb8jbhJ1H4I8ctsaB17uI=; b=xQ3Uk8Y99siFO0XrXHOU4NYZ1x/VQoZ4OYBQop2113cY4PPzvuHPMjJUQTYYD0CNSl vZuc8euu68abnLWcJ0tMqVgIfbaIpic4wkFXUxLPXvdjO/cEnDOkyQLPk5PL70F6srha rsXeJixaQLoEW/qD8YybkqgkRkd/rEmnqV1LMQI/PDILrlSYDDR4Z9p5OP1Vr6eGM6qe CMXRMkCIiIZWWnjUK7uTcR6IZaFnh+bA/gTWJ5k+DDvvGkVvye541WXK9QMz/KVM4/kC rhhM1VeYYDh6vKhqMyQyKHCt+7CIEBHAG5haEOGU0OP/hjhJhZfXUigzjSFEOy458XL2 PU8Q== X-Gm-Message-State: ACrzQf1sM52Zvf0liEBjVolz09chDZxHo7H76NikAOssNiNqm7wdyDgm 7sv/wihDLSj5PaSkJZevbh/y1u6A2CwXEA== X-Google-Smtp-Source: AMsMyM7PZ7RVSAfGWFxDD194vUzMzSGaReVEEt5NeodOq7wO8Xa44PG4OxXeFRQQkL5vi0gtBn4UDg== X-Received: by 2002:a0c:e186:0:b0:4b1:b52e:effa with SMTP id p6-20020a0ce186000000b004b1b52eeffamr18005774qvl.118.1665493178456; Tue, 11 Oct 2022 05:59:38 -0700 (PDT) Received: from mail-yb1-f171.google.com (mail-yb1-f171.google.com. [209.85.219.171]) by smtp.gmail.com with ESMTPSA id f14-20020a05620a280e00b006be8713f742sm12860223qkp.38.2022.10.11.05.59.37 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 Oct 2022 05:59:38 -0700 (PDT) Received: by mail-yb1-f171.google.com with SMTP id e62so16346225yba.6 for ; Tue, 11 Oct 2022 05:59:37 -0700 (PDT) X-Received: by 2002:a25:4fc2:0:b0:6be:afb4:d392 with SMTP id d185-20020a254fc2000000b006beafb4d392mr21411387ybb.604.1665493177654; Tue, 11 Oct 2022 05:59:37 -0700 (PDT) MIME-Version: 1.0 References: <20220906194824.2110408-1-Liam.Howlett@oracle.com> <20220906194824.2110408-8-Liam.Howlett@oracle.com> In-Reply-To: From: Geert Uytterhoeven Date: Tue, 11 Oct 2022 14:59:26 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v14 07/70] lib/test_maple_tree: add testing for maple tree To: Matthew Wilcox Cc: Liam Howlett , "maple-tree@lists.infradead.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Andrew Morton Content-Type: text/plain; charset="UTF-8" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1665493179; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KCdjWL21q88tuN2VrHSfcRWb8jbhJ1H4I8ctsaB17uI=; b=i39k29Jton0vJGFODFZbIGKpEK/Of0aAp0lE3Y4DtvT/Cnp9Z4sbG0ax7jBoG5snWH70TF E81C04KO/i9Id3gbK6que+WC8nXcO1EeLBH03mQ6p4JFdXYQ+9Czz6ZY2oSoUGTwMp38OA OwX5fq8+8fHGUQZe4x2IBmD/Nn2q1aQ= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf09.hostedemail.com: domain of geert.uytterhoeven@gmail.com designates 209.85.219.52 as permitted sender) smtp.mailfrom=geert.uytterhoeven@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1665493179; a=rsa-sha256; cv=none; b=zl8M3zPqYSNskzNnDbTyQfNb1iN5uCNnqA9HXxiuq60SDV0mQ3YPEV5KghlQAXZA1OifCH ajP9bEKqKrj1ViBBR5BxdG+RGnW+X46iCpJ+8pw+6TgqpL9F4jErwjknKHnx9jL8QkUuOG pa5Pi0lLOUdGYOco52vMaDy4qTPrWE0= X-Stat-Signature: ufnspdd7ctetha6ozmxf3gmif6nxggex X-Rspamd-Server: rspam09 X-Rspam-User: Authentication-Results: imf09.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf09.hostedemail.com: domain of geert.uytterhoeven@gmail.com designates 209.85.219.52 as permitted sender) smtp.mailfrom=geert.uytterhoeven@gmail.com X-Rspamd-Queue-Id: 685DE140029 X-HE-Tag: 1665493179-752237 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Matthew, On Tue, Oct 11, 2022 at 2:56 PM Matthew Wilcox wrote: > On Tue, Oct 11, 2022 at 02:16:02PM +0200, Geert Uytterhoeven wrote: > > > lib/test_maple_tree.c | 38307 ++++++++++++++++++++++++++++ > > > > Does this test really belong under lib/? > > All other test modules there can be compiled and run as part of the > > kernel itself. > > So can this. It's just like test_ida and test_xarray; it can be > built as a module, or it can be extracted into userspace and run there. How so? I can't seem to find the glue to do so, or the Kconfig symbol to enable the test module. It's different for test_ida and test_xarray: lib/Makefile:obj-$(CONFIG_TEST_IDA) += test_ida.o lib/Makefile:obj-$(CONFIG_TEST_XARRAY) += test_xarray.o What am I missing? Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds