From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3258CC432C0 for ; Tue, 26 Nov 2019 08:50:28 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E7D96206BF for ; Tue, 26 Nov 2019 08:50:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E7D96206BF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9387F6B02C3; Tue, 26 Nov 2019 03:50:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8E9976B02C4; Tue, 26 Nov 2019 03:50:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7FE846B02C5; Tue, 26 Nov 2019 03:50:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0209.hostedemail.com [216.40.44.209]) by kanga.kvack.org (Postfix) with ESMTP id 684646B02C3 for ; Tue, 26 Nov 2019 03:50:27 -0500 (EST) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with SMTP id 051C6181AEF2A for ; Tue, 26 Nov 2019 08:50:27 +0000 (UTC) X-FDA: 76197807294.13.hall85_20f9b2f420649 X-HE-Tag: hall85_20f9b2f420649 X-Filterd-Recvd-Size: 5375 Received: from mail-ot1-f67.google.com (mail-ot1-f67.google.com [209.85.210.67]) by imf39.hostedemail.com (Postfix) with ESMTP for ; Tue, 26 Nov 2019 08:50:26 +0000 (UTC) Received: by mail-ot1-f67.google.com with SMTP id m15so15219868otq.7 for ; Tue, 26 Nov 2019 00:50:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=n4Yshke3egGMmapF2Z1tVAHKlspphDAhMhmDxgPbzag=; b=biEySYR4k91HXAmXKVZH5wQWkmAuCVv+cBOkzJS6PSZQZO+TCAjAozejJWrCnP/0kz GnyYtrlW+zOewkXsSrANN2gBAcV5yonieGJ7nM4KP+FM79cz5GeppKqKsaFRoZqc39UZ G1KUACUPZhevNbL8SORzjjVmPMixQ8SeDt1HFEnVWc3W48b2T8Ui/TJW4qDz1bEDsEdC G4VAkVMMDZOtf0QV1g7aFg57jHENvVkyULJ9rUt5iIlANMzNe1fh9s5UZEHawR+bEdkc QM3VO1S757T/cQc9MBb0RQ6HuZLWmMYW5+Sf754JHSzSe9ljymNTbcwVRT9g0lacx45y uHXg== X-Gm-Message-State: APjAAAWZRmAT9h/5PT0MaQxL+wE1i1NcRXfSxL3R76Qg+LXqw/M0s/0e j1n5VM9wKju1towOSf47GSC+GSiv+uSDngva9c0= X-Google-Smtp-Source: APXvYqyJEnuIEUvE5X1072xq7e/bD6GMoQThojPDcjQlvxdPvn7yVUe3/KjpQmQAKX1yDlZzb7RhhAsdBgm2A6aeCBE= X-Received: by 2002:a9d:19ed:: with SMTP id k100mr808887otk.297.1574758225753; Tue, 26 Nov 2019 00:50:25 -0800 (PST) MIME-Version: 1.0 References: <5ddb5317.or/pMNqm/YAp0XTV%lkp@intel.com> <20191125203342.a564d592deb6b140d3cab667@linux-foundation.org> <20191126084724.GB24228@linux.ibm.com> In-Reply-To: <20191126084724.GB24228@linux.ibm.com> From: Geert Uytterhoeven Date: Tue, 26 Nov 2019 09:50:14 +0100 Message-ID: Subject: Re: [linux-next:master] BUILD REGRESSION b9d3d01405061bb42358fe53f824e894a1922ced To: Mike Rapoport Cc: Andrew Morton , kbuild test robot , Linux Memory Management List , Mike Rapoport Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Mike, On Tue, Nov 26, 2019 at 9:47 AM Mike Rapoport wrote: > On Tue, Nov 26, 2019 at 09:10:22AM +0100, Geert Uytterhoeven wrote: > > On Tue, Nov 26, 2019 at 5:33 AM Andrew Morton wrote: > > > On Mon, 25 Nov 2019 12:05:43 +0800 kbuild test robot wrote: > > > > tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > > > > branch HEAD: b9d3d01405061bb42358fe53f824e894a1922ced Add linux-next specific files for 20191122 > > > > > > > > Regressions in current branch: > > > > > > > > arch/m68k/mm/kmap.c:348:2: error: #endif without #if > > > > That one is fixed by your > > m68k-mm-use-pgtable-nopxd-instead-of-4level-fixup-fix.patch. > > > > > > arch/m68k/mm/kmap.c:352:3: error: 'p4d_dir' undeclared (first use in this function); did you mean 'pmd_dir'? > > > > arch/m68k/mm/kmap.c:353:3: error: 'pud_dir' undeclared (first use in this function); did you mean 'p4d_dir'? > > > > You lost the addition of > > > > + p4d_t *p4d_dir; > > + pud_t *pud_dir; > > > > to kernel_set_cachemode(). > > > > > > arch/m68k/mm/kmap.c:76:24: error: passing argument 1 of 'pmd_offset' from incompatible pointer type [-Werror=incompatible-pointer-types] > > > > arch/m68k/mm/kmap.c:80:28: error: 'pmd_t {aka struct }' has no member named 'pmd'; did you mean 'pud'? > > > > Mike's changes to __iounmap() should be applied to __free_io_area() now, > > due to hch's move/rename of the function. > > > > > Thanks - a messed up merge fix, I guess. Mike, can you please check? > > > > I've attached an incremental fix, compile-tested only. > > I was just about to send the same fix :) > It boots on aranym. Thanks for checking! > > --- a/arch/m68k/mm/kmap.c > > +++ b/arch/m68k/mm/kmap.c > > @@ -63,18 +63,23 @@ static void __free_io_area(void *addr, unsigned long size) > > { > > unsigned long virtaddr = (unsigned long)addr; > > pgd_t *pgd_dir; > > + p4d_t *p4d_dir; > > + pud_t *pud_dir; > > pmd_t *pmd_dir; > > pte_t *pte_dir; > > > > while ((long)size > 0) { > > pgd_dir = pgd_offset_k(virtaddr); > > - if (pgd_bad(*pgd_dir)) { > > - printk("iounmap: bad pgd(%08lx)\n", pgd_val(*pgd_dir)); > > - pgd_clear(pgd_dir); > > + p4d_dir = p4d_offset(pgd_dir, virtaddr); > > + pud_dir = pud_offset(p4d_dir, virtaddr); > > + if (pud_bad(*pud_dir)) { > > + printk("iounmap: bad pgd(%08lx)\n", pud_val(*pud_dir)); > > ^ bad pud ;-) Bummer... I even pointed out that typo during the review of your v4 ;-( Andrew: can you please fix that up? Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds