From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0BD3C3A5A0 for ; Mon, 20 Apr 2020 09:26:32 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 700C22145D for ; Mon, 20 Apr 2020 09:26:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 700C22145D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 09ECD8E0005; Mon, 20 Apr 2020 05:26:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 04F718E0003; Mon, 20 Apr 2020 05:26:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EA6AF8E0005; Mon, 20 Apr 2020 05:26:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0026.hostedemail.com [216.40.44.26]) by kanga.kvack.org (Postfix) with ESMTP id D19318E0003 for ; Mon, 20 Apr 2020 05:26:31 -0400 (EDT) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 8CCBAC5CD for ; Mon, 20 Apr 2020 09:26:31 +0000 (UTC) X-FDA: 76727702982.20.sofa29_7323b13226816 X-HE-Tag: sofa29_7323b13226816 X-Filterd-Recvd-Size: 4786 Received: from mail-ot1-f67.google.com (mail-ot1-f67.google.com [209.85.210.67]) by imf46.hostedemail.com (Postfix) with ESMTP for ; Mon, 20 Apr 2020 09:26:31 +0000 (UTC) Received: by mail-ot1-f67.google.com with SMTP id q9so844595otf.5 for ; Mon, 20 Apr 2020 02:26:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vNmHcf3myzOB2u9F8M3SMwCNsUNlPCLfd3zAQRCW16Q=; b=rU4QWtBeTFrBVR824DxpR3q49jUECrNc9stOHA/0cTFTwmSPCbzv3oDR4mzllH+75V JfFyV0N3fSwdFSV4MYWxBS63tZvAUZkLz77iKSEt5LOrdkVxDdstRQFeGGedrbtU5XQq zlLZGDXCMXC3eR9tqukP5RffZTpLuQf9fFCBVE/H/gS1ZsXWSQPzeurPUOCRlT1LQJLp lKm28FpudRWybIVnnxVMcqTfNhSDM2w77GT7BfcgsbKg/nriPgly3huwtFDL1ZjwLPTr 1phRK/AiAYEkciIGMtSjVzelavHqGTjAFbMTSjfnTVBdqkiHf1WmQ6C43B9doyzVvkTW 1IXg== X-Gm-Message-State: AGi0Pubz+BiCiFK3+8zkw3WFWbsTDCJ7bogcLjh/uUpBcEEiBIuHrE6S UFykP3Ym7lHI0iCxCKRvtmRDFv2rqkYXSzfxJqc= X-Google-Smtp-Source: APiQypLK0nAWizIJ4tO6vPe5OvpMxqQr4fd7LV61E3+C9yzFgEDzCpkHgr7Sqg0Lx1T9RyK7Z05pBaDYg8OyPFQJ0Pw= X-Received: by 2002:a05:6830:3104:: with SMTP id b4mr5221130ots.250.1587374790460; Mon, 20 Apr 2020 02:26:30 -0700 (PDT) MIME-Version: 1.0 References: <20200414131348.444715-1-hch@lst.de> <20200414131348.444715-27-hch@lst.de> In-Reply-To: <20200414131348.444715-27-hch@lst.de> From: Geert Uytterhoeven Date: Mon, 20 Apr 2020 11:26:19 +0200 Message-ID: Subject: Re: [PATCH 26/29] mm: remove vmalloc_user_node_flags To: Christoph Hellwig Cc: Andrew Morton , "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Wei Liu , "the arch/x86 maintainers" , David Airlie , Daniel Vetter , Laura Abbott , Sumit Semwal , Sakari Ailus , Minchan Kim , Nitin Gupta , Christophe Leroy , Linux-Arch , linux-hyperv@vger.kernel.org, linux-s390 , Peter Zijlstra , linuxppc-dev , Linux Kernel Mailing List , DRI Development , linaro-mm-sig@lists.linaro.org, Linux MM , Linux IOMMU , Johannes Weiner , bpf , Robin Murphy , Linux ARM Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Christoph, On Tue, Apr 14, 2020 at 3:22 PM Christoph Hellwig wrote: > Open code it in __bpf_map_area_alloc, which is the only caller. Also > clean up __bpf_map_area_alloc to have a single vmalloc call with > slightly different flags instead of the current two different calls. > > For this to compile for the nommu case add a __vmalloc_node_range stub > to nommu.c. Apparently your nommu-cross-compilers are in quarantaine? ;-) > Signed-off-by: Christoph Hellwig > Acked-by: Peter Zijlstra (Intel) > Acked-by: Johannes Weiner > --- a/mm/nommu.c > +++ b/mm/nommu.c > @@ -150,6 +150,14 @@ void *__vmalloc(unsigned long size, gfp_t gfp_mask) > } > EXPORT_SYMBOL(__vmalloc); > > +void *__vmalloc_node_range(unsigned long size, unsigned long align, > + unsigned long start, unsigned long end, gfp_t gfp_mask, > + pgprot_t prot, unsigned long vm_flags, int node, > + const void *caller) > +{ > + return __vmalloc(size, flags); On Mon, Apr 20, 2020 at 10:39 AM wrote: > FAILED linux-next/m5272c3_defconfig/m68k-gcc8 Mon Apr 20, 18:38 > > http://kisskb.ellerman.id.au/kisskb/buildresult/14213623/ > > mm/nommu.c:158:25: error: 'flags' undeclared (first use in this function); did you mean 'class'? "return __vmalloc(size, gfp_mask);", I assume? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds