From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 793F5C3F2D1 for ; Mon, 2 Mar 2020 08:19:14 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4106B246B9 for ; Mon, 2 Mar 2020 08:19:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4106B246B9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id BEC0E6B0005; Mon, 2 Mar 2020 03:19:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B749A6B0006; Mon, 2 Mar 2020 03:19:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A14CB6B0007; Mon, 2 Mar 2020 03:19:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0045.hostedemail.com [216.40.44.45]) by kanga.kvack.org (Postfix) with ESMTP id 856446B0005 for ; Mon, 2 Mar 2020 03:19:13 -0500 (EST) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 5625D180AD804 for ; Mon, 2 Mar 2020 08:19:13 +0000 (UTC) X-FDA: 76549722186.04.girl56_16445c009fb28 X-HE-Tag: girl56_16445c009fb28 X-Filterd-Recvd-Size: 5416 Received: from mail-ot1-f65.google.com (mail-ot1-f65.google.com [209.85.210.65]) by imf11.hostedemail.com (Postfix) with ESMTP for ; Mon, 2 Mar 2020 08:19:12 +0000 (UTC) Received: by mail-ot1-f65.google.com with SMTP id v10so1569659otp.2 for ; Mon, 02 Mar 2020 00:19:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yqmS1X8qI6/s8cwCJEzUrnvDV3NhuggUO9eO0r27sb0=; b=LLEtbEawDZQ5vrmjv3oqwZYLfdobWtXW9ZVYrHTJog7fY7YH0u/oeN6x85YddQcBb6 zmfnDgZcNRM6NAZ+5E8NX1Ptjq3zmbtxSH7YELL9JzO8ZXBaS7TTyi+/siLEAkxH1y19 mL4fpL+pOHLKz17oQEpfeF2+RD/ncwww3NqzuAglmcyFQePkRhZFJHwsEl38dVibTL7Y IYnxzBANS1zxmeGypBiNDOrbTCYntnQjsxZfp2z6XKt5GcPyyylRMsOIBzv6Fm6debyV Bjv5D65/F48QNfgkulXohhaCEYzn5qTFPb9h1YaqXb1Dms7Qde28GRhBzKky8WawS+g4 FrTA== X-Gm-Message-State: APjAAAUFGhiTzYsS73IR0mzaTKQB0eGH5OXeNKJzFaNuF9piQdtUam1u c+QIZ5ToTGjL7m3BUMoz8x3UXxAfg5LsSosO8vs= X-Google-Smtp-Source: APXvYqxJAsXBEb0up6C6U45pxshI9Ikohe/0ASpQmGQUY7aNow99BqVlQd7sShJKbvufJm9F2NTGKOK92pziLY2199g= X-Received: by 2002:a9d:5c0c:: with SMTP id o12mr12398547otk.145.1583137152054; Mon, 02 Mar 2020 00:19:12 -0800 (PST) MIME-Version: 1.0 References: <1583114190-7678-1-git-send-email-anshuman.khandual@arm.com> In-Reply-To: <1583114190-7678-1-git-send-email-anshuman.khandual@arm.com> From: Geert Uytterhoeven Date: Mon, 2 Mar 2020 09:19:00 +0100 Message-ID: Subject: Re: [PATCH] mm/special: Create generic fallbacks for pte_special() and pte_mkspecial() To: Anshuman Khandual Cc: Linux MM , Richard Henderson , Ivan Kokshaysky , Matt Turner , Russell King , Guo Ren , Brian Cain , Tony Luck , Fenghua Yu , Sam Creasey , Michal Simek , Ralf Baechle , Paul Burton , Nick Hu , Greentime Hu , Vincent Chen , Ley Foon Tan , Jonas Bonn , Stefan Kristiansson , Stafford Horne , "James E.J. Bottomley" , Helge Deller , "David S. Miller" , Jeff Dike , Richard Weinberger , Anton Ivanov , Guan Xuetao , Chris Zankel , Max Filippov , Andrew Morton , alpha , Linux ARM , linux-csky@vger.kernel.org, "open list:QUALCOMM HEXAGON..." , "linux-ia64@vger.kernel.org" , linux-m68k , linux-mips@vger.kernel.org, nios2-dev@lists.rocketboards.org, Openrisc , Parisc List , sparclinux , linux-um , "open list:TENSILICA XTENSA PORT (xtensa)" , Linux-Arch , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Anshuman, Thanks for your patch! On Mon, Mar 2, 2020 at 2:56 AM Anshuman Khandual wrote: > Currently there are many platforms that dont enable HAVE_ARCH_PTE_SPECIAL ARCH_HAS_PTE_SPECIAL > but required to define quite similar fallback stubs for special page table > entry helpers such as pte_special() and pte_mkspecial(), as they get build > in generic MM without a config check. This creates two generic fallback > stub definitions for these helpers, eliminating much code duplication. > > mips platform has a special case where pte_special() and pte_mkspecial() > visibility is wider than what HAVE_ARCH_PTE_SPECIAL enablement requires. ARCH_HAS_PTE_SPECIAL > This restricts those symbol visibility in order to avoid redefinitions > which is now exposed through this new generic stubs and subsequent build > failure. arm platform set_pte_at() definition needs to be moved into a C > file just to prevent a build failure. > Signed-off-by: Anshuman Khandual > arch/m68k/include/asm/mcf_pgtable.h | 10 ------ > arch/m68k/include/asm/motorola_pgtable.h | 2 -- > arch/m68k/include/asm/sun3_pgtable.h | 2 -- For m68k: Acked-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds