From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7AD41C43603 for ; Wed, 4 Dec 2019 12:33:22 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4729C20833 for ; Wed, 4 Dec 2019 12:33:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4729C20833 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E06E66B0A8B; Wed, 4 Dec 2019 07:33:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DB7236B0A8D; Wed, 4 Dec 2019 07:33:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CA5B16B0A8E; Wed, 4 Dec 2019 07:33:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0083.hostedemail.com [216.40.44.83]) by kanga.kvack.org (Postfix) with ESMTP id B05CA6B0A8B for ; Wed, 4 Dec 2019 07:33:21 -0500 (EST) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with SMTP id 679FF246E for ; Wed, 4 Dec 2019 12:33:21 +0000 (UTC) X-FDA: 76227399402.23.music32_748e8d7b1d00a X-HE-Tag: music32_748e8d7b1d00a X-Filterd-Recvd-Size: 5229 Received: from mail-oi1-f194.google.com (mail-oi1-f194.google.com [209.85.167.194]) by imf01.hostedemail.com (Postfix) with ESMTP for ; Wed, 4 Dec 2019 12:33:20 +0000 (UTC) Received: by mail-oi1-f194.google.com with SMTP id a67so6673250oib.6 for ; Wed, 04 Dec 2019 04:33:20 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=S0UWQ5eiPole4dtyMpW+QWxdEfHVw9PtKgJf/N5G9BE=; b=sBAVSpl81d3DvYPGB43hMMc2apeLOCX3BpgVO0g7sfr03UhlBGqYh53X6BEXd89csS 4/0A6N2+rk2bkYXVpDy01rBe6D5rriQbjuAtKQY0XI6QLrZbPpII4POUFAX2hk2OttWP iDoQw+L5Uy+SiLwJvqJ1wPJnZ0BlFIUJ5zJ79ju2HEe4QT96ZXKnHroVjlXkjOg+u9HF mcyCGgiVwcPciyJ2UsBYBj37j7nxUTEhMrD0d3qVzjK7dq8zU34BE14va7eyzBFt572J RjB+Pbl4nD3i8epjADpY4ef/aZzrH66Z/DSQyhq7dU1eleJBvYqtokO+5oTY7qDGYNKr W4sg== X-Gm-Message-State: APjAAAV2j2aCIQhEbfCzoCyO9rbKMAtWVxE1Z+7ZyHBRuW3133t8/dVt zHBCaQxTlpT88JtTH14AFV7WjR27NtHbjPg0kYg= X-Google-Smtp-Source: APXvYqzb0EPNSu3UgjjKauWV01/SR7f84yg5f0P7XG0wUME17ghX3UNDGcccyOdk37JFXAIVeBt6IZuJXPTA7xlaSIc= X-Received: by 2002:aca:36c5:: with SMTP id d188mr2423967oia.54.1575462799999; Wed, 04 Dec 2019 04:33:19 -0800 (PST) MIME-Version: 1.0 References: <20190219103148.192029670@infradead.org> <20190219103233.443069009@infradead.org> <20191204104733.GR2844@hirez.programming.kicks-ass.net> In-Reply-To: <20191204104733.GR2844@hirez.programming.kicks-ass.net> From: Geert Uytterhoeven Date: Wed, 4 Dec 2019 13:32:58 +0100 Message-ID: Subject: Re: [PATCH v6 10/18] sh/tlb: Convert SH to generic mmu_gather To: Peter Zijlstra Cc: Will Deacon , "Aneesh Kumar K.V" , Andrew Morton , Nicholas Piggin , Linux-Arch , Linux MM , Linux Kernel Mailing List , Russell King , Heiko Carstens , Rik van Riel , Yoshinori Sato , Rich Felker , Linux-sh list , Guenter Roeck Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hoi Peter, On Wed, Dec 4, 2019 at 11:48 AM Peter Zijlstra wrote= : > On Tue, Dec 03, 2019 at 12:19:00PM +0100, Geert Uytterhoeven wrote: > > On Tue, Feb 19, 2019 at 11:35 AM Peter Zijlstra = wrote: > > > Generic mmu_gather provides everything SH needs (range tracking and > > > cache coherency). > > > > > > Cc: Will Deacon > > > Cc: "Aneesh Kumar K.V" > > > Cc: Andrew Morton > > > Cc: Nick Piggin > > > Cc: Yoshinori Sato > > > Cc: Rich Felker > > > Signed-off-by: Peter Zijlstra (Intel) > > > > I got remote access to an SH7722-based Migo-R again, which spews a long > > sequence of BUGs during userspace startup. I've bisected this to commi= t > > c5b27a889da92f4a ("sh/tlb: Convert SH to generic mmu_gather"). > > Whoopsy.. also, is this really the first time anybody booted an SH > kernel in over a year ?!? Nah, but the v5.4-rc3 I booted recently on qemu -M r2d had CONFIG_PGTABLE_LEVELS=3D2, so it didn't show the problem. > > Do you have a clue? > > Does the below help? Unfortunately not. > diff --git a/arch/sh/include/asm/pgalloc.h b/arch/sh/include/asm/pgalloc.= h > index 22d968bfe9bb..73a2c00de6c5 100644 > --- a/arch/sh/include/asm/pgalloc.h > +++ b/arch/sh/include/asm/pgalloc.h > @@ -36,9 +36,8 @@ do { \ > #if CONFIG_PGTABLE_LEVELS > 2 > #define __pmd_free_tlb(tlb, pmdp, addr) \ > do { \ > - struct page *page =3D virt_to_page(pmdp); \ > - pgtable_pmd_page_dtor(page); \ > - tlb_remove_page((tlb), page); \ > + pgtable_pmd_page_dtor(pmdp); \ expected =E2=80=98struct page *=E2=80=99 but argument is of type =E2=80=98p= md_t * {aka struct *}=E2=80=99 > + tlb_remove_page((tlb), (pmdp)); \ likewise > } while (0); > #endif Gr{oetje,eeting}s, Geert --=20 Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k= .org In personal conversations with technical people, I call myself a hacker. Bu= t when I'm talking to journalists I just say "programmer" or something like t= hat. -- Linus Torvalds