From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44074C43331 for ; Fri, 27 Mar 2020 21:52:25 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CD6AE206DB for ; Fri, 27 Mar 2020 21:52:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="YydX8RqT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CD6AE206DB Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 512EB6B0036; Fri, 27 Mar 2020 17:52:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4C3866B006E; Fri, 27 Mar 2020 17:52:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3B15D6B0078; Fri, 27 Mar 2020 17:52:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0027.hostedemail.com [216.40.44.27]) by kanga.kvack.org (Postfix) with ESMTP id 204696B0036 for ; Fri, 27 Mar 2020 17:52:24 -0400 (EDT) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id BA80A824C739 for ; Fri, 27 Mar 2020 21:52:23 +0000 (UTC) X-FDA: 76642491366.06.soup26_89488c89cd223 X-HE-Tag: soup26_89488c89cd223 X-Filterd-Recvd-Size: 3758 Received: from mail-vs1-f66.google.com (mail-vs1-f66.google.com [209.85.217.66]) by imf48.hostedemail.com (Postfix) with ESMTP for ; Fri, 27 Mar 2020 21:52:23 +0000 (UTC) Received: by mail-vs1-f66.google.com with SMTP id e138so7175515vsc.11 for ; Fri, 27 Mar 2020 14:52:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=KLSkqDjXGppnPQSy1Vn0gnXBsoZc1g+ZDEEe2pp7iqI=; b=YydX8RqTyhKyz/B4VUga1a//AGjDjr7Nr79zSPRYZTfxaC+puymOH7pA23Ql7DCnm1 vYFJQ+FLGy64gw2HerQpyB0gOZNFNO4GkAb4BVErMpMLYCh2EJoOxSr0XYzzBZoqj1PO +IitK6PY4QlHtTFeLIiudauk4IIk6b4g1KSrX4N6XFmaOoKNbATqeNY199XL9aSdE8sN GKXWUJcKt8w9KV5HmET79hldXYVsXrS6AOOYcV0dPTX25mn03Be7fR4qxLog/vo4k4LB KYOXk9/sNR8RTOw3c4G0rwEJTx1BadjJlcuviPy1XTpU2HXFXmzqkJlQsvxMJqqShFEq RCVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KLSkqDjXGppnPQSy1Vn0gnXBsoZc1g+ZDEEe2pp7iqI=; b=d18ub+iS/UiLLmfWFaDs2VpqtakrJKx4KzxfEcFVRkLIRoAkLx3VK48HcMns3WKlNk URkt5RD1YgK4Uzc5v+iU+j6s9XHe1DyXcplCD9SKrXUXPRwnA53hbJHwwZg8o1EJlkpl 7ooYjXs+totwOJ9G0gyfML8phJP38PFK611oZz4sUufKiWWcpOjMP7VVXqf5sMvNIKer L4wG0omz1s5fMfn3EIbSEJOIVpEuvRJ1TooBUXMTVWtRx2KCXximIyL9vj/QxHqXj2B0 h5ypPW5PvCvmI89jMxu6+R77ZuwocZxi49pAtMsCweR9BDbFUg6Q+4b9W1/0mZ9e42zF tR4A== X-Gm-Message-State: AGi0PuZ26bX7HRKGjguCzKN5W2lb7pMxc3ma30bTNain/iRKOJwgLd6B 4qPtnSZLlxuH9zLZMQnqdKJ29k4pz84Zd8K6/mlg+w== X-Google-Smtp-Source: APiQypIoUiQ5u6gME0sLlzFcrOhyd8GUObNa5eYTBQkDXuTqasu0a+KM2vJyyqPfpqdzxA0nd8PMMEomLbZgqgERdRA= X-Received: by 2002:a67:ee81:: with SMTP id n1mr1004632vsp.184.1585345942344; Fri, 27 Mar 2020 14:52:22 -0700 (PDT) MIME-Version: 1.0 References: <20200327021058.221911-1-walken@google.com> <20200327021058.221911-2-walken@google.com> <20200327121625.GS20941@ziepe.ca> In-Reply-To: <20200327121625.GS20941@ziepe.ca> From: Michel Lespinasse Date: Fri, 27 Mar 2020 14:52:09 -0700 Message-ID: Subject: Re: [PATCH v2 01/10] mmap locking API: initial implementation as rwsem wrappers To: Jason Gunthorpe Cc: Andrew Morton , linux-mm , LKML , Peter Zijlstra , Laurent Dufour , Vlastimil Babka , Matthew Wilcox , Liam Howlett , Jerome Glisse , Davidlohr Bueso , David Rientjes , Hugh Dickins , Ying Han , Markus Elfring Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Mar 27, 2020 at 5:16 AM Jason Gunthorpe wrote: > > On Thu, Mar 26, 2020 at 07:10:49PM -0700, Michel Lespinasse wrote: > > > +static inline bool mmap_is_locked(struct mm_struct *mm) > > +{ > > + return rwsem_is_locked(&mm->mmap_sem) != 0; > > +} > > I didn't notice any callers to this in the series? Can it be deleted? Good catch. Yes, it should be deleted. There were 5 uses in v1 of this patchset and I got rid of these in v2 of the patchset, but forgot to actually remove the function definition here. -- Michel "Walken" Lespinasse A program is never fully debugged until the last user dies.