From: Michel Lespinasse <walken@google.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
Laurent Dufour <ldufour@linux.ibm.com>,
Vlastimil Babka <vbabka@suse.cz>,
Matthew Wilcox <willy@infradead.org>,
Liam Howlett <Liam.Howlett@oracle.com>,
Jerome Glisse <jglisse@redhat.com>,
Davidlohr Bueso <dave@stgolabs.net>,
David Rientjes <rientjes@google.com>,
Hugh Dickins <hughd@google.com>, Ying Han <yinghan@google.com>,
Jason Gunthorpe <jgg@ziepe.ca>,
Markus Elfring <Markus.Elfring@web.de>
Subject: Re: [PATCH v3 10/10] mmap locking API: rename mmap_sem to mmap_lock
Date: Mon, 6 Apr 2020 08:49:21 -0700 [thread overview]
Message-ID: <CANN689F9YSG7US=daU7Gp2diEkeb2K6cHs0fsBuM9b3+Vo=n8Q@mail.gmail.com> (raw)
In-Reply-To: <20200401134853.GT20696@hirez.programming.kicks-ass.net>
On Wed, Apr 1, 2020 at 6:48 AM Peter Zijlstra <peterz@infradead.org> wrote:
>
> On Fri, Mar 27, 2020 at 03:51:02PM -0700, Michel Lespinasse wrote:
> > Rename the mmap_sem field to mmap_lock. Any new uses of this lock
> > should now go through the new mmap locking api. The mmap_lock is
> > still implemented as a rwsem, though this could change in the future.
>
> > diff --git a/include/linux/mm_types.h b/include/linux/mm_types.h
> > index c28911c3afa8..a168d13b5c44 100644
> > --- a/include/linux/mm_types.h
> > +++ b/include/linux/mm_types.h
> > @@ -431,7 +431,7 @@ struct mm_struct {
> > spinlock_t page_table_lock; /* Protects page tables and some
> > * counters
> > */
> > - struct rw_semaphore mmap_sem;
> > + struct rw_semaphore mmap_lock;
>
> It would be best if you change the type too.
I suppose you mean wrapping the struct rw_semaphore within a new
struct ? I did not do that in this patchset because there remains some
calls to lockdep_assert_held() on that field, which imply that the
field must have a .dep_map field that's not tucked away behind an
additional struct.
I have another patchset that reimplements the mmap_lock as a different
type (for range locking), with its own dep_map handling, but it's not
ready for pushing to mainline yet...
--
Michel "Walken" Lespinasse
A program is never fully debugged until the last user dies.
prev parent reply other threads:[~2020-04-06 15:49 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-27 22:50 [PATCH v3 00/10] Add a new mmap locking API wrapping mmap_sem calls Michel Lespinasse
2020-03-27 22:50 ` [PATCH v3 01/10] mmap locking API: initial implementation as rwsem wrappers Michel Lespinasse
2020-03-28 8:57 ` [PATCH v3 01/10] mmap locking API: initial implementation as rwsem wrappers (Michel Lespinasse) SeongJae Park
2020-03-27 22:50 ` [PATCH v3 02/10] MMU notifier: use the new mmap locking API Michel Lespinasse
2020-03-27 22:50 ` [PATCH v3 03/10] DMA reservations: " Michel Lespinasse
2020-03-27 22:50 ` [PATCH v3 04/10] mmap locking API: use coccinelle to convert mmap_sem rwsem call sites Michel Lespinasse
2020-03-27 22:50 ` [PATCH v3 05/10] mmap locking API: convert mmap_sem call sites missed by coccinelle Michel Lespinasse
2020-03-28 7:36 ` Markus Elfring
2020-03-28 7:47 ` Michel Lespinasse
2020-03-28 8:39 ` [v3 " Markus Elfring
2020-03-28 8:53 ` Michel Lespinasse
2020-03-28 9:01 ` Markus Elfring
2020-03-28 13:20 ` [v3 05/10] mmap locking API: Checking the Coccinelle software Markus Elfring
2020-03-28 13:42 ` [Cocci] " Julia Lawall
2020-03-28 13:52 ` Markus Elfring
2020-03-28 13:53 ` Julia Lawall
2020-03-28 14:00 ` Julia Lawall
2020-03-28 14:16 ` Markus Elfring
2020-03-30 6:10 ` [v3 05/10] mmap locking API: Improving " Markus Elfring
2020-03-30 8:47 ` [Cocci] " Julia Lawall
2020-03-30 10:15 ` Markus Elfring
2020-03-30 10:20 ` Julia Lawall
2020-03-30 10:42 ` Markus Elfring
2020-04-13 17:06 ` [PATCH v3 05/10] mmap locking API: convert mmap_sem call sites missed by coccinelle Daniel Jordan
2020-03-27 22:50 ` [PATCH v3 06/10] mmap locking API: convert nested write lock sites Michel Lespinasse
2020-04-01 13:42 ` Peter Zijlstra
2020-04-06 15:35 ` Michel Lespinasse
2020-04-06 15:58 ` Peter Zijlstra
2020-03-27 22:50 ` [PATCH v3 07/10] mmap locking API: add mmap_read_release() and mmap_read_unlock_non_owner() Michel Lespinasse
2020-04-01 13:46 ` Peter Zijlstra
2020-04-06 15:39 ` Michel Lespinasse
2020-03-27 22:51 ` [PATCH v3 08/10] mmap locking API: add MMAP_LOCK_INITIALIZER Michel Lespinasse
2020-03-27 22:51 ` [PATCH v3 09/10] mmap locking API: use lockdep_assert_held Michel Lespinasse
2020-03-27 22:51 ` [PATCH v3 10/10] mmap locking API: rename mmap_sem to mmap_lock Michel Lespinasse
2020-04-01 13:48 ` Peter Zijlstra
2020-04-06 15:49 ` Michel Lespinasse [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANN689F9YSG7US=daU7Gp2diEkeb2K6cHs0fsBuM9b3+Vo=n8Q@mail.gmail.com' \
--to=walken@google.com \
--cc=Liam.Howlett@oracle.com \
--cc=Markus.Elfring@web.de \
--cc=akpm@linux-foundation.org \
--cc=dave@stgolabs.net \
--cc=hughd@google.com \
--cc=jgg@ziepe.ca \
--cc=jglisse@redhat.com \
--cc=ldufour@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=peterz@infradead.org \
--cc=rientjes@google.com \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
--cc=yinghan@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).