From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D361C2BA19 for ; Wed, 22 Apr 2020 02:10:55 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C8387206D5 for ; Wed, 22 Apr 2020 02:10:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="MCnsp+oi" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C8387206D5 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 61EF38E0005; Tue, 21 Apr 2020 22:10:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5D0558E0003; Tue, 21 Apr 2020 22:10:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 50BB28E0005; Tue, 21 Apr 2020 22:10:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0252.hostedemail.com [216.40.44.252]) by kanga.kvack.org (Postfix) with ESMTP id 3D05F8E0003 for ; Tue, 21 Apr 2020 22:10:54 -0400 (EDT) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id EF4A7180AD807 for ; Wed, 22 Apr 2020 02:10:53 +0000 (UTC) X-FDA: 76733862786.19.skate10_41ff1a32e9d1e X-HE-Tag: skate10_41ff1a32e9d1e X-Filterd-Recvd-Size: 3893 Received: from mail-yb1-f194.google.com (mail-yb1-f194.google.com [209.85.219.194]) by imf47.hostedemail.com (Postfix) with ESMTP for ; Wed, 22 Apr 2020 02:10:53 +0000 (UTC) Received: by mail-yb1-f194.google.com with SMTP id i2so396678ybk.2 for ; Tue, 21 Apr 2020 19:10:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2tQbdOPCxIE/K09Rk6AnWK5NVIGzgtGeQWhwa+aoWFg=; b=MCnsp+oim3XYeA5xLQ0O6mol7X2v17gfJ2/fvRp34u7NVtVAxV09gtDg/l4k2L4ROb riYMlKo5ay/ZMVbUJ7+bGwuQAGc78MaGRhc06tX5zCpyfaRmxOcEvTc+Mq96S2b0/0HN USL1HSbIGfPZHn5upNxuILkVltbfhf7jrmzj7ffY02kvdrfZHoVYJCb5uaXQ3Uv6XB+Q vUtcqm5soQpR51voh0kDtg80SiATM/wNgo1Hau5MNTSsxyawm42OIQow2Ee6qhG+V8WF cA7dAeRdOhYxaJv1/iSVFliUQWgtqmw6ALomBDlH6cA8BF/IcmjsO6rxCWTDHMoiBHY6 xwoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2tQbdOPCxIE/K09Rk6AnWK5NVIGzgtGeQWhwa+aoWFg=; b=d9K9i4R4+GQXVFDyClHXiL6sIhFuOMzN2ko3qn2HWDzSIcNpRT7mjz4FWFUahYXXlJ WknEW8FDTtrqPpNfiS1JwKJvZ4v9oQUL8OaEs83AD3x1Y9c/tqhdwwb3hAOS5jM09gs8 QfNrVg9+vCO5T0TIkxTi144nWel3FdOKnjaUV1lTso5GQ08xhEEx9ZJBw7BsfD4OIx1B WV/jFPfmrxJCbIj6o85ZYSfNkHFkAAFKcxIdS8ftM3GxbRcAo5YRhTk8b/C1Nq80wUAv OVYVBTfV6R3n9Aq1UyyZ61OiIBbZB0GTeGnNgB4ccjlw8Ck0fq8N2BbdXvao9hFHg7ud gaNg== X-Gm-Message-State: AGi0PuYAG8l5x6iI/0hXC4RTwjwvRT2wfw0oZ9fCTUU6m1xkG2Bw+dqI jZJ9FUnUuC3DiWo7gAVNHw2dfHHKcM1zXx7ivp6Smg== X-Google-Smtp-Source: APiQypJWt0jllq8PUpBD1WeSTR4j+afUjLDp5+ewhll1TBEqJx7nHX779bPW4eO07cAv45lmeAP5M8CBx5DfsZYBD1w= X-Received: by 2002:a5b:383:: with SMTP id k3mr32955292ybp.332.1587521452409; Tue, 21 Apr 2020 19:10:52 -0700 (PDT) MIME-Version: 1.0 References: <20200422001422.232330-1-walken@google.com> <20200422001422.232330-10-walken@google.com> In-Reply-To: <20200422001422.232330-10-walken@google.com> From: Michel Lespinasse Date: Tue, 21 Apr 2020 19:10:39 -0700 Message-ID: Subject: Re: [PATCH v5 09/10] mmap locking API: add mmap_assert_locked To: Andrew Morton , linux-mm Cc: LKML , Peter Zijlstra , Laurent Dufour , Vlastimil Babka , Matthew Wilcox , Liam Howlett , Jerome Glisse , Davidlohr Bueso , David Rientjes , Hugh Dickins , Ying Han , Jason Gunthorpe , Daniel Jordan Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Apr 21, 2020 at 5:14 PM Michel Lespinasse wrote: > +static inline void mmap_assert_locked(struct mm_struct *mm) > +{ > + if (IS_ENABLED(CONFIG_LOCKDEP) && debug_locks) > + VM_BUG_ON_MM(!lockdep_is_held(&mm->mmap_sem), mm); > + else > + VM_BUG_ON_MM(!rwsem_is_locked(&mm->mmap_sem), mm); > +} Turns out this function definition does not work for !CONFIG_LOCKDEP as lockdep_is_held is not defined in that case. The following should work instead: static inline void mmap_assert_locked(struct mm_struct *mm) { #ifdef CONFIG_LOCKDEP if (debug_locks) { VM_BUG_ON_MM(!lockdep_is_held(&mm->mmap_lock), mm); return; } #endif VM_BUG_ON_MM(!rwsem_is_locked(&mm->mmap_lock), mm); }