From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0A37C2D0E7 for ; Thu, 26 Mar 2020 22:18:08 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6D4C020658 for ; Thu, 26 Mar 2020 22:18:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="av4d1pkU" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6D4C020658 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id EB8186B000A; Thu, 26 Mar 2020 18:18:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E690E6B000C; Thu, 26 Mar 2020 18:18:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D7EA36B000D; Thu, 26 Mar 2020 18:18:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0057.hostedemail.com [216.40.44.57]) by kanga.kvack.org (Postfix) with ESMTP id BEB4B6B000A for ; Thu, 26 Mar 2020 18:18:07 -0400 (EDT) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 84B3B181AD0A5 for ; Thu, 26 Mar 2020 22:18:07 +0000 (UTC) X-FDA: 76638927414.15.card47_cb3699579b48 X-HE-Tag: card47_cb3699579b48 X-Filterd-Recvd-Size: 4312 Received: from mail-yb1-f195.google.com (mail-yb1-f195.google.com [209.85.219.195]) by imf40.hostedemail.com (Postfix) with ESMTP for ; Thu, 26 Mar 2020 22:18:07 +0000 (UTC) Received: by mail-yb1-f195.google.com with SMTP id 204so3505340ybw.5 for ; Thu, 26 Mar 2020 15:18:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=rMAug3DWz0TSaHlbxKB6CB5hPFQDwkF0k5KEtu7t628=; b=av4d1pkU3ehBAUGMaoWdCB5066rUk1GBdi/rocNTl+Zl+FcgXm75+D+6TqXVaoDuZj bIH2vlCo7H74Z5EZfhnpMUu9lDny8U/LHfMdT9ZpD/7L2FA+rD/KMixlMm9uihpK8XoT 3OLM4mPYYNA/aKN9XEXdcPZSJOpBs3UyZDLQbfRR+rkm9nfMSXdmnI+J383qnatlaELW 4X2oIEptirmf9nYH3SGA0bnIX8Ujdr1z605X04LMgWHVHDQyRDmH1v6AA6Z+GML1LHwv UfZvinjhLqhUbzvfQKonk90I9bYy3uyF5QNiFahwpp5IN7XlaKclXUDkLo76/gUzzaz3 p5zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rMAug3DWz0TSaHlbxKB6CB5hPFQDwkF0k5KEtu7t628=; b=F2ukYFgX4mnjWPXT7yFPnDLIzNmkVwhPtqRTV1tlHcimakFWHCbxco78GYvFHfwMum pkN8WVQ6sTt6s/Qry3JAYXsoW2lZWevcFQEoSfO8eNfKxIh1+MqZEBc4YzWc7QMceAVB A4LseztkeoifsUQrbWyzK+F8RDJ+0o8DEuIs4M5cejjOLUOEuhn5ZQp47wIOA9JGCLTV TMGxQUSzE6OtQkcq4N3FM973lv9G+G1ViG68unRd01D0pRnatmb+kmzHs4fCW7qoSjEg p3K4tRhxaXvLHqHJo2AopSY70EUsKxiIJZDRyhCDPuuAcgUx13Vp1UWAgXA8y4BTCsv7 C7Vw== X-Gm-Message-State: ANhLgQ15f9Hi2HTwT8mlB/exdGr3WXa7ZC3zorwBdlSsDkH4dYvPAXfJ no1N6aj7Cf1RZ0bnLvR7EKfjuB/GnafYLObe+OM63Q== X-Google-Smtp-Source: ADFU+vvnApwiZsKP73hw6IWcwuZ+GZ8XTLu5Ux02Lu70iJ3p+hyi5HVvjnfNkq1llKklVkZgmeV0E8jRVxaZmUJ4JAA= X-Received: by 2002:a25:4e02:: with SMTP id c2mr398067ybb.504.1585261084799; Thu, 26 Mar 2020 15:18:04 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Michel Lespinasse Date: Thu, 26 Mar 2020 15:17:52 -0700 Message-ID: Subject: Re: [PATCH 3/8] mmap locking API: use coccinelle to convert mmap_sem rwsem call sites To: Markus Elfring Cc: linux-mm , Andrew Morton , David Rientjes , Davidlohr Bueso , Hugh Dickins , Jerome Glisse , Laurent Dufour , Liam Howlett , Matthew Wilcox , Peter Zijlstra , Vlastimil Babka , Ying Han , LKML , kernel-janitors@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: That seems to work too. I'm quite noobish in using coccinelle, so I wouldn't have been able to come up with that version on my own. On Thu, Mar 26, 2020 at 6:30 AM Markus Elfring wrote: > > > This change converts the existing mmap_sem rwsem calls to use the new > > mmap locking API instead. > > > > The change is generated using coccinelle with the following rules: > > Do you find the following script variant more succinct together > with the usage of a disjunction in a single SmPL rule? > > > @replacement@ > expression x; > @@ > ( > -init_rwsem > +mmap_init_lock > | > -down_write > +mmap_write_lock > | > -down_write_killable > +mmap_write_lock_killable > | > -down_write_trylock > +mmap_write_trylock > | > -up_write > +mmap_write_unlock > | > -downgrade_write > +mmap_downgrade_write_lock > | > -down_read > +mmap_read_lock > | > -down_read_killable > +mmap_read_lock_killable > | > -down_read_trylock > +mmap_read_trylock > | > -up_read > +mmap_read_unlock > | > -rwsem_is_locked > +mmap_is_locked > ) > ( > - & > x > - ->mmap_sem > ) > > > Regards, > Markus -- Michel "Walken" Lespinasse A program is never fully debugged until the last user dies.