From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6507CC433DF for ; Thu, 14 May 2020 09:20:08 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 17A3720675 for ; Thu, 14 May 2020 09:20:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b="kgGXhGiH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 17A3720675 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9B5A690002E; Thu, 14 May 2020 05:20:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 96735900028; Thu, 14 May 2020 05:20:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 854E790002E; Thu, 14 May 2020 05:20:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0233.hostedemail.com [216.40.44.233]) by kanga.kvack.org (Postfix) with ESMTP id 6B1E8900028 for ; Thu, 14 May 2020 05:20:07 -0400 (EDT) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 277C58248047 for ; Thu, 14 May 2020 09:20:07 +0000 (UTC) X-FDA: 76814778054.06.kiss68_fb3b917091a X-HE-Tag: kiss68_fb3b917091a X-Filterd-Recvd-Size: 5963 Received: from mail-oo1-f67.google.com (mail-oo1-f67.google.com [209.85.161.67]) by imf17.hostedemail.com (Postfix) with ESMTP for ; Thu, 14 May 2020 09:20:06 +0000 (UTC) Received: by mail-oo1-f67.google.com with SMTP id v6so577658oou.4 for ; Thu, 14 May 2020 02:20:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hfujMWkWYSOVCYIJWFoJkDKJQRur5E63O5/YKBInhyE=; b=kgGXhGiH+T7tuHxSxlNSMaXvsrAxGMIDRLGIWHNXCZ69VeN/akpFg7e0k+jM1odif2 XmgjPf7KP1P18eR8yjlY3q3is8YItmNwmhSZri5Gv+axxO2IY5PNE7snQHyHT55XK/B+ ozwExZMubgVValmCcrcTMOh3eX3Qxu8T06CuXqJQysMTEGromuZEMYvB42hEJcp0jykR EcEBtsYWs0yqZZ3Tuz0KooWd8ZsCKUTGwLD015t7gPLS1i3Dq2geTDGf7WNGVuHIeY6H kHctyWyGV1sK+pU8NdnHCSXTkLlLQ/p5ZtdhaDwe+hXMeXZXn6O4LgtuEjSUHU9gz0C0 OSTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hfujMWkWYSOVCYIJWFoJkDKJQRur5E63O5/YKBInhyE=; b=WnroE+y0UsxlNMCXBCcewPfk3MF2BhhyTM/f7Pl4+01J2FdsSxiyr6Y1o/p3JekGbB 4gkU6oOKg++ITpFxlCYozW0FNlG9NVYJwVAJf4bgqAoO6r0XbV1Gk2zfobIO54HF+HhX offZP28wfNJuo+y89xEalc4MygVcMrBWo3CmBUtte5T2pa6Z/BbRFqwOlAimFS3EkVz0 smyFniN+Hf5BJuNcNOCZf4Z2utyu3mqTlNfPXDxBEUT0pWUuU5z+WlaCJI4Ykz3kBbh6 XG3ef9/o4ag7fZ3g2ev5R3HYjt1KiSc6WQ5ecdXgLFtGLNZr1WmgV04v/TTfNbcAnwk5 9oxg== X-Gm-Message-State: AOAM531z1sGrEJFhBDAVZwciMyu9xnwQsqzL6nDopeplrpre7cmYDnhF aI5RF5wcRrLBLbS5UM1PDa7P3HK8jpER7sV/AQbedQ== X-Google-Smtp-Source: ABdhPJw0159xdarLAommnsC34kOQZRcdvRBeicM5dtl7J3cZYiQ5vuV1L023QweOKDoP1HPFyzsrZasxtu4ZgTm4PgY= X-Received: by 2002:a4a:d103:: with SMTP id k3mr2818208oor.68.1589448005801; Thu, 14 May 2020 02:20:05 -0700 (PDT) MIME-Version: 1.0 References: <202005091847.zkVHPjis%lkp@intel.com> <20200513180745.30cfb5d0011c8e12972bdb8d@linux-foundation.org> <2a772f7b-bf5c-9f12-a3c9-92fb3e886f77@huawei.com> In-Reply-To: <2a772f7b-bf5c-9f12-a3c9-92fb3e886f77@huawei.com> From: Zong Li Date: Thu, 14 May 2020 17:19:55 +0800 Message-ID: Subject: Re: [linux-next:master 7592/7905] arch/riscv/mm/ptdump.c:57:3: error: 'FIXADDR_START' undeclared here (not in a function); did you mean 'XAS_RESTART'? To: Kefeng Wang Cc: Andrew Morton , kbuild test robot , kbuild-all@lists.01.org, Linux Memory Management List Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, May 14, 2020 at 4:37 PM Kefeng Wang wrote: > > > On 2020/5/14 11:47, Zong Li wrote: > > On Thu, May 14, 2020 at 9:07 AM Andrew Morton wrote: > >> On Sat, 9 May 2020 18:46:50 +0800 kbuild test robot wrote: > >> > >>> Hi Zong, > >>> > >>> First bad commit (maybe != root cause): > >>> > >>> tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > >>> head: 30e2206e11ce27ae910cc0dab21472429e400a87 > >>> commit: c0eba2d72e70b4208ca6fd82820ba7428090e350 [7592/7905] riscv: support DEBUG_WX > >>> config: riscv-randconfig-r003-20200509 (attached as .config) > >>> compiler: riscv64-linux-gcc (GCC) 9.3.0 > >>> reproduce: > >>> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > >>> chmod +x ~/bin/make.cross > >>> git checkout c0eba2d72e70b4208ca6fd82820ba7428090e350 > >>> # save the attached .config to linux build tree > >>> COMPILER_INSTALL_PATH=$HOME/0day GCC_VERSION=9.3.0 make.cross ARCH=riscv > >>> > >>> If you fix the issue, kindly add following tag as appropriate > >>> Reported-by: kbuild test robot > >>> > >>> All error/warnings (new ones prefixed by >>): > >>> > >>>>> arch/riscv/mm/ptdump.c:57:3: error: 'FIXADDR_START' undeclared here (not in a function); did you mean 'XAS_RESTART'? > >>> 57 | {FIXADDR_START, "Fixmap start"}, > >>> | ^~~~~~~~~~~~~ > >>> | XAS_RESTART > >> argh, I can't figure out how to make riscv compile :( > >> > >> Are you using the riscv32 toolchain or riscv64? > >> > >> And arch/riscv/include/asm/perf_event.h does > >> > >> #ifdef CONFIG_RISCV_BASE_PMU > >> #define RISCV_MAX_COUNTERS 2 > >> #endif > >> > >> #ifndef RISCV_MAX_COUNTERS > >> #error "Please provide a valid RISCV_MAX_COUNTERS for the PMU." > >> #endif > >> > >> where is RISCV_MAX_COUNTERS supposed to come from? Surely this should > >> be implemented in Kconfig somehow? > >> > >> Sigh. Zong, did you take a look at this? > > Yes, I had taken a look at that, the problem is that the .config > > selects CONFIG_PERF_EVENTS, but doesn't select CONFIG_RISCV_BASE_PMU > > together. It seems to me that it is a bug of perf porting on RISC-V, > > CONFIG_RISCV_BASE_PMU could be selected or unselected, but in fact, > > CONFIG_RISCV_BASE_PMU must be always selected when selecting > > CONFIG_PERF_EVENTS on RISC-V perf implementation. Maybe let me send a > > patch to fix it. > > Hi Andrew and Zong, I have sent some fix patches, and Palmer accept > > them. > > https://lore.kernel.org/linux-riscv/mhng-d7e9b8e8-2c97-490b-9eac-fd88c7a5a34d@palmerdabbelt-glaptop1/T/#t > Hi Kefeng, I saw that, thanks. Regarding RISCV_BASE_PMU, I didn't notice that you had a patch to fix it already, so I also posted a patch to fix the dependency of RISCV_BASE_PMU. Let's switch to discuss it on that thread. > > > > > > >