From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F7F8C433F5 for ; Wed, 16 Feb 2022 10:51:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 138646B0073; Wed, 16 Feb 2022 05:51:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0E8456B0074; Wed, 16 Feb 2022 05:51:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F199C6B0078; Wed, 16 Feb 2022 05:51:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0136.hostedemail.com [216.40.44.136]) by kanga.kvack.org (Postfix) with ESMTP id E26476B0073 for ; Wed, 16 Feb 2022 05:51:12 -0500 (EST) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 71733181AC9C6 for ; Wed, 16 Feb 2022 10:51:12 +0000 (UTC) X-FDA: 79148325984.15.C8A50E4 Received: from mail-vk1-f181.google.com (mail-vk1-f181.google.com [209.85.221.181]) by imf16.hostedemail.com (Postfix) with ESMTP id 0470A180006 for ; Wed, 16 Feb 2022 10:51:11 +0000 (UTC) Received: by mail-vk1-f181.google.com with SMTP id j9so1042318vkj.1 for ; Wed, 16 Feb 2022 02:51:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=nIKz2AezeBlsV735RvnAexh8fOwlUs4AtVj0CV5E4jY=; b=bJMHEb/+6AM8y58sCM0vR2WBJ6fD3lI/BkkZHADrAS/QLU2Y21gDYyxF0LoHdJT1OL 84K29/v7J6xmTazyaK+/7S/V/uS6RcDgvHiqaosW4JIe0sR70VLXR/1Y0x9nOO3V5xHz EqaiQM0PDxMoWdR3X9dI27LFMmRjP/CLOPv2BvzohiHe1iW/RHZNhOd5vPJJO8Y3Jrnv q4r8xIkxXmfdr7CvId0G4Flc345mQ2t4UYwCVjU7c4w0zGkUgeQ8e/VtxVGR1GH69qm+ MeZBPqpjUp8OeM/UJTZFaMVjOkGLQ1piAlF0TrVQFqDe5eex4tDahMokbvN56cCy63Vw bXoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nIKz2AezeBlsV735RvnAexh8fOwlUs4AtVj0CV5E4jY=; b=2aDbJ27JAoJ3sL+QnhfV1IJvYingty9SxVtQxQKf+Y7CxKBn4JuEQR8aeDfHcGwffH n//CRpf+p8Jsiif1xdvcvMzuFh1l4ylydBJ2KE30D81FybHWs1YcNZWumhdbrF+VWvvS 6s3NW7wtc97f/Yb6FG6DAlsnaPL6A6YZMk6gUasDqs16iFU00nmMP4ke+P9vnKHjOhS/ r2A3d3T+NXPzbnaEw4jDdDlas42Epkab1e1uCOXeS/HvSc/uBmCMOr1VZ9RLDOaypq9R 9Xoef/G+8S0d7gI7NZf9rr1VCWWeCBOHJGC/5hfk9lUfmSNGpc/WKg6VTsZXXN0JMHA2 T22Q== X-Gm-Message-State: AOAM532CSbs1cxyG3bu3gbd+3GsIByOO/TxSttbWLCpWqdCE/+jQ6hlY YSJvRJj2IGaekYic42NnadszZ6V+n+4Mi9cWamQ= X-Google-Smtp-Source: ABdhPJzk9yXjryefk0i7cZBHDfLTYCLHrV26Qk+ZfKYWQbqbQ5Qtqu/FEjeGX18+BGIF81mGfyg39X3rd0uuNw7HbkQ= X-Received: by 2002:a05:6122:8cf:b0:326:361c:bdd9 with SMTP id 15-20020a05612208cf00b00326361cbdd9mr623062vkg.35.1645008671300; Wed, 16 Feb 2022 02:51:11 -0800 (PST) MIME-Version: 1.0 References: <20220215143728.3810954-1-Liam.Howlett@oracle.com> <20220215144241.3812052-1-Liam.Howlett@oracle.com> <20220215144241.3812052-11-Liam.Howlett@oracle.com> In-Reply-To: <20220215144241.3812052-11-Liam.Howlett@oracle.com> From: Mark Hemment Date: Wed, 16 Feb 2022 10:50:59 +0000 Message-ID: Subject: Re: [PATCH v6 11/71] mm: Add VMA iterator To: Liam Howlett Cc: "maple-tree@lists.infradead.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Andrew Morton Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 0470A180006 X-Rspam-User: Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=googlemail.com header.s=20210112 header.b="bJMHEb/+"; spf=pass (imf16.hostedemail.com: domain of markhemm@googlemail.com designates 209.85.221.181 as permitted sender) smtp.mailfrom=markhemm@googlemail.com; dmarc=pass (policy=quarantine) header.from=googlemail.com X-Stat-Signature: td4ixqde9dfs54qabm736hzsn3ff4ibm X-Rspamd-Server: rspam03 X-HE-Tag: 1645008671-852103 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 15 Feb 2022 at 14:43, Liam Howlett wrote: > > From: "Matthew Wilcox (Oracle)" > > This thin layer of abstraction over the maple tree state is for > iterating over VMAs. You can go forwards, go backwards or ask where > the iterator is. Rename the existing vma_next() to __vma_next() -- > it will be removed by the end of this series. > > Signed-off-by: Matthew Wilcox (Oracle) > Signed-off-by: Liam R. Howlett > Acked-by: Vlastimil Babka > --- > include/linux/mm.h | 31 +++++++++++++++++++++++++++++++ > include/linux/mm_types.h | 21 +++++++++++++++++++++ > mm/mmap.c | 10 +++++----- > 3 files changed, 57 insertions(+), 5 deletions(-) > > diff --git a/include/linux/mm.h b/include/linux/mm.h > +/* The MM code likes to work with exclusive end addresses */ > +#define for_each_vma_range(vmi, vma, end) \ > + while ((vma = vma_find(&vmi, end - 1)) != NULL) > + Becareful of operator precedence; parentheses around "end'". Cheers, Masrk