From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0077BC6FA8B for ; Thu, 22 Sep 2022 09:23:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 12FB6940007; Thu, 22 Sep 2022 05:23:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0E0676B0072; Thu, 22 Sep 2022 05:23:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EE9B2940007; Thu, 22 Sep 2022 05:23:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id DBBEE6B0071 for ; Thu, 22 Sep 2022 05:23:58 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 7BF0512140E for ; Thu, 22 Sep 2022 09:23:58 +0000 (UTC) X-FDA: 79939184556.10.101527F Received: from mail-io1-f46.google.com (mail-io1-f46.google.com [209.85.166.46]) by imf29.hostedemail.com (Postfix) with ESMTP id 2DF70120011 for ; Thu, 22 Sep 2022 09:23:58 +0000 (UTC) Received: by mail-io1-f46.google.com with SMTP id r134so7186688iod.8 for ; Thu, 22 Sep 2022 02:23:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=eq1ulTtXYhBmIV3Hec+MzaFRLDXw1vSRF6+bOMmPhJ4=; b=bE2W6qfxPeZ5hG8th9HBte8uWTQjYuCcr36yI1hhiheOM64/zofTi1amyoUC/YRb+J NgesQGAjTL00GMSehk4Np33KVgoKvpm/Mh3RSzMdF+EkL5Y4k9K6GB3q17DXyKsUm/6E tSUleWEaIUryrEiqLEE56d9SYCS/YFMrs6gU37f7Pqu7tr26K2zmBNy6tAGoGVxQ5f+n DlMD1/oSQBrQp/QHyG7CgFktY+50H+Wm33tTFaH8FxMf0iDQdWTe9OU6Ok7FDH/xYrVm +Y17qm2jbLBl43Ckz4h9g/NlAB7oNcZMDPJUHArvKPR8Jrr0Y7Jjk4kBCdA2lo60DN3B Aphg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=eq1ulTtXYhBmIV3Hec+MzaFRLDXw1vSRF6+bOMmPhJ4=; b=rgoqsgzd0Tep7XqLoaAGIWv5jGKIjix8m2XfJ3xzJSkSrdPDz3lL9FAJJd+ajq+n+C EnE/bLirz0yHyj1aYzBDWGMp9PGNyE/cSlm8RDJ9ya0/T40I/K/Hk5xz0mNXgBU/J34+ 5skpFh+PzTKyBXfPEJeiXUv+hp2aZHE6Y+99p2QUdXLwVWUWuMpFpx5mLKz0hqxPZdZ3 c+b8XbX4kjQWVvT/3odZKLC3f/mFqIibouPr9psJBzx5LbOqxQ4LXWNH6KHCQ4RPr4Bc /arrHzcvwXZMjJXw9TXdGZTIQVOKqVSB04r8qGce2zjS1eAM631LBwQeacvMitVXO9P4 6acw== X-Gm-Message-State: ACrzQf1kR18RP6UGTmLvgBhg180qttBop8H6BU+fRPwdAeWFexDCE+hB 35mgYhziJilr+CLXct/QGE1u1lu5GwVzfUX04gA= X-Google-Smtp-Source: AMsMyM4VmAwcaT5Lc+Ww++2Y7GpjHXOf8JO1cC9hLR1vHps4lN+vAXggqFNSedolxw1DncuzKFlDGIHvcmXTBzRY/kM= X-Received: by 2002:a05:6638:dcc:b0:35a:7ba6:ad51 with SMTP id m12-20020a0566380dcc00b0035a7ba6ad51mr1404409jaj.256.1663838637536; Thu, 22 Sep 2022 02:23:57 -0700 (PDT) MIME-Version: 1.0 References: <20220922031013.2150682-1-keescook@chromium.org> <20220922031013.2150682-12-keescook@chromium.org> In-Reply-To: <20220922031013.2150682-12-keescook@chromium.org> From: Miguel Ojeda Date: Thu, 22 Sep 2022 11:23:46 +0200 Message-ID: Subject: Re: [PATCH 11/12] slab: Remove __malloc attribute from realloc functions To: Kees Cook Cc: Vlastimil Babka , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Nick Desaulniers , Hao Luo , Marco Elver , linux-mm@kvack.org, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Greg Kroah-Hartman , Alex Elder , Josef Bacik , David Sterba , Sumit Semwal , =?UTF-8?Q?Christian_K=C3=B6nig?= , Jesse Brandeburg , Daniel Micay , Yonghong Song , Miguel Ojeda , Jacob Shin , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, linux-fsdevel@vger.kernel.org, intel-wired-lan@lists.osuosl.org, dev@openvswitch.org, x86@kernel.org, linux-wireless@vger.kernel.org, llvm@lists.linux.dev, linux-hardening@vger.kernel.org Content-Type: text/plain; charset="UTF-8" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663838638; a=rsa-sha256; cv=none; b=yJwmaqlwuaohzhlVOT1uxRVui3JC04KhNmj9uMJC6XPmO+mVf4qLF+Spt4njvsG5UA1FWR /9zktCoG18AC7A5YuHw6A9QLLtBabIL+3uZv1dkS1AwgOI//uq7NJuas5p/EYmMJq1o4OR dxnBNvfGu+A3UiC9Og/Ockk9IhvbJ10= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=bE2W6qfx; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf29.hostedemail.com: domain of miguel.ojeda.sandonis@gmail.com designates 209.85.166.46 as permitted sender) smtp.mailfrom=miguel.ojeda.sandonis@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663838638; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eq1ulTtXYhBmIV3Hec+MzaFRLDXw1vSRF6+bOMmPhJ4=; b=3n9Hdel0FrnGW2gAOlDqSQfsEJ8+uU0ysVrp1Z+U+J4+CTAaEXIues043Oe76OCcTuxWjM spHLvhgUP+90xJ+raMRXJuS+HfISajZObvYReBtR3FhnBEVzkJJQJWiVBK3Ba2V2ZcMfv8 UY8MkkfPgr0P48tcCOygqpXwopLGS68= X-Stat-Signature: x7fofqhy3qqkiws7izrpkw64xcz761tp X-Rspamd-Queue-Id: 2DF70120011 Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=bE2W6qfx; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf29.hostedemail.com: domain of miguel.ojeda.sandonis@gmail.com designates 209.85.166.46 as permitted sender) smtp.mailfrom=miguel.ojeda.sandonis@gmail.com X-Rspamd-Server: rspam02 X-Rspam-User: X-HE-Tag: 1663838638-576636 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Sep 22, 2022 at 5:10 AM Kees Cook wrote: > > -#ifdef __alloc_size__ > -# define __alloc_size(x, ...) __alloc_size__(x, ## __VA_ARGS__) __malloc > -#else > -# define __alloc_size(x, ...) __malloc > -#endif > +#define __alloc_size(x, ...) __alloc_size__(x, ## __VA_ARGS__) __malloc > +#define __realloc_size(x, ...) __alloc_size__(x, ## __VA_ARGS__) These look unconditional now, so we could move it to `compiler_attributes.h` in a later patch (or an independent series). Cheers, Miguel