From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B277C433E0 for ; Fri, 19 Feb 2021 22:15:16 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9028760201 for ; Fri, 19 Feb 2021 22:15:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9028760201 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 09F5D6B0005; Fri, 19 Feb 2021 17:15:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 04FD46B006C; Fri, 19 Feb 2021 17:15:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E80B26B006E; Fri, 19 Feb 2021 17:15:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0134.hostedemail.com [216.40.44.134]) by kanga.kvack.org (Postfix) with ESMTP id C98546B0005 for ; Fri, 19 Feb 2021 17:15:14 -0500 (EST) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 7FA021837E18A for ; Fri, 19 Feb 2021 22:15:14 +0000 (UTC) X-FDA: 77836424148.01.9FC64FB Received: from mail-yb1-f180.google.com (mail-yb1-f180.google.com [209.85.219.180]) by imf19.hostedemail.com (Postfix) with ESMTP id 9FC8390009E8 for ; Fri, 19 Feb 2021 22:15:11 +0000 (UTC) Received: by mail-yb1-f180.google.com with SMTP id b10so7002085ybn.3 for ; Fri, 19 Feb 2021 14:15:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=l3fHQW5S8vOkKjC/kgnaDz56MlV7mhkQi7D+wo977qc=; b=sabOmR8uPqc8SSP2EmOAlT5XHe/jYNly5knRqK9oHpc4fxD9LfaSonZUPVSZnpBSoq dw2MsXKyanyruDPbYfY5GhBiO7kDjMYP8+S89WOcFpgd7aGllKYdePmmeNCOCodr3g3+ OYpiDJQuhiYz7JevlZ+k3wdTX5UJcyjYquKhFoQ3GlSqtlxbGVxOU0/8AOUD3clPZoxD Pob9QqsLbnOxVvH0Ld/4+IBJ9l18n5aKgpZ5NQkdYgdzNe8woXNmcV8ySrqfwBtq5DBA /av3x3v09l1uQ4ElsCe907PVw5nE961cQb2cl0C5yOX5mWT9/QuPW4t0jkC/0XHCMqd3 OnQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=l3fHQW5S8vOkKjC/kgnaDz56MlV7mhkQi7D+wo977qc=; b=TOpxCEGtixfo1MB9UJ1hUSeVvSFecUtI5mMoBybsfZxA0IWTu3BUueMhDc0kQUuSqs zdD9CdpJJ1mgXdD1asStJnsQHr3XkCDFR1ZbYd+2chSC3lQtAUM633eRWKUnyfXmiQ6b KsCH34uZ4/ymtPrkP9lLCWqiBCZmU5PNVgi21p1ECHIJkglVNVJi2aX600reUpwWwLAm yeSV2Cq9X/wqZxv+d2kCBTOyFcYArYqWPm0bGShCtqSwC9d3ytyZe3pPxpqIXFOVbrzW SKCLpiDwPaVXvgvLKiME62z7ublVR7tRD66KI5DkBK0zf1P2k9mhqhdf4yeZJmL7DiT5 8vfg== X-Gm-Message-State: AOAM531Zhzp6s9pjIgCHqJbjJAlQ6hxCjyBpF+crTAUuGy8LQ6015ARS tWvDEHjxSJ9gLUVd8T2B6fQ/FygZgBsiaIbrG9M= X-Google-Smtp-Source: ABdhPJwEAonsnkW7npOr4TgOhZX3Kw2EYGU67wS5zqbkjBw+7oqhFneIyBMO9ucnAi2kzh955TmdUn9YB0v5TFkzWIM= X-Received: by 2002:a25:cdc5:: with SMTP id d188mr17600822ybf.422.1613772913535; Fri, 19 Feb 2021 14:15:13 -0800 (PST) MIME-Version: 1.0 References: <20210215204909.3824509-1-willy@infradead.org> <20210219195509.GA59987@24bbad8f3778> <20210219205403.GX2858050@casper.infradead.org> In-Reply-To: From: Miguel Ojeda Date: Fri, 19 Feb 2021 23:15:02 +0100 Message-ID: Subject: Re: [PATCH] mm/gfp: Add kernel-doc for gfp_t To: Nick Desaulniers Cc: Matthew Wilcox , Nathan Chancellor , Andrew Morton , Linux Memory Management List , Mike Rapoport , clang-built-linux Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: c3j7nrez7n3y766oogr1sxrpr3nnhqgt X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 9FC8390009E8 Received-SPF: none (gmail.com>: No applicable sender policy available) receiver=imf19; identity=mailfrom; envelope-from=""; helo=mail-yb1-f180.google.com; client-ip=209.85.219.180 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1613772911-281543 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000204, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Feb 19, 2021 at 10:45 PM 'Nick Desaulniers' via Clang Built Linux wrote: > > That said, I'm fine disabling this warning; there's a separate error > for redefining a typedef to a different underlying type. That's > what's useful IMO, this one really is not. > > This warning doesn't really provide any value to us in the kernel; I > would guess the intent was to be helpful to code expected to be > portable across different -std=* It seems it would also be useful to sport unintended cases, e.g.: - Collisions on short identifiers (that by chance typedef to the same type). - Copy-pasting and forgetting to remove the original definition (i.e. it should have be cut-pasting instead). - Double inclusion of headers (with missing or broken #ifdef guards). Those may be providing value in the kernel. In particular, if we don't see any warning at the moment, it means those cases are not happening now anywhere, so we would be weakening things. Having said that, I don't see the original patch, so perhaps I am missing something. Cheers, Miguel