From: Eric Dumazet <edumazet@google.com>
To: Shakeel Butt <shakeelb@google.com>
Cc: Matthew Wilcox <willy@infradead.org>,
Chen Wandun <chenwandun@huawei.com>,
Andrew Morton <akpm@linux-foundation.org>,
Nicholas Piggin <npiggin@gmail.com>,
Linux MM <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
Kefeng Wang <wangkefeng.wang@huawei.com>,
guohanjun@huawei.com,
"Uladzislau Rezki (Sony)" <urezki@gmail.com>
Subject: Re: [PATCH v2 1/2] mm/vmalloc: fix numa spreading for large hash tables
Date: Tue, 19 Oct 2021 08:58:48 -0700 [thread overview]
Message-ID: <CANn89iKN_N=tSiv-xFHYAGAagty9pP_FCH2FtfjUU=NGpRf3dg@mail.gmail.com> (raw)
In-Reply-To: <CALvZod4BEu3sYuo3kZ9OS0SXHm_q7C8w7sYObJo9X_xeMUd8sQ@mail.gmail.com>
On Tue, Oct 19, 2021 at 8:54 AM Shakeel Butt <shakeelb@google.com> wrote:
>
> On Mon, Oct 18, 2021 at 5:41 AM Matthew Wilcox <willy@infradead.org> wrote:
> >
> > On Mon, Oct 18, 2021 at 08:37:09PM +0800, Chen Wandun wrote:
> > > Eric Dumazet reported a strange numa spreading info in [1], and found
> > > commit 121e6f3258fe ("mm/vmalloc: hugepage vmalloc mappings") introduced
> > > this issue [2].
> >
> > I think the root problem here is that we have two meanings for
> > NUMA_NO_NODE. I tend to read it as "The memory can be allocated from
> > any node", but here it's used to mean "The memory should be spread over
> > every node". Should we split those out as -1 and -2?
>
> I agree with Willy's suggestion to make it more explicit but as a
> followup work. This patch needs a backport, so keep this simple.
NUMA_NO_NODE in process context also meant :
Please follow current thread NUMA policies.
One could hope for instance, that whenever large BPF maps are allocated,
current thread could set non default NUMA policies.
next prev parent reply other threads:[~2021-10-19 15:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-18 12:37 [PATCH v2 0/2] fix numa spreading for large hash tables Chen Wandun
2021-10-18 12:37 ` [PATCH v2 1/2] mm/vmalloc: " Chen Wandun
2021-10-18 12:39 ` Matthew Wilcox
2021-10-18 13:01 ` Chen Wandun
2021-10-19 15:53 ` Shakeel Butt
2021-10-19 15:58 ` Eric Dumazet [this message]
2021-10-18 14:03 ` Uladzislau Rezki
2021-10-19 15:56 ` Shakeel Butt
2021-10-18 12:37 ` [PATCH v2 2/2] mm/vmalloc: introduce alloc_pages_bulk_array_mempolicy to accelerate memory allocation Chen Wandun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANn89iKN_N=tSiv-xFHYAGAagty9pP_FCH2FtfjUU=NGpRf3dg@mail.gmail.com' \
--to=edumazet@google.com \
--cc=akpm@linux-foundation.org \
--cc=chenwandun@huawei.com \
--cc=guohanjun@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=npiggin@gmail.com \
--cc=shakeelb@google.com \
--cc=urezki@gmail.com \
--cc=wangkefeng.wang@huawei.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).