From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47E68C388F9 for ; Wed, 11 Nov 2020 15:22:36 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9ADAC20709 for ; Wed, 11 Nov 2020 15:22:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="doby/aOl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9ADAC20709 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E17EA6B0078; Wed, 11 Nov 2020 10:22:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DED866B007D; Wed, 11 Nov 2020 10:22:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D0EBD6B007E; Wed, 11 Nov 2020 10:22:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0043.hostedemail.com [216.40.44.43]) by kanga.kvack.org (Postfix) with ESMTP id A14446B0078 for ; Wed, 11 Nov 2020 10:22:34 -0500 (EST) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 474688249980 for ; Wed, 11 Nov 2020 15:22:34 +0000 (UTC) X-FDA: 77472504228.02.form67_420eefb272fe Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin02.hostedemail.com (Postfix) with ESMTP id 2708B10097AA1 for ; Wed, 11 Nov 2020 15:22:34 +0000 (UTC) X-HE-Tag: form67_420eefb272fe X-Filterd-Recvd-Size: 7208 Received: from mail-ot1-f66.google.com (mail-ot1-f66.google.com [209.85.210.66]) by imf04.hostedemail.com (Postfix) with ESMTP for ; Wed, 11 Nov 2020 15:22:33 +0000 (UTC) Received: by mail-ot1-f66.google.com with SMTP id n89so2472618otn.3 for ; Wed, 11 Nov 2020 07:22:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0qXuq3ha015RB7+Wp6T10l2uYM1lO9pj4+Ev82Ko6MA=; b=doby/aOl1OVARP7VU52k8cICTKkAEh+GZTZEEfoDiz+qQaMdo/cGEjhRE6hojVh2N+ XBb7iT210sawrd871afqUi6C9DtBA9KAOx+XxHmZlmBdySxnS55EBVW9I5By1s+6pL3g KVN7X199uRaXBO+xeIpypMtACIAGFBjwhbP0Po/K+dr8JFEP6xgIKtjZwT7lhIfk0KyF kzFb8rMEbYPW4QG4YqD3Dv4rNyW+0FkMjgdQjcZNwqxUUsWZ2JVeK35WV3J2+K+J6U1U NACvPQYjuyS6rfT5n4TIgFZTfzw4abqKmbD+MV9tWWtbl+DWWiucxVn8mDGuo8u1vqc+ AqDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0qXuq3ha015RB7+Wp6T10l2uYM1lO9pj4+Ev82Ko6MA=; b=nAGDM3sBuHZWxBkkygPWM2ucyKE+VboS5RdSy1mtueRbMFOBoD8iUFWXsjNZR33MSV nOQiyU6wFCCLkyAxWFQ3LrhPkgGMGEjH30J/CDaPnNI4o31i7J0apNylsnosvANTPRe6 sBCc4TStRANWGhYzEG0snm0gy7qWbeBMXJrBkqm4j5nNqNleEkhPW1T7I/1yteIqi5YE 1JMES8QR0tZ7GwshZKMYvm8/if53JsGnu7yf9Q7qkyMgpYtjTVPnBwx4gT3PRSA0OXtz FXvJ3fqDyqTIooLM6rRCBAScnJPeoiW4qMHQaW69LgklQYrO3KmPyCeRRUWVn0i9/u2i /Www== X-Gm-Message-State: AOAM532mxvKPhejyHmO4NNMfJYfrHEez06DXQtfTf7aCH8zQA8soE8aI ymHaqTQOISkg9EBk9wO/6AuBHcR8u7V+8zMHMeXDUg== X-Google-Smtp-Source: ABdhPJyDVj8jY7v5bU35bgEFcJJ3qyH4qWzPgn4DfZKaOxb0cDIcRbbbycTRyijSRolnkLnVo6mit5GCdF2sfqfhgqQ= X-Received: by 2002:a9d:65d5:: with SMTP id z21mr16777802oth.251.1605108152557; Wed, 11 Nov 2020 07:22:32 -0800 (PST) MIME-Version: 1.0 References: <20201110135320.3309507-1-elver@google.com> In-Reply-To: From: Marco Elver Date: Wed, 11 Nov 2020 16:22:20 +0100 Message-ID: Subject: Re: [PATCH] kfence: Avoid stalling work queue task without allocations To: Anders Roxell Cc: Andrew Morton , Alexander Potapenko , Dmitry Vyukov , Jann Horn , Mark Rutland , Linux Kernel Mailing List , Linux-MM , kasan-dev Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 11 Nov 2020 at 16:01, Anders Roxell wrote: > > On Wed, 11 Nov 2020 at 09:29, Marco Elver wrote: > > > > On Wed, 11 Nov 2020 at 00:23, Anders Roxell wrote: > > [...] > > > > > > I gave them a spin on next-20201105 [1] and on next-20201110 [2]. > > > > > > I eventually got to a prompt on next-20201105. > > > However, I got to this kernel panic on the next-20201110: > > > > > > [...] > > > [ 1514.089966][ T1] Testing event system initcall: OK > > > [ 1514.806232][ T1] Running tests on all trace events: > > > [ 1514.857835][ T1] Testing all events: > > > [ 1525.503262][ C0] hrtimer: interrupt took 10902600 ns > > > [ 1623.861452][ C0] BUG: workqueue lockup - pool cpus=0 node=0 > > > flags=0x0 nice=0 stuck for 65s! > > > [...] > > > [ 7823.104349][ T28] Tainted: G W > > > 5.10.0-rc3-next-20201110-00008-g8dc06700529d #3 > > > [ 7833.206491][ T28] "echo 0 > > > > /proc/sys/kernel/hung_task_timeout_secs" disables this message. > > > [ 7840.750700][ T28] task:kworker/0:1 state:D stack:26640 pid: > > > 1872 ppid: 2 flags:0x00000428 > > > [ 7875.642531][ T28] Workqueue: events toggle_allocation_gate > > > [ 7889.178334][ T28] Call trace: > > > [ 7897.066649][ T28] __switch_to+0x1cc/0x1e0 > > > [ 7905.326856][ T28] 0xffff00000f7077b0 > > > [ 7928.354644][ T28] INFO: lockdep is turned off. > > > [ 7934.022572][ T28] Kernel panic - not syncing: hung_task: blocked tasks > > > [ 7934.032039][ T28] CPU: 0 PID: 28 Comm: khungtaskd Tainted: G > > > W 5.10.0-rc3-next-20201110-00008-g8dc06700529d #3 > > > [ 7934.045586][ T28] Hardware name: linux,dummy-virt (DT) > > > [ 7934.053677][ T28] Call trace: > > > [ 7934.060276][ T28] dump_backtrace+0x0/0x420 > > > [ 7934.067635][ T28] show_stack+0x38/0xa0 > > > [ 7934.091277][ T28] dump_stack+0x1d4/0x278 > > > [ 7934.098878][ T28] panic+0x304/0x5d8 > > > [ 7934.114923][ T28] check_hung_uninterruptible_tasks+0x5e4/0x640 > > > [ 7934.123823][ T28] watchdog+0x138/0x160 > > > [ 7934.131561][ T28] kthread+0x23c/0x260 > > > [ 7934.138590][ T28] ret_from_fork+0x10/0x18 > > > [ 7934.146631][ T28] Kernel Offset: disabled > > > [ 7934.153749][ T28] CPU features: 0x0240002,20002004 > > > [ 7934.161476][ T28] Memory Limit: none > > > [ 7934.171272][ T28] ---[ end Kernel panic - not syncing: hung_task: > > > blocked tasks ]--- > > > > > > Cheers, > > > Anders > > > [1] https://people.linaro.org/~anders.roxell/output-next-20201105-test.log > > > [2] https://people.linaro.org/~anders.roxell/output-next-20201110-test.log > > > > Thanks for testing. The fact that it passes on next-20201105 but not > > on 20201110 is strange. If you boot with KFENCE disabled (boot param > > kfence.sample_interval=0), does it boot? > > This is my qemu cmdline with kfence.sample_interval=0 > $ qemu-system-aarch64 --enable-kvm -cpu cortex-a53 -kernel > Image-20201110-test -serial stdio -monitor none -nographic -m 2G -M > virt -fsdev local,id=root,path=/srv/kvm/tmp/stretch/arm64-test,security_model=none,writeout=immediate > -device virtio-rng-pci -device > virtio-9p-pci,fsdev=root,mount_tag=/dev/root -append "root=/dev/root > rootfstype=9p rootflags=trans=virtio console=ttyAMA0,38400n8 > earlycon=pl011,0x9000000 initcall_debug softlockup_panic=0 > security=none kpti=no kfence.sample_interval=0" > > This is the result, I managed to get to the prompt. see > https://people.linaro.org/~anders.roxell/output-next-20201110-test-2.log Hmm, you still have a ton of BUG: workqueue lockup - pool ... and other warnings in that log though that weren't there in next-20201105, so I do not trust the results until those are fixed. To me it looks like KFENCE's timer helps uncover a new problem, but trying to work around this new problem in KFENCE seems wrong for now. We need to understand why these "BUG: workqueue lockup" warnings are there. I Cc'd a bunch of folks in that other email that might be able to help. Thanks, -- Marco