From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BB75C432C0 for ; Mon, 2 Dec 2019 13:25:37 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id DB8FF206E4 for ; Mon, 2 Dec 2019 13:25:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="rNiIYV8K" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DB8FF206E4 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 537526B0003; Mon, 2 Dec 2019 08:25:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4BF966B0006; Mon, 2 Dec 2019 08:25:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 361626B0007; Mon, 2 Dec 2019 08:25:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0225.hostedemail.com [216.40.44.225]) by kanga.kvack.org (Postfix) with ESMTP id 17D956B0003 for ; Mon, 2 Dec 2019 08:25:36 -0500 (EST) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with SMTP id C61164FEC for ; Mon, 2 Dec 2019 13:25:35 +0000 (UTC) X-FDA: 76220273430.15.toy95_13a67148b8601 X-HE-Tag: toy95_13a67148b8601 X-Filterd-Recvd-Size: 15377 Received: from mail-oi1-f194.google.com (mail-oi1-f194.google.com [209.85.167.194]) by imf26.hostedemail.com (Postfix) with ESMTP for ; Mon, 2 Dec 2019 13:25:34 +0000 (UTC) Received: by mail-oi1-f194.google.com with SMTP id 6so7180220oix.7 for ; Mon, 02 Dec 2019 05:25:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=gPyMjuDRmAkX2/lsjsEXUshNE/JlcPVrTklyMs5Q7qo=; b=rNiIYV8KkQYH4ZWSjdC7t9ZQoqy3wBpGLIyKYwM5ci+qlMBsCHdgpjHHfZRxRXrmGd OEKT/BHh6kNs7qWcu3J9dcw9ebC3nn26XGzxkxThC1laBjv2guAKOoBwmZo9Hi2NMV9q 6dxtdASoVjA7xBP3E2UOyOWsmszt7wwPtib/GXvJbnqWShw6Ru3m6vyAMXuJ/XDhc0Ur mxxOHP9N+ETeXxOh7CA8mvt6qv4kpbOK2nYhK4QEqYwCwoG3ij6f4K4OyPgNojFMgWuU wS6tvm+LELbrTtLgQmxKBHtgaYg8/BRNI3Ul/Ob10SAI92YnKBHQySD2bG2Ybf39rci6 nT8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gPyMjuDRmAkX2/lsjsEXUshNE/JlcPVrTklyMs5Q7qo=; b=VsOS/urAeN2y+H3TKEDxpJvBGifjt7S98jK6ZCWrktmnJvePi0NK+4H034rjZs3OBi 2B7jF73bwFtA4CWWtm0qIQH4FizvdCdMjdPXBkMZT0RN+MNNaJ3ikYEWQ8587pyfvIJt adWWttJI+8sYo5ew5y86A5VXAso2Z55g7SF5n+mAut0WNzJFYeiHhMjfq6XKjzD2pZuY XtHcxCrPiITtVW9xa2KZD7x+k40D+AMJPjymTH9PKhdKQhU2Bdcygu/LIBRhj8AoHZ/x ItpxrJFNb10u9E3KwM496Q+M3Gtqc/AKkii1QlqlSX+qDDAcCeqQk8buMyxpOXfGBaIn SOOQ== X-Gm-Message-State: APjAAAXy5PzbX6O44M/hTplleqDvOpFtwc0vcd1rYhvQwz97G/sMiRxS m48vySr0Ctodq+rH9QNhwBTXytPlnNynumm0zXPhsw== X-Google-Smtp-Source: APXvYqyIp7D6mDhWZdhFoCWJ3l0cVkHT56ZGYvVLsEtYprIlXU1QHPxk5kCFPB+UssY6HZ/5aSOrPAXBRH30AtD8AbU= X-Received: by 2002:aca:2112:: with SMTP id 18mr8641178oiz.155.1575293133606; Mon, 02 Dec 2019 05:25:33 -0800 (PST) MIME-Version: 1.0 References: <20191122112621.204798-1-glider@google.com> <20191122112621.204798-17-glider@google.com> In-Reply-To: <20191122112621.204798-17-glider@google.com> From: Marco Elver Date: Mon, 2 Dec 2019 14:25:22 +0100 Message-ID: Subject: Re: [PATCH RFC v3 16/36] crypto: kmsan: disable accelerated configs under KMSAN To: Alexander Potapenko Cc: Herbert Xu , "David S. Miller" , Vegard Nossum , Dmitry Vyukov , Linux Memory Management List , Al Viro , Andreas Dilger , Andrew Morton , Andrey Konovalov , Andrey Ryabinin , Andy Lutomirski , Ard Biesheuvel , Arnd Bergmann , Christoph Hellwig , Christoph Hellwig , "Darrick J. Wong" , Dmitry Torokhov , Eric Biggers , Eric Dumazet , Eric Van Hensbergen , Greg Kroah-Hartman , Harry Wentland , Ilya Leoshkevich , Ingo Molnar , Jason Wang , Jens Axboe , Marek Szyprowski , Mark Rutland , "Martin K. Petersen" , Martin Schwidefsky , Matthew Wilcox , "Michael S. Tsirkin" , Michal Simek , Petr Mladek , Qian Cai , Randy Dunlap , Robin Murphy , Sergey Senozhatsky , Steven Rostedt , Takashi Iwai , "Theodore Ts'o" , Thomas Gleixner , Vasily Gorbik , Wolfram Sang Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Archived-At: List-Archive: List-Post: On Fri, 22 Nov 2019 at 12:27, wrote: > > KMSAN is unable to understand when initialized values come from assembly. > Disable accelerated configs in KMSAN builds to prevent false positive > reports. > > Signed-off-by: Alexander Potapenko > To: Alexander Potapenko > Cc: Herbert Xu > Cc: "David S. Miller" > Cc: Vegard Nossum > Cc: Dmitry Vyukov > Cc: linux-mm@kvack.org > --- > > Change-Id: Iddc71a2a27360e036d719c0940ebf15553cf8de8 > --- > crypto/Kconfig | 52 ++++++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 52 insertions(+) > > diff --git a/crypto/Kconfig b/crypto/Kconfig > index 9e524044d312..502a75f1b597 100644 > --- a/crypto/Kconfig > +++ b/crypto/Kconfig > @@ -309,11 +309,15 @@ config CRYPTO_AEGIS128 > config CRYPTO_AEGIS128_SIMD > bool "Support SIMD acceleration for AEGIS-128" > depends on CRYPTO_AEGIS128 && ((ARM || ARM64) && KERNEL_MODE_NEON) > + # Disable under KMSAN to prevent false positives from assembly. > + depends on !KMSAN Probably fine to put this on one line: depends on !KMSAN # avoid false positives from assembly likewise for all below. > default y > > config CRYPTO_AEGIS128_AESNI_SSE2 > tristate "AEGIS-128 AEAD algorithm (x86_64 AESNI+SSE2 implementation)" > depends on X86 && 64BIT > + # Disable under KMSAN to prevent false positives from assembly. > + depends on !KMSAN > select CRYPTO_AEAD > select CRYPTO_SIMD > help > @@ -571,6 +575,8 @@ config CRYPTO_CRC32C > config CRYPTO_CRC32C_INTEL > tristate "CRC32c INTEL hardware acceleration" > depends on X86 > + # Disable under KMSAN to prevent false positives from assembly. > + depends on !KMSAN > select CRYPTO_HASH > help > In Intel processor with SSE4.2 supported, the processor will > @@ -611,6 +617,8 @@ config CRYPTO_CRC32 > config CRYPTO_CRC32_PCLMUL > tristate "CRC32 PCLMULQDQ hardware acceleration" > depends on X86 > + # Disable under KMSAN to prevent false positives from assembly. > + depends on !KMSAN > select CRYPTO_HASH > select CRC32 > help > @@ -649,6 +657,8 @@ config CRYPTO_CRCT10DIF > config CRYPTO_CRCT10DIF_PCLMUL > tristate "CRCT10DIF PCLMULQDQ hardware acceleration" > depends on X86 && 64BIT && CRC_T10DIF > + # Disable under KMSAN to prevent false positives from assembly. > + depends on !KMSAN > select CRYPTO_HASH > help > For x86_64 processors with SSE4.2 and PCLMULQDQ supported, > @@ -695,6 +705,8 @@ config CRYPTO_POLY1305 > config CRYPTO_POLY1305_X86_64 > tristate "Poly1305 authenticator algorithm (x86_64/SSE2/AVX2)" > depends on X86 && 64BIT > + # Disable under KMSAN to prevent false positives from assembly. > + depends on !KMSAN > select CRYPTO_POLY1305 > help > Poly1305 authenticator algorithm, RFC7539. > @@ -814,6 +826,8 @@ config CRYPTO_SHA1 > config CRYPTO_SHA1_SSSE3 > tristate "SHA1 digest algorithm (SSSE3/AVX/AVX2/SHA-NI)" > depends on X86 && 64BIT > + # Disable under KMSAN to prevent false positives from assembly. > + depends on !KMSAN > select CRYPTO_SHA1 > select CRYPTO_HASH > help > @@ -825,6 +839,8 @@ config CRYPTO_SHA1_SSSE3 > config CRYPTO_SHA256_SSSE3 > tristate "SHA256 digest algorithm (SSSE3/AVX/AVX2/SHA-NI)" > depends on X86 && 64BIT > + # Disable under KMSAN to prevent false positives from assembly. > + depends on !KMSAN > select CRYPTO_SHA256 > select CRYPTO_HASH > help > @@ -837,6 +853,8 @@ config CRYPTO_SHA256_SSSE3 > config CRYPTO_SHA512_SSSE3 > tristate "SHA512 digest algorithm (SSSE3/AVX/AVX2)" > depends on X86 && 64BIT > + # Disable under KMSAN to prevent false positives from assembly. > + depends on !KMSAN > select CRYPTO_SHA512 > select CRYPTO_HASH > help > @@ -1011,6 +1029,8 @@ config CRYPTO_WP512 > config CRYPTO_GHASH_CLMUL_NI_INTEL > tristate "GHASH hash function (CLMUL-NI accelerated)" > depends on X86 && 64BIT > + # Disable under KMSAN to prevent false positives from assembly. > + depends on !KMSAN > select CRYPTO_CRYPTD > help > This is the x86_64 CLMUL-NI accelerated implementation of > @@ -1064,6 +1084,8 @@ config CRYPTO_AES_TI > config CRYPTO_AES_NI_INTEL > tristate "AES cipher algorithms (AES-NI)" > depends on X86 > + # Disable under KMSAN to prevent false positives from assembly. > + depends on !KMSAN > select CRYPTO_AEAD > select CRYPTO_LIB_AES > select CRYPTO_ALGAPI > @@ -1190,6 +1212,8 @@ config CRYPTO_BLOWFISH_COMMON > config CRYPTO_BLOWFISH_X86_64 > tristate "Blowfish cipher algorithm (x86_64)" > depends on X86 && 64BIT > + # Disable under KMSAN to prevent false positives from assembly. > + depends on !KMSAN > select CRYPTO_BLKCIPHER > select CRYPTO_BLOWFISH_COMMON > help > @@ -1221,6 +1245,8 @@ config CRYPTO_CAMELLIA_X86_64 > tristate "Camellia cipher algorithm (x86_64)" > depends on X86 && 64BIT > depends on CRYPTO > + # Disable under KMSAN to prevent false positives from assembly. > + depends on !KMSAN > select CRYPTO_BLKCIPHER > select CRYPTO_GLUE_HELPER_X86 > help > @@ -1238,6 +1264,8 @@ config CRYPTO_CAMELLIA_AESNI_AVX_X86_64 > tristate "Camellia cipher algorithm (x86_64/AES-NI/AVX)" > depends on X86 && 64BIT > depends on CRYPTO > + # Disable under KMSAN to prevent false positives from assembly. > + depends on !KMSAN > select CRYPTO_BLKCIPHER > select CRYPTO_CAMELLIA_X86_64 > select CRYPTO_GLUE_HELPER_X86 > @@ -1258,6 +1286,8 @@ config CRYPTO_CAMELLIA_AESNI_AVX2_X86_64 > tristate "Camellia cipher algorithm (x86_64/AES-NI/AVX2)" > depends on X86 && 64BIT > depends on CRYPTO > + # Disable under KMSAN to prevent false positives from assembly. > + depends on !KMSAN > select CRYPTO_CAMELLIA_AESNI_AVX_X86_64 > help > Camellia cipher algorithm module (x86_64/AES-NI/AVX2). > @@ -1303,6 +1333,8 @@ config CRYPTO_CAST5 > config CRYPTO_CAST5_AVX_X86_64 > tristate "CAST5 (CAST-128) cipher algorithm (x86_64/AVX)" > depends on X86 && 64BIT > + # Disable under KMSAN to prevent false positives from assembly. > + depends on !KMSAN > select CRYPTO_BLKCIPHER > select CRYPTO_CAST5 > select CRYPTO_CAST_COMMON > @@ -1325,6 +1357,8 @@ config CRYPTO_CAST6 > config CRYPTO_CAST6_AVX_X86_64 > tristate "CAST6 (CAST-256) cipher algorithm (x86_64/AVX)" > depends on X86 && 64BIT > + # Disable under KMSAN to prevent false positives from assembly. > + depends on !KMSAN > select CRYPTO_BLKCIPHER > select CRYPTO_CAST6 > select CRYPTO_CAST_COMMON > @@ -1360,6 +1394,8 @@ config CRYPTO_DES_SPARC64 > config CRYPTO_DES3_EDE_X86_64 > tristate "Triple DES EDE cipher algorithm (x86-64)" > depends on X86 && 64BIT > + # Disable under KMSAN to prevent false positives from assembly. > + depends on !KMSAN > select CRYPTO_BLKCIPHER > select CRYPTO_LIB_DES > help > @@ -1426,6 +1462,8 @@ config CRYPTO_CHACHA20 > config CRYPTO_CHACHA20_X86_64 > tristate "ChaCha stream cipher algorithms (x86_64/SSSE3/AVX2/AVX-512VL)" > depends on X86 && 64BIT > + # Disable under KMSAN to prevent false positives from assembly. > + depends on !KMSAN > select CRYPTO_BLKCIPHER > select CRYPTO_CHACHA20 > help > @@ -1462,6 +1500,8 @@ config CRYPTO_SERPENT > config CRYPTO_SERPENT_SSE2_X86_64 > tristate "Serpent cipher algorithm (x86_64/SSE2)" > depends on X86 && 64BIT > + # Disable under KMSAN to prevent false positives from assembly. > + depends on !KMSAN > select CRYPTO_BLKCIPHER > select CRYPTO_GLUE_HELPER_X86 > select CRYPTO_SERPENT > @@ -1481,6 +1521,8 @@ config CRYPTO_SERPENT_SSE2_X86_64 > config CRYPTO_SERPENT_SSE2_586 > tristate "Serpent cipher algorithm (i586/SSE2)" > depends on X86 && !64BIT > + # Disable under KMSAN to prevent false positives from assembly. > + depends on !KMSAN > select CRYPTO_BLKCIPHER > select CRYPTO_GLUE_HELPER_X86 > select CRYPTO_SERPENT > @@ -1500,6 +1542,8 @@ config CRYPTO_SERPENT_SSE2_586 > config CRYPTO_SERPENT_AVX_X86_64 > tristate "Serpent cipher algorithm (x86_64/AVX)" > depends on X86 && 64BIT > + # Disable under KMSAN to prevent false positives from assembly. > + depends on !KMSAN > select CRYPTO_BLKCIPHER > select CRYPTO_GLUE_HELPER_X86 > select CRYPTO_SERPENT > @@ -1520,6 +1564,8 @@ config CRYPTO_SERPENT_AVX_X86_64 > config CRYPTO_SERPENT_AVX2_X86_64 > tristate "Serpent cipher algorithm (x86_64/AVX2)" > depends on X86 && 64BIT > + # Disable under KMSAN to prevent false positives from assembly. > + depends on !KMSAN > select CRYPTO_SERPENT_AVX_X86_64 > help > Serpent cipher algorithm, by Anderson, Biham & Knudsen. > @@ -1615,6 +1661,8 @@ config CRYPTO_TWOFISH_586 > config CRYPTO_TWOFISH_X86_64 > tristate "Twofish cipher algorithm (x86_64)" > depends on (X86 || UML_X86) && 64BIT > + # Disable under KMSAN to prevent false positives from assembly. > + depends on !KMSAN > select CRYPTO_ALGAPI > select CRYPTO_TWOFISH_COMMON > help > @@ -1631,6 +1679,8 @@ config CRYPTO_TWOFISH_X86_64 > config CRYPTO_TWOFISH_X86_64_3WAY > tristate "Twofish cipher algorithm (x86_64, 3-way parallel)" > depends on X86 && 64BIT > + # Disable under KMSAN to prevent false positives from assembly. > + depends on !KMSAN > select CRYPTO_BLKCIPHER > select CRYPTO_TWOFISH_COMMON > select CRYPTO_TWOFISH_X86_64 > @@ -1652,6 +1702,8 @@ config CRYPTO_TWOFISH_X86_64_3WAY > config CRYPTO_TWOFISH_AVX_X86_64 > tristate "Twofish cipher algorithm (x86_64/AVX)" > depends on X86 && 64BIT > + # Disable under KMSAN to prevent false positives from assembly. > + depends on !KMSAN > select CRYPTO_BLKCIPHER > select CRYPTO_GLUE_HELPER_X86 > select CRYPTO_SIMD > -- > 2.24.0.432.g9d3f5f5b63-goog >