From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61945C432C0 for ; Mon, 2 Dec 2019 14:32:17 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id EE22E2146E for ; Mon, 2 Dec 2019 14:32:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Xs3ZpkMT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EE22E2146E Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 552676B0003; Mon, 2 Dec 2019 09:32:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5297B6B0006; Mon, 2 Dec 2019 09:32:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 440966B0007; Mon, 2 Dec 2019 09:32:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0199.hostedemail.com [216.40.44.199]) by kanga.kvack.org (Postfix) with ESMTP id 2FC2B6B0003 for ; Mon, 2 Dec 2019 09:32:16 -0500 (EST) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with SMTP id B8D92249B for ; Mon, 2 Dec 2019 14:32:15 +0000 (UTC) X-FDA: 76220441430.13.7718BC8 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin13.hostedemail.com (Postfix) with ESMTP id D0DE81814062D for ; Mon, 2 Dec 2019 14:32:06 +0000 (UTC) X-HE-Tag: men40_125546c6b7856 X-Filterd-Recvd-Size: 6320 Received: from mail-oi1-f193.google.com (mail-oi1-f193.google.com [209.85.167.193]) by imf12.hostedemail.com (Postfix) with ESMTP for ; Mon, 2 Dec 2019 14:32:05 +0000 (UTC) Received: by mail-oi1-f193.google.com with SMTP id c16so10455104oic.3 for ; Mon, 02 Dec 2019 06:32:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=viHTCnFGPO4VV5gh9ZbHvhbgNW4fM+NRH/qCOl0rppA=; b=Xs3ZpkMT5ysj6nfWXsWBVjuSPtpmtinon52hEdNf/70fwZeZM7dCATyKIIIhDBbbpc BytCs2rzcFWa58ImZJBCojOKTghi+nzqEYtpERaLsw4GiGfc0n2zyii9/W4Abzw5gQgw LUiguL5vcP4J/6qn3c5pjRkhYEWeVIbB+0bPUts+2GJjOM4A+zomBUwup2ZHglYIHW1z QIaEMpTrnJxePN6RVO4XmiYqBnYVz2EHiDd/s64PQEML9FNGWgmTaj7QBfdIvCBdwCHa d7kwdQZ9MCW2EGR7oajtHp2hXbDYqiCJhIsUuA7yYkHoPQsgYsTGFOlRAehGmgiuSw9Y tSNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=viHTCnFGPO4VV5gh9ZbHvhbgNW4fM+NRH/qCOl0rppA=; b=gYjhSzu4XYPbmt3+MSPskxvV6fYfH4zL4dqkLboDOEBjEnMIRjuHa00ZuNXW0BcpJL WmnnFmJiqJ27rNvSrOXYsch8VZeeDeLNLgoOUEG9MRBj4+Eu5pToCbwJ/YHCgKN6AuZt iQjFwnSgTgXSE7fMdyUTgzALujJW7PmURu6xDGBaNS1Ipu3FpasX7Pz8TQWSfwUtkIan CjVX4Z0bAgBZtMXD3IjHMZUCa/qYoyFlh5CTrkJNieUBcskxXkn+y54TgUkhV46dwqSV rJYZict1pTP1ST05u6AA9aq8tL2hNIGNJm4ocvX/Q6WyWEoRiScW2J4+7a65Pwt950vq IxUQ== X-Gm-Message-State: APjAAAUSolKrRGyTXv/DIe0B7lnycbhHPDLjn+wLTtpQDtr4nL+YOMa1 45PHIUdF6RvbRaSic92jwoq0kkyjwD5Ownr6qf3JhQ== X-Google-Smtp-Source: APXvYqxFuHQNpHC0ULxRFpexlpkT3/KGgqU4oPBy2y07+weVYRQZasxls0c/A3+HRw9m2rhJ1mX5fSxl442k25UWSnw= X-Received: by 2002:aca:d4c1:: with SMTP id l184mr24260001oig.172.1575297124379; Mon, 02 Dec 2019 06:32:04 -0800 (PST) MIME-Version: 1.0 References: <20191122112621.204798-1-glider@google.com> <20191122112621.204798-21-glider@google.com> In-Reply-To: <20191122112621.204798-21-glider@google.com> From: Marco Elver Date: Mon, 2 Dec 2019 15:31:52 +0100 Message-ID: Subject: Re: [PATCH RFC v3 20/36] kmsan: x86: increase stack sizes in KMSAN builds To: Alexander Potapenko Cc: Jens Axboe , Andy Lutomirski , Vegard Nossum , Dmitry Vyukov , Christoph Hellwig , Linux Memory Management List , Al Viro , Andreas Dilger , Andrew Morton , Andrey Konovalov , Andrey Ryabinin , Ard Biesheuvel , Arnd Bergmann , Christoph Hellwig , "Darrick J. Wong" , "David S. Miller" , Dmitry Torokhov , Eric Biggers , Eric Dumazet , Eric Van Hensbergen , Greg Kroah-Hartman , Harry Wentland , Herbert Xu , Ilya Leoshkevich , Ingo Molnar , Jason Wang , Marek Szyprowski , Mark Rutland , "Martin K. Petersen" , Martin Schwidefsky , Matthew Wilcox , "Michael S. Tsirkin" , Michal Simek , Petr Mladek , Qian Cai , Randy Dunlap , Robin Murphy , Sergey Senozhatsky , Steven Rostedt , Takashi Iwai , "Theodore Ts'o" , Thomas Gleixner , Vasily Gorbik , Wolfram Sang Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 22 Nov 2019 at 12:27, wrote: > > KMSAN instruments the code heavily, increasing register pressure and > preventing functions from being inlined. As a result, the kernel > requires more stack space to run. > > Rename KASAN_STACK_ORDER to EXTRA_STACK_ORDER and set EXTRA_STACK_ORDER > to 2 for KMSAN builds, effectively making the stacks 4 times larger. > > Signed-off-by: Alexander Potapenko > Cc: Jens Axboe > Cc: Andy Lutomirski > Cc: Vegard Nossum > Cc: Dmitry Vyukov > Cc: Christoph Hellwig > Cc: linux-mm@kvack.org Acked-by: Marco Elver Thanks, -- Marco > --- > > Change-Id: I1d9df161419a885bf654abff141e247366895b68 > --- > arch/x86/include/asm/page_64_types.h | 12 +++++++----- > 1 file changed, 7 insertions(+), 5 deletions(-) > > diff --git a/arch/x86/include/asm/page_64_types.h b/arch/x86/include/asm/page_64_types.h > index 288b065955b7..ea9fbf09f43b 100644 > --- a/arch/x86/include/asm/page_64_types.h > +++ b/arch/x86/include/asm/page_64_types.h > @@ -7,18 +7,20 @@ > #endif > > #ifdef CONFIG_KASAN > -#define KASAN_STACK_ORDER 1 > +#define EXTRA_STACK_ORDER 1 > +#elif defined(CONFIG_KMSAN) > +#define EXTRA_STACK_ORDER 2 > #else > -#define KASAN_STACK_ORDER 0 > +#define EXTRA_STACK_ORDER 0 > #endif > > -#define THREAD_SIZE_ORDER (2 + KASAN_STACK_ORDER) > +#define THREAD_SIZE_ORDER (2 + EXTRA_STACK_ORDER) > #define THREAD_SIZE (PAGE_SIZE << THREAD_SIZE_ORDER) > > -#define EXCEPTION_STACK_ORDER (0 + KASAN_STACK_ORDER) > +#define EXCEPTION_STACK_ORDER (0 + EXTRA_STACK_ORDER) > #define EXCEPTION_STKSZ (PAGE_SIZE << EXCEPTION_STACK_ORDER) > > -#define IRQ_STACK_ORDER (2 + KASAN_STACK_ORDER) > +#define IRQ_STACK_ORDER (2 + EXTRA_STACK_ORDER) > #define IRQ_STACK_SIZE (PAGE_SIZE << IRQ_STACK_ORDER) > > /* > -- > 2.24.0.432.g9d3f5f5b63-goog >