From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.2 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A128DC4338F for ; Tue, 27 Jul 2021 07:21:15 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 49DE66069E for ; Tue, 27 Jul 2021 07:21:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 49DE66069E Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id B0B206B0036; Tue, 27 Jul 2021 03:21:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ABA0F6B005D; Tue, 27 Jul 2021 03:21:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9A88F8D0001; Tue, 27 Jul 2021 03:21:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0124.hostedemail.com [216.40.44.124]) by kanga.kvack.org (Postfix) with ESMTP id 7FB886B0036 for ; Tue, 27 Jul 2021 03:21:14 -0400 (EDT) Received: from smtpin38.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 9BEED18213803 for ; Tue, 27 Jul 2021 07:21:12 +0000 (UTC) X-FDA: 78407521584.38.CED4759 Received: from mail-ot1-f53.google.com (mail-ot1-f53.google.com [209.85.210.53]) by imf04.hostedemail.com (Postfix) with ESMTP id 4B3BD50056C1 for ; Tue, 27 Jul 2021 07:21:12 +0000 (UTC) Received: by mail-ot1-f53.google.com with SMTP id o2-20020a9d22020000b0290462f0ab0800so7889385ota.11 for ; Tue, 27 Jul 2021 00:21:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=yQhhZe+MXmpfkLnh85/Z8tkXEKIvw/AuYXzOfTRKZJE=; b=PZr5f2UnPFBMoWR1tobduCnk9rwIYH0AijHubObKP5CcIUo3ugfnpdz8aVEMsOP23K Y2TcJTFda7LwyNcdNmPEuuatoLOHYMFBp2l57/E+W7SnNQbsFDxhBY3xolhgqQLVpLK2 tqh88JtVCKyHcU5COG4k7DTjKfZtpF9i63jgeht4qDJBACzdSN/jgRETxx6JWIM7jYFx TtYLW0uQjewgHIp4TmrFS2DH68l5DIfeQgkF1k8OZxujnje6oJG7+iADiYrt86fgOJg5 Zl//iEWZqJJyRiz77b2rLlQy6pgL1QWy6/xXQK8wSCDPDlwC/RcSjV/FHf5haFD243yl lgcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yQhhZe+MXmpfkLnh85/Z8tkXEKIvw/AuYXzOfTRKZJE=; b=QIOLHQ8Kdgcn2qpItwgpUx9Uy0h3jOgh+S9dj7oLh6XXN714lcPyi6ipHYboK2NIY8 O37q7/zY4k4zWJ+FEbzmrICHPvIpb0sPBMpMrxG0GPjzAxiDTZLZnRN6bVWV76CsUGhJ pnupdtyF5BsS/9/EUOIGEm6zvDEyMHyMNCXWnQ86vlYUZVyfX5l/zvXPXk1DUV0Cg1UN qwbXNIIxrxywfaBZcyhovxMlc3tBlBzSrpZ3paBiC2usV2Tqlm6iUqXqg42C4uvEhG4i jDmKTC1ORTZUOkOY+4R9L1HZ6miFwhHQUiF1+QRpNBGG6sBAi34BMhf3Mb7ZBx/jHW5C OO4A== X-Gm-Message-State: AOAM5300galKF19Zc5WNfFaaNG31RCiAZLwS1Oi1FKFmUscLNT0hEvrE HVVvdlle5lDa8B5tZ2pIIVDAmCQPxgxcuuvsyekPlw== X-Google-Smtp-Source: ABdhPJz4sT4HTIASRu0q2t8NdjaqXI6ESVvlLRb0xkzVD7J1pd9jPoZvaxTYZ/B5e777xfunN9Qvkpz/1DYXmfkKJTY= X-Received: by 2002:a05:6830:23a7:: with SMTP id m7mr14536006ots.17.1627370471381; Tue, 27 Jul 2021 00:21:11 -0700 (PDT) MIME-Version: 1.0 References: <20210727040021.21371-1-Kuan-Ying.Lee@mediatek.com> <20210727040021.21371-3-Kuan-Ying.Lee@mediatek.com> In-Reply-To: <20210727040021.21371-3-Kuan-Ying.Lee@mediatek.com> From: Marco Elver Date: Tue, 27 Jul 2021 09:20:59 +0200 Message-ID: Subject: Re: [PATCH 2/2] kasan, mm: reset tag for hex dump address To: Kuan-Ying Lee Cc: Nicholas Tang , Andrew Yang , Andrey Konovalov , Andrey Ryabinin , Alexander Potapenko , Chinwen Chang , Andrew Morton , kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=google.com header.s=20161025 header.b=PZr5f2Un; spf=pass (imf04.hostedemail.com: domain of elver@google.com designates 209.85.210.53 as permitted sender) smtp.mailfrom=elver@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 4B3BD50056C1 X-Stat-Signature: ncbgrmoau4enrtt676uo7wddgac3xc57 X-HE-Tag: 1627370472-557900 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 27 Jul 2021 at 06:00, Kuan-Ying Lee wrote: > > Text is a string. We need to move this kasan_reset_tag() > to address but text. > > Signed-off-by: Kuan-Ying Lee This patch also makes sense (I think), thanks for sending. But it's unclear what the problem is. The fact that when the address is printed it still includes the tag? Or a false positive? It'd be good to clarify in the commit message. Here I'd also use a more descriptive patch title, something like "kasan, slub: reset tag when printing address". Also, I think this patch requires a: Fixes: aa1ef4d7b3f6 ("kasan, mm: reset tags when accessing metadata") So that stable kernels can pick this up if appropriate. > --- > mm/slub.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/slub.c b/mm/slub.c > index 6dad2b6fda6f..d20674f839ba 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -576,8 +576,8 @@ static void print_section(char *level, char *text, u8 *addr, > unsigned int length) > { > metadata_access_enable(); > - print_hex_dump(level, kasan_reset_tag(text), DUMP_PREFIX_ADDRESS, > - 16, 1, addr, length, 1); > + print_hex_dump(level, text, DUMP_PREFIX_ADDRESS, > + 16, 1, kasan_reset_tag((void *)addr), length, 1); > metadata_access_disable(); > } > > -- > 2.18.0 > > -- > You received this message because you are subscribed to the Google Groups "kasan-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an email to kasan-dev+unsubscribe@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/kasan-dev/20210727040021.21371-3-Kuan-Ying.Lee%40mediatek.com.