From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAB27C3F2D2 for ; Fri, 28 Feb 2020 12:43:47 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8C5A2246A3 for ; Fri, 28 Feb 2020 12:43:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="qsOTrP3s" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8C5A2246A3 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C81EF6B0005; Fri, 28 Feb 2020 07:43:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C32D76B0006; Fri, 28 Feb 2020 07:43:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B49B76B0007; Fri, 28 Feb 2020 07:43:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0156.hostedemail.com [216.40.44.156]) by kanga.kvack.org (Postfix) with ESMTP id 9B2A06B0005 for ; Fri, 28 Feb 2020 07:43:46 -0500 (EST) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 555C45832 for ; Fri, 28 Feb 2020 12:43:46 +0000 (UTC) X-FDA: 76539502452.24.loss76_78352f773db11 X-HE-Tag: loss76_78352f773db11 X-Filterd-Recvd-Size: 3905 Received: from mail-ot1-f68.google.com (mail-ot1-f68.google.com [209.85.210.68]) by imf12.hostedemail.com (Postfix) with ESMTP for ; Fri, 28 Feb 2020 12:43:45 +0000 (UTC) Received: by mail-ot1-f68.google.com with SMTP id z9so2429707oth.5 for ; Fri, 28 Feb 2020 04:43:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zfQoq+1M8fvl87X+Ubkvp6zzrnswmjJsf0b9A+26ex8=; b=qsOTrP3sERclKpVIMKpYziz0m6/2T73Ci4O0VLjMWrAmFabsOH6/Hfhgq7d+4uG0sD PS9cTXQpCWjogewIdRsDWdUDpgkxbnjhBnul7Ez8GZiFu4Cz7V76bbputXQlyW0NfsfI f3ca5VfPhYL1yMuPomfYonVoEzBphe4ULCpd9vTD7v5nZLyueoV0KGi9frmrgyjbq8v0 VA+tCCN8MLl09kBIUkmrOrOKLU76xbQkeu0i8CpvbVP+3nmMooQrGdSeKzLkt+UB/iOp v35Xl/dUCU9xg/ZWEdZ0BhzOoGxdu4tHxLI0s/eA5vZ80xkU7ZwOXShTYdq6Cumtprc6 Wlsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zfQoq+1M8fvl87X+Ubkvp6zzrnswmjJsf0b9A+26ex8=; b=uEQgA4mI4ufyGQwVuek/GUpyfdZDfRVLKK64j+Lmfm69XsG+8091xDIWpvLqduCOio CyFPrA4quIUOxqqVsC94l61EJ3/TAotAlZmdBHMsdXOXbziovjtp72hj9YYSfU3XjDht BlGJa7ZhlDqAkCJujamKc8wFgeiwZMJ/YetAF0aWDJJkFcB5FoJhVQ6WblwgpGC/8ZnE /fIrpyXuEewQJOdZ2kTFpCffNsSmyi2uenltfUgYKS9DXe4HMrI0eiseuLc+C+BqVCz9 VXi5SxROUOvBHD4p+uIpvWN3+p5LsQZLvAcgD2+xxD0dUyFUvJJtPgHhSQdFCaDMyWya IVsw== X-Gm-Message-State: APjAAAVHTVP5Hxy2ZdV+qbf1zysokh8Y9KuJeEJIaba8uC6YXDEN4NKE Z/vXbqSM8YkG77++sXqqhDLJxOlKIWO8tVjf6s0YSA== X-Google-Smtp-Source: APXvYqxxN3G70uge1DlTVFUodeYfpc6d6jye62KaY4IKt5nfV1OnJVrwRPjdEzVHOp/bCxRdS+oLGB8gXuhKBgImMWo= X-Received: by 2002:a9d:4e8a:: with SMTP id v10mr3370715otk.17.1582893823992; Fri, 28 Feb 2020 04:43:43 -0800 (PST) MIME-Version: 1.0 References: <463BBB2A-8F9A-4CF1-80AE-677ACD21A3C6@lca.pw> In-Reply-To: <463BBB2A-8F9A-4CF1-80AE-677ACD21A3C6@lca.pw> From: Marco Elver Date: Fri, 28 Feb 2020 13:43:32 +0100 Message-ID: Subject: Re: [PATCH] mm/swap: annotate data races for lru_rotate_pvecs To: Qian Cai Cc: Andrew Morton , Linux Memory Management List , LKML , kasan-dev Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000308, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 28 Feb 2020 at 12:30, Qian Cai wrote: > > > > > On Feb 28, 2020, at 5:49 AM, Marco Elver wrote: > > > > Note that, the fact that the writer has local interrupts disabled for > > the write is irrelevant because it's the interrupt that triggered > > while the read was happening that led to the concurrent write. > > I was just to explain that concurrent writers are rather unlikely as people may ask. > > > > > I assume you ran this with CONFIG_KCSAN_INTERRUPT_WATCHER=y? The > > option is disabled by default (see its help-text). I don't know if we > > want to deal with data races due to interrupts right now, especially > > those that just result in 'data_race' annotations. Thoughts? > > Yes, I somehow got quite a bit clean runs lately thanks to the fix/annotations efforts for the last a few weeks (still struggling with the flags things a bit), so I am naturally expanding the testing coverage here. > > Right now the bottleneck is rather some subsystem maintainers are not so keen to deal with data races (looking forward to seeing more education opportunities for all), but the MM subsystem is not one of them. Sounds reasonable. FWIW Acked-by: Marco Elver