From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3164C43457 for ; Thu, 15 Oct 2020 10:23:27 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 410A222273 for ; Thu, 15 Oct 2020 10:23:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="ix5+GbXn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 410A222273 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 4C4E0940014; Thu, 15 Oct 2020 06:23:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4745394000C; Thu, 15 Oct 2020 06:23:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3155D940014; Thu, 15 Oct 2020 06:23:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 0683E94000C for ; Thu, 15 Oct 2020 06:23:25 -0400 (EDT) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 94E40180AD811 for ; Thu, 15 Oct 2020 10:23:25 +0000 (UTC) X-FDA: 77373772770.19.waves95_4b1440a27213 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin19.hostedemail.com (Postfix) with ESMTP id 774DD1AD1A3 for ; Thu, 15 Oct 2020 10:23:25 +0000 (UTC) X-HE-Tag: waves95_4b1440a27213 X-Filterd-Recvd-Size: 5311 Received: from mail-ot1-f65.google.com (mail-ot1-f65.google.com [209.85.210.65]) by imf13.hostedemail.com (Postfix) with ESMTP for ; Thu, 15 Oct 2020 10:23:24 +0000 (UTC) Received: by mail-ot1-f65.google.com with SMTP id l4so2423891ota.7 for ; Thu, 15 Oct 2020 03:23:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=E3eDemKpeFc1gJYyDDp5vYr/DT8MF8qWffPtgx/Rzdw=; b=ix5+GbXnCWRlROMmgufHq2oE+1cdrFFLX7lx+SfMs/2CGfUvR5/wmuIA1Bu3IcGmDO vV7WX7kYim/lnvHFa5lf9TXLL1MdHCjAmpmBLjfAp7+YNcLG9orO6ueizt/rtVl9xfbC ONY8RIoHdi2tEDzXnMY+9Qrjm9zrMRytABFb/XwqUEeNKpK8jVvdl4THZ/m/IJ+XHzHw Xauz93MOXn2BmKKkWMicJx9hyWiJRUw1QvIpblpkU05644WY+5iDLukMsPAJB02sA9RG cNa6M0pgBfUKYVbkGlzSKxsf9AajcFccVsXzAEBnfM/uGxp+GzxmKI/ErwywKUJfnz/T OfMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=E3eDemKpeFc1gJYyDDp5vYr/DT8MF8qWffPtgx/Rzdw=; b=FoiBgYinz8mU8Vo9ePNedjBVAftbLy8auKb0i6dIx2mUapOUZKilul4cbC+7YwufwL iTXvgFym44Hzor58l0YM9KQ1VoI5ljw0WBppZWoHgarLSNXNsaXdssmCptj3BMkue1G/ 2bUNk7i07xwrjS0HLyfqTr4VKfDt9brkv0kak5cM72hDtDohWutgI4EM/pLzXdke5J17 3AYC486UFGs/SfDRUGqCj5lUZmzSP4gblVs1ajlOHc+s3FXQJf5QvET/hGDS+/j3eECX OOXjtEFu3p6STkpGUVHUCcObbZZC8A62/LxDlOy2db6SqCUwEO+Rrv4QUAzwQFJyZJQk th3w== X-Gm-Message-State: AOAM531f1XUYjRzq/26D1VCYCbn34ISqDKH6X3M8YBYGD3hO9FILkP8B 2jY+FsPBbzepJvv0ZBHWEIldcTislYSR7TPa/0vgqA== X-Google-Smtp-Source: ABdhPJyfR4Ru70eeRKUorgZxSTNOp3yEJDLk6FVxy/rJsoxtubfJHHEqXkcTpqtatgnONECphGKXSGSxV2OemlKYDXk= X-Received: by 2002:a9d:649:: with SMTP id 67mr2228403otn.233.1602757404080; Thu, 15 Oct 2020 03:23:24 -0700 (PDT) MIME-Version: 1.0 References: <8fe7b641027ea3151bc84e0d7c81d2d8104d50d7.1602708025.git.andreyknvl@google.com> In-Reply-To: <8fe7b641027ea3151bc84e0d7c81d2d8104d50d7.1602708025.git.andreyknvl@google.com> From: Marco Elver Date: Thu, 15 Oct 2020 12:23:12 +0200 Message-ID: Subject: Re: [PATCH RFC 5/8] kasan: mark kasan_init_tags as __init To: Andrey Konovalov Cc: Catalin Marinas , Will Deacon , Vincenzo Frascino , Dmitry Vyukov , Alexander Potapenko , Evgenii Stepanov , Andrey Ryabinin , Elena Petrova , Branislav Rankov , Kevin Brodsky , Andrew Morton , kasan-dev , Linux ARM , Linux Memory Management List , LKML Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 14 Oct 2020 at 22:44, Andrey Konovalov wrote: > > Similarly to kasan_init() mark kasan_init_tags() as __init. > > Signed-off-by: Andrey Konovalov > Link: https://linux-review.googlesource.com/id/I8792e22f1ca5a703c5e979969147968a99312558 > --- > include/linux/kasan.h | 4 ++-- > mm/kasan/hw_tags.c | 2 +- > mm/kasan/sw_tags.c | 2 +- > 3 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/include/linux/kasan.h b/include/linux/kasan.h > index 7be9fb9146ac..af8317b416a8 100644 > --- a/include/linux/kasan.h > +++ b/include/linux/kasan.h > @@ -185,7 +185,7 @@ static inline void kasan_record_aux_stack(void *ptr) {} > > #if defined(CONFIG_KASAN_SW_TAGS) || defined(CONFIG_KASAN_HW_TAGS) > > -void kasan_init_tags(void); > +void __init kasan_init_tags(void); > > void *kasan_reset_tag(const void *addr); > > @@ -194,7 +194,7 @@ bool kasan_report(unsigned long addr, size_t size, > > #else /* CONFIG_KASAN_SW_TAGS || CONFIG_KASAN_HW_TAGS */ > > -static inline void kasan_init_tags(void) { } > +static inline void __init kasan_init_tags(void) { } Should we mark empty static inline functions __init? __init comes with a bunch of other attributes, but hopefully they don't interfere with inlining? > static inline void *kasan_reset_tag(const void *addr) > { > diff --git a/mm/kasan/hw_tags.c b/mm/kasan/hw_tags.c > index 2a38885014e3..0128062320d5 100644 > --- a/mm/kasan/hw_tags.c > +++ b/mm/kasan/hw_tags.c > @@ -15,7 +15,7 @@ > > #include "kasan.h" > > -void kasan_init_tags(void) > +void __init kasan_init_tags(void) > { > init_tags(KASAN_TAG_MAX); > } > diff --git a/mm/kasan/sw_tags.c b/mm/kasan/sw_tags.c > index c10863a45775..bf1422282bb5 100644 > --- a/mm/kasan/sw_tags.c > +++ b/mm/kasan/sw_tags.c > @@ -35,7 +35,7 @@ > > static DEFINE_PER_CPU(u32, prng_state); > > -void kasan_init_tags(void) > +void __init kasan_init_tags(void) > { > int cpu; > > -- > 2.28.0.1011.ga647a8990f-goog >