From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9DBFC432C0 for ; Tue, 3 Dec 2019 12:54:44 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id ACFAD206EC for ; Tue, 3 Dec 2019 12:54:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="mar5GDv9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ACFAD206EC Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3878E6B0505; Tue, 3 Dec 2019 07:54:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 338796B0506; Tue, 3 Dec 2019 07:54:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 250566B0507; Tue, 3 Dec 2019 07:54:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0212.hostedemail.com [216.40.44.212]) by kanga.kvack.org (Postfix) with ESMTP id 0EC976B0505 for ; Tue, 3 Dec 2019 07:54:44 -0500 (EST) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with SMTP id A2DC5824D189 for ; Tue, 3 Dec 2019 12:54:43 +0000 (UTC) X-FDA: 76223824446.20.arch24_636d65115f023 X-HE-Tag: arch24_636d65115f023 X-Filterd-Recvd-Size: 5520 Received: from mail-oi1-f195.google.com (mail-oi1-f195.google.com [209.85.167.195]) by imf10.hostedemail.com (Postfix) with ESMTP for ; Tue, 3 Dec 2019 12:54:43 +0000 (UTC) Received: by mail-oi1-f195.google.com with SMTP id a67so3141499oib.6 for ; Tue, 03 Dec 2019 04:54:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=BmJQRM3jM7y44ZUHbbxJllXz33XwAbqBnK+cX6UUYYo=; b=mar5GDv9WjgkxE57QpT+0aS42J2aZKeqclSOBfYnf4fSP18ZLDlSQteBpBLb4+FmpU 3lAgxeVzsFn9AC53IcW8q4PcUVLYy+sBjzGW6aSaIJwaVLkQquAMjGKsCOjEOKaU4HSw UrqMqSsPUBlUlqXinZR3VcZzLLSIwN+iwrEv1u0sONOj/EuqMWSCsdmLUeJ8AH4ubWiF OHnwyQAcvJ05R8vHj/Eyfb7ri8UZ2Pm4gnAAGIY+rD7y3JpuewTEabWbF1gkJojIImLA 2DUMKcEwXFu1V3IsgZqj2J2D84cSp5XNEvPZ2G3ahIfuxUk3kX5MeSeL8yqoQ+NSGRDi 5nWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BmJQRM3jM7y44ZUHbbxJllXz33XwAbqBnK+cX6UUYYo=; b=RuhkSCOZkaDyAw0zoVSP9TlD+qrxvJ+oq+DHceI/e0jtb4BsBt5eUtb7arwqlN6qai VxhXaFTM1X52UUcBFZoZMFYZ2vbsK59p+NzOLoUiNoVC8ufkLfLvlgsXH688kaQt1cA0 P7luG82feZSRCBSMiiGV4RfvrL/rbdsK7tr6Pt3+y217MDWWQ7uLfAfAnthO0PMNs2Tx kgNTxByAypsvVpiWGoDoobdaV8TkbwqkAAo2elkjokUZlwhQzCTI0i0o1YdbA6prRpKu n+fxb23HM83/F4yQcJ22fxC+7GNHcLeELqS8w9jtxg5uqPikAsNbTnhBgP2KrqEj0NG8 Aisw== X-Gm-Message-State: APjAAAWZtal2hp14nfzjoE6ENjWvDonA9K2SwUbMxCcouo7U4Bv0+D12 9g5U0WptFpgzcsseqVzU0Qk1K8WZ4yoNnXm0vv28AA== X-Google-Smtp-Source: APXvYqyxxIZbP6UT5KsL9ZmOHtyH22EYIuqwYDxqBtDEYEkLMQFGclgOgEgE2BIwyLG3vjbooeLVcgm5QDPBGxIENgM= X-Received: by 2002:aca:2112:: with SMTP id 18mr3175698oiz.155.1575377682035; Tue, 03 Dec 2019 04:54:42 -0800 (PST) MIME-Version: 1.0 References: <20191122112621.204798-1-glider@google.com> <20191122112621.204798-35-glider@google.com> In-Reply-To: <20191122112621.204798-35-glider@google.com> From: Marco Elver Date: Tue, 3 Dec 2019 13:54:30 +0100 Message-ID: Subject: Re: [PATCH RFC v3 34/36] kmsan: disable physical page merging in biovec To: Alexander Potapenko Cc: Jens Axboe , Andy Lutomirski , Vegard Nossum , Dmitry Vyukov , Christoph Hellwig , Linux Memory Management List , Al Viro , Andreas Dilger , Andrew Morton , Andrey Konovalov , Andrey Ryabinin , Ard Biesheuvel , Arnd Bergmann , Christoph Hellwig , "Darrick J. Wong" , "David S. Miller" , Dmitry Torokhov , Eric Biggers , Eric Dumazet , Eric Van Hensbergen , Greg Kroah-Hartman , Harry Wentland , Herbert Xu , Ilya Leoshkevich , Ingo Molnar , Jason Wang , Marek Szyprowski , Mark Rutland , "Martin K. Petersen" , Martin Schwidefsky , Matthew Wilcox , "Michael S. Tsirkin" , Michal Simek , Petr Mladek , Qian Cai , Randy Dunlap , Robin Murphy , Sergey Senozhatsky , Steven Rostedt , Takashi Iwai , "Theodore Ts'o" , Thomas Gleixner , Vasily Gorbik , Wolfram Sang Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 22 Nov 2019 at 12:28, wrote: > > KMSAN metadata for consequent physical pages may be inconsequent, > therefore accessing such pages together may lead to metadata > corruption. > We disable merging pages in biovec to prevent such corruptions. > > Signed-off-by: Alexander Potapenko > To: Alexander Potapenko > Cc: Jens Axboe > Cc: Andy Lutomirski > Cc: Vegard Nossum > Cc: Dmitry Vyukov > Cc: Christoph Hellwig > Cc: linux-mm@kvack.org > --- > > Change-Id: Id2f2babaf662ac44675c4f2790f4a80ddc328fa7 > --- > block/blk.h | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/block/blk.h b/block/blk.h > index 47fba9362e60..9ee271a22423 100644 > --- a/block/blk.h > +++ b/block/blk.h > @@ -78,6 +78,13 @@ static inline bool biovec_phys_mergeable(struct request_queue *q, > phys_addr_t addr1 = page_to_phys(vec1->bv_page) + vec1->bv_offset; > phys_addr_t addr2 = page_to_phys(vec2->bv_page) + vec2->bv_offset; > > +#ifdef CONFIG_KMSAN Prefer 'if (IS_ENABLED(CONFIG_KMSAN))'. Thanks, -- Marco