From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92ACFC43457 for ; Thu, 15 Oct 2020 14:42:02 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B59F3218AC for ; Thu, 15 Oct 2020 14:42:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="vE0eTPBn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B59F3218AC Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A5954940007; Thu, 15 Oct 2020 10:42:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A09C3900002; Thu, 15 Oct 2020 10:42:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8F8B6940007; Thu, 15 Oct 2020 10:42:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0191.hostedemail.com [216.40.44.191]) by kanga.kvack.org (Postfix) with ESMTP id 630BF900002 for ; Thu, 15 Oct 2020 10:42:00 -0400 (EDT) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id E1687180AD806 for ; Thu, 15 Oct 2020 14:41:59 +0000 (UTC) X-FDA: 77374424358.15.flag08_030087427215 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin15.hostedemail.com (Postfix) with ESMTP id BA1451814B0C7 for ; Thu, 15 Oct 2020 14:41:59 +0000 (UTC) X-HE-Tag: flag08_030087427215 X-Filterd-Recvd-Size: 7247 Received: from mail-ot1-f65.google.com (mail-ot1-f65.google.com [209.85.210.65]) by imf08.hostedemail.com (Postfix) with ESMTP for ; Thu, 15 Oct 2020 14:41:59 +0000 (UTC) Received: by mail-ot1-f65.google.com with SMTP id s66so3141013otb.2 for ; Thu, 15 Oct 2020 07:41:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=P881tWlvRdjOUKzZkLHYnQuoFJ//OFLM6pqz5XqJ0Y0=; b=vE0eTPBnSXNiINasMQUFywAglF77XO05/Nj27/lfv4vHR8X1epIMbVDwWp3fUmG81e 6E7eEtQyFdyAVDX1pOA8PTS//vIvEdnH9mTXPw7by+G5J3pwbAO/F2TCNXfNHBlI6iqL dXnDfWE6neAEw6bqKNaPv7++j3S3G2TWh1Q9nBzl4VMw5xBajkUkNa8QwtJzagpBrP8G jeAJQ+UvBUzyRM5eGeBXPnLGcif7fNNXShuyNLNp3AVo9GKw0WNvZK56i7nj1oxWdkWq h+VIDBZzbzkP8n0rbY0bT0shf/7dle2c7aYCEi7PdkYJY3dBf/bjktx2Gh3m7voJhSE1 aWxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=P881tWlvRdjOUKzZkLHYnQuoFJ//OFLM6pqz5XqJ0Y0=; b=E/vGOkKITSIffc2v8DVcsdvK7AiCSBlBdPCebCDLA9rYDmaSTNaNq+lPMds/fOwtEK Q4PQ2+JvqW8iWiS119p4cwe1cuMjD5NrCMrrTZ/ozRHFLKk2q89In42UFiJtok578DP1 Q/aTaguIVlFO3zNagxQlT9+g9GkCgc8+hO9DSy9UH0UyG8W/77q0+WEKvpPRZ6wNeo0v NgsFCLjJb2H1JHopQ3NTMFhQHQB4kFUae/Y7ahTFuzkLZpFGfhkGOAQi8mIN0muIT8Cu zG+uKlkH5Gssdd3qhd68qXQvgSEKunKWWZZwIIe6+vJ9zq0zsmyvOKFla7jgcyP88dxl oHPg== X-Gm-Message-State: AOAM533INcyDvyLzXyh7tgQn+krngJaiWFggCsemBsQLalmtBANgi1ag 5vFEjsREJwusMP5hLzae3Wkn1zfi1bt9CPYrOM7j2g== X-Google-Smtp-Source: ABdhPJxeD69uK/WOd7mMJ5EHO3FBe0XlcJCzarJJHq+SUu5D5oRkFBcvqg8LMItlZGVc6gmUn6U/GGdOvuhubW+9zlQ= X-Received: by 2002:a9d:649:: with SMTP id 67mr3039830otn.233.1602772918284; Thu, 15 Oct 2020 07:41:58 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Marco Elver Date: Thu, 15 Oct 2020 16:41:46 +0200 Message-ID: Subject: Re: [PATCH RFC 0/8] kasan: hardware tag-based mode for production use on arm64 To: Andrey Konovalov Cc: Catalin Marinas , Will Deacon , Vincenzo Frascino , Dmitry Vyukov , Alexander Potapenko , Evgenii Stepanov , Andrey Ryabinin , Elena Petrova , Branislav Rankov , Kevin Brodsky , Andrew Morton , kasan-dev , Linux ARM , Linux Memory Management List , LKML Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 14 Oct 2020 at 22:44, Andrey Konovalov wrote: > This patchset is not complete (see particular TODOs in the last patch), > and I haven't performed any benchmarking yet, but I would like to start the > discussion now and hear people's opinions regarding the questions mentioned > below. > > === Overview > > This patchset adopts the existing hardware tag-based KASAN mode [1] for > use in production as a memory corruption mitigation. Hardware tag-based > KASAN relies on arm64 Memory Tagging Extension (MTE) [2] to perform memory > and pointer tagging. Please see [3] and [4] for detailed analysis of how > MTE helps to fight memory safety problems. > > The current plan is reuse CONFIG_KASAN_HW_TAGS for production, but add a > boot time switch, that allows to choose between a debugging mode, that > includes all KASAN features as they are, and a production mode, that only > includes the essentials like tag checking. > > It is essential that switching between these modes doesn't require > rebuilding the kernel with different configs, as this is required by the > Android GKI initiative [5]. > > The last patch of this series adds a new boot time parameter called > kasan_mode, which can have the following values: > > - "kasan_mode=on" - only production features > - "kasan_mode=debug" - all debug features > - "kasan_mode=off" - no checks at all (not implemented yet) > > Currently outlined differences between "on" and "debug": > > - "on" doesn't keep track of alloc/free stacks, and therefore doesn't > require the additional memory to store those > - "on" uses asyncronous tag checking (not implemented yet) > > === Questions > > The intention with this kind of a high level switch is to hide the > implementation details. Arguably, we could add multiple switches that allow > to separately control each KASAN or MTE feature, but I'm not sure there's > much value in that. > > Does this make sense? Any preference regarding the name of the parameter > and its values? KASAN itself used to be a debugging tool only. So introducing an "on" mode which no longer follows this convention may be confusing. Instead, maybe the following might be less confusing: "full" - current "debug", normal KASAN, all debugging help available. "opt" - current "on", optimized mode for production. "on" - automatic selection => chooses "full" if CONFIG_DEBUG_KERNEL, "opt" otherwise. "off" - as before. Also, if there is no other kernel boot parameter named "kasan" yet, maybe it could just be "kasan=..." ? > What should be the default when the parameter is not specified? I would > argue that it should be "debug" (for hardware that supports MTE, otherwise > "off"), as it's the implied default for all other KASAN modes. Perhaps we could make this dependent on CONFIG_DEBUG_KERNEL as above. I do not think that having the full/debug KASAN enabled on production kernels adds any value because for it to be useful requires somebody to actually look at the stacktraces; I think that choice should be made explicitly if it's a production kernel. My guess is that we'll save explaining performance differences and resulting headaches for ourselves and others that way. > Should we somehow control whether to panic the kernel on a tag fault? > Another boot time parameter perhaps? It already respects panic_on_warn, correct? > Any ideas as to how properly estimate the slowdown? As there's no > MTE-enabled hardware yet, the only way to test these patches is use an > emulator (like QEMU). The delay that is added by the emulator (for setting > and checking the tags) is different from the hardware delay, and this skews > the results. > > A question to KASAN maintainers: what would be the best way to support the > "off" mode? I see two potential approaches: add a check into each kasan > callback (easier to implement, but we still call kasan callbacks, even > though they immediately return), or add inline header wrappers that do the > same. [...] Thanks, -- Marco