From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 485E9CA9ED3 for ; Mon, 4 Nov 2019 18:41:46 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0562620B7C for ; Mon, 4 Nov 2019 18:41:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="JAbFW9ec" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0562620B7C Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 8BD316B0003; Mon, 4 Nov 2019 13:41:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 86D966B0005; Mon, 4 Nov 2019 13:41:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 783036B0006; Mon, 4 Nov 2019 13:41:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0073.hostedemail.com [216.40.44.73]) by kanga.kvack.org (Postfix) with ESMTP id 632E56B0003 for ; Mon, 4 Nov 2019 13:41:45 -0500 (EST) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with SMTP id 1811D181AEF07 for ; Mon, 4 Nov 2019 18:41:45 +0000 (UTC) X-FDA: 76119463770.10.cause16_839c4b1dfca50 X-HE-Tag: cause16_839c4b1dfca50 X-Filterd-Recvd-Size: 10877 Received: from mail-ot1-f65.google.com (mail-ot1-f65.google.com [209.85.210.65]) by imf49.hostedemail.com (Postfix) with ESMTP for ; Mon, 4 Nov 2019 18:41:44 +0000 (UTC) Received: by mail-ot1-f65.google.com with SMTP id l14so974493oti.10 for ; Mon, 04 Nov 2019 10:41:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ph+IqdOgslNSLP+IIBkbCH/w84oSj6hoU4Op/Hgua2Y=; b=JAbFW9ecTFBVxutd5BVQhSj7UIlWDxWCHHwVM0gnWS95kG0eOutZ52mNFci7PzB2nY LnE0+/YwE/9yT0NW9Hr9E89N1hwQsp6JNP5sLwrlG5/li7gepF/t/ML+ldCixHKtcqNV oFJjAavtD2mrBCV2OZc4Grj+a0FZ+nOVDV/+yU21lFuh6qHeNpo2Mu3hCcF4cNIdtpvF oQF00OS2eLfy0nIzfmzAqpkkyOjIuYY/k6lmF4VCX7ZtjM3v26QYt8/O3v6HCpOs70Yh qHqkZLH/uenRDdO97kCwVGUE3ScR7k7455bO9ZkN8dLh01T+CZcy9fFgPGdxo4+eM8qE AKJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ph+IqdOgslNSLP+IIBkbCH/w84oSj6hoU4Op/Hgua2Y=; b=Ihn/ljb9yVh0VHLLqJobfhRWlbaRcArjMwQVyA239UReZMQ+4QYYqbZiIKVq357QH+ 7dEl/hToyeB0pPjUgYzS+81KosZ6ZuEOGDWjMLrq/fyFsI+gIzPVoo8MLKB43TSnBb5U c9JTOvTXs++zh+3mkTjFHFrMBcTEpL7q6w3U+Csuxox2bSE3OSDhMD9wtkwPbdLC2dyi Xv+Pms6UTE8YiSi3CZVIz/NkqjK/prxol3+abFWjyekK7F01iZeKiBsV3zWExsbRuoFo QVnUgpO00WTekc9UXwWzadgk+q63AZuuh1zchloJPUEo6n80gn1rNxWZdUNrz28yM41m xPBg== X-Gm-Message-State: APjAAAWIsDQF4IOJpptXFgMCya69LW09O58CkOSvmUp8v6K8/TIzW0DJ OqaMlUAkJF1fK23OJU8IetOzLCZDfRc8nWv5sSvpZQ== X-Google-Smtp-Source: APXvYqxIshoS8PhXmbRpwZOoMMnW2/1m3a5LxT9QOARxujqmlSz/axQsD6s/aCGbL4utL0DXOET1ezIGgX49jUaKAxo= X-Received: by 2002:a9d:7308:: with SMTP id e8mr119704otk.17.1572892902802; Mon, 04 Nov 2019 10:41:42 -0800 (PST) MIME-Version: 1.0 References: <20191104142745.14722-1-elver@google.com> <20191104164717.GE20975@paulmck-ThinkPad-P72> In-Reply-To: <20191104164717.GE20975@paulmck-ThinkPad-P72> From: Marco Elver Date: Mon, 4 Nov 2019 19:41:30 +0100 Message-ID: Subject: Re: [PATCH v3 0/9] Add Kernel Concurrency Sanitizer (KCSAN) To: "Paul E. McKenney" Cc: LKMM Maintainers -- Akira Yokosawa , Alan Stern , Alexander Potapenko , Andrea Parri , Andrey Konovalov , Andy Lutomirski , Ard Biesheuvel , Arnd Bergmann , Boqun Feng , Borislav Petkov , Daniel Axtens , Daniel Lustig , Dave Hansen , David Howells , Dmitry Vyukov , "H. Peter Anvin" , Ingo Molnar , Jade Alglave , Joel Fernandes , Jonathan Corbet , Josh Poimboeuf , Luc Maranget , Mark Rutland , Nicholas Piggin , Peter Zijlstra , Thomas Gleixner , Will Deacon , kasan-dev , linux-arch , "open list:DOCUMENTATION" , linux-efi@vger.kernel.org, Linux Kbuild mailing list , LKML , Linux Memory Management List , "the arch/x86 maintainers" Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 4 Nov 2019 at 17:47, Paul E. McKenney wrote: > > On Mon, Nov 04, 2019 at 03:27:36PM +0100, Marco Elver wrote: > > This is the patch-series for the Kernel Concurrency Sanitizer (KCSAN). > > KCSAN is a sampling watchpoint-based data-race detector. More details > > are included in Documentation/dev-tools/kcsan.rst. This patch-series > > only enables KCSAN for x86, but we expect adding support for other > > architectures is relatively straightforward (we are aware of > > experimental ARM64 and POWER support). > > > > To gather early feedback, we announced KCSAN back in September, and > > have integrated the feedback where possible: > > http://lkml.kernel.org/r/CANpmjNPJ_bHjfLZCAPV23AXFfiPiyXXqqu72n6TgWzb2Gnu1eA@mail.gmail.com > > > > We want to point out and acknowledge the work surrounding the LKMM, > > including several articles that motivate why data-races are dangerous > > [1, 2], justifying a data-race detector such as KCSAN. > > [1] https://lwn.net/Articles/793253/ > > [2] https://lwn.net/Articles/799218/ > > > > The current list of known upstream fixes for data-races found by KCSAN > > can be found here: > > https://github.com/google/ktsan/wiki/KCSAN#upstream-fixes-of-data-races-found-by-kcsan > > Making this more accessible to more people seems like a good thing. > So, for the series: > > Acked-by: Paul E. McKenney Much appreciated. Thanks, Paul! Any suggestions which tree this could eventually land in? Thanks, -- Marco > > Changelog > > --------- > > v3: > > * Major changes: > > - Add microbenchmark. > > - Add instruction watchpoint skip randomization. > > - Refactor API and core runtime fast-path and slow-path. Compared to > > the previous version, with a default config and benchmarked using the > > added microbenchmark, this version is 3.8x faster. > > - Make __tsan_unaligned __alias of generic accesses. > > - Rename kcsan_{begin,end}_atomic -> > > kcsan_{nestable,flat}_atomic_{begin,end} > > - For filter list in debugfs.c use kmalloc+krealloc instead of > > kvmalloc. > > - Split Documentation into separate patch. > > > > v2: http://lkml.kernel.org/r/20191017141305.146193-1-elver@google.com > > * Major changes: > > - Replace kcsan_check_access(.., {true, false}) with > > kcsan_check_{read,write}. > > - Change atomic-instrumented.h to use __atomic_check_{read,write}. > > - Use common struct kcsan_ctx in task_struct and for per-CPU interrupt > > contexts. > > > > v1: http://lkml.kernel.org/r/20191016083959.186860-1-elver@google.com > > > > Marco Elver (9): > > kcsan: Add Kernel Concurrency Sanitizer infrastructure > > kcsan: Add Documentation entry in dev-tools > > objtool, kcsan: Add KCSAN runtime functions to whitelist > > build, kcsan: Add KCSAN build exceptions > > seqlock, kcsan: Add annotations for KCSAN > > seqlock: Require WRITE_ONCE surrounding raw_seqcount_barrier > > asm-generic, kcsan: Add KCSAN instrumentation for bitops > > locking/atomics, kcsan: Add KCSAN instrumentation > > x86, kcsan: Enable KCSAN for x86 > > > > Documentation/dev-tools/index.rst | 1 + > > Documentation/dev-tools/kcsan.rst | 217 +++++++++ > > MAINTAINERS | 11 + > > Makefile | 3 +- > > arch/x86/Kconfig | 1 + > > arch/x86/boot/Makefile | 2 + > > arch/x86/boot/compressed/Makefile | 2 + > > arch/x86/entry/vdso/Makefile | 3 + > > arch/x86/include/asm/bitops.h | 6 +- > > arch/x86/kernel/Makefile | 7 + > > arch/x86/kernel/cpu/Makefile | 3 + > > arch/x86/lib/Makefile | 4 + > > arch/x86/mm/Makefile | 3 + > > arch/x86/purgatory/Makefile | 2 + > > arch/x86/realmode/Makefile | 3 + > > arch/x86/realmode/rm/Makefile | 3 + > > drivers/firmware/efi/libstub/Makefile | 2 + > > include/asm-generic/atomic-instrumented.h | 393 +++++++-------- > > include/asm-generic/bitops-instrumented.h | 18 + > > include/linux/compiler-clang.h | 9 + > > include/linux/compiler-gcc.h | 7 + > > include/linux/compiler.h | 35 +- > > include/linux/kcsan-checks.h | 97 ++++ > > include/linux/kcsan.h | 115 +++++ > > include/linux/sched.h | 4 + > > include/linux/seqlock.h | 51 +- > > init/init_task.c | 8 + > > init/main.c | 2 + > > kernel/Makefile | 6 + > > kernel/kcsan/Makefile | 11 + > > kernel/kcsan/atomic.h | 27 ++ > > kernel/kcsan/core.c | 560 ++++++++++++++++++++++ > > kernel/kcsan/debugfs.c | 275 +++++++++++ > > kernel/kcsan/encoding.h | 94 ++++ > > kernel/kcsan/kcsan.h | 131 +++++ > > kernel/kcsan/report.c | 306 ++++++++++++ > > kernel/kcsan/test.c | 121 +++++ > > kernel/sched/Makefile | 6 + > > lib/Kconfig.debug | 2 + > > lib/Kconfig.kcsan | 119 +++++ > > lib/Makefile | 3 + > > mm/Makefile | 8 + > > scripts/Makefile.kcsan | 6 + > > scripts/Makefile.lib | 10 + > > scripts/atomic/gen-atomic-instrumented.sh | 17 +- > > tools/objtool/check.c | 18 + > > 46 files changed, 2526 insertions(+), 206 deletions(-) > > create mode 100644 Documentation/dev-tools/kcsan.rst > > create mode 100644 include/linux/kcsan-checks.h > > create mode 100644 include/linux/kcsan.h > > create mode 100644 kernel/kcsan/Makefile > > create mode 100644 kernel/kcsan/atomic.h > > create mode 100644 kernel/kcsan/core.c > > create mode 100644 kernel/kcsan/debugfs.c > > create mode 100644 kernel/kcsan/encoding.h > > create mode 100644 kernel/kcsan/kcsan.h > > create mode 100644 kernel/kcsan/report.c > > create mode 100644 kernel/kcsan/test.c > > create mode 100644 lib/Kconfig.kcsan > > create mode 100644 scripts/Makefile.kcsan > > > > -- > > 2.24.0.rc1.363.gb1bccd3e3d-goog > > > > -- > You received this message because you are subscribed to the Google Groups "kasan-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an email to kasan-dev+unsubscribe@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/kasan-dev/20191104164717.GE20975%40paulmck-ThinkPad-P72.