From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70CE1C433EF for ; Wed, 16 Feb 2022 19:31:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A84326B0074; Wed, 16 Feb 2022 14:31:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A0BF56B0075; Wed, 16 Feb 2022 14:31:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 887356B0078; Wed, 16 Feb 2022 14:31:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0056.hostedemail.com [216.40.44.56]) by kanga.kvack.org (Postfix) with ESMTP id 78F356B0074 for ; Wed, 16 Feb 2022 14:31:42 -0500 (EST) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 3A1D98C59B for ; Wed, 16 Feb 2022 19:31:42 +0000 (UTC) X-FDA: 79149637644.15.567F7D8 Received: from mail-yb1-f174.google.com (mail-yb1-f174.google.com [209.85.219.174]) by imf14.hostedemail.com (Postfix) with ESMTP id BAAD4100002 for ; Wed, 16 Feb 2022 19:31:41 +0000 (UTC) Received: by mail-yb1-f174.google.com with SMTP id v186so8343406ybg.1 for ; Wed, 16 Feb 2022 11:31:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dXrDCcliqXFznAwN9UKmpIFnfCTr0AltCrpKcHBOhyI=; b=qJ/yCvpEUmPA0hRxUmuaDL81dNgclLtlovcbdNgaJnAG1T1c32U9gLeLgGeqRZK46y ZHBad5Ri7881CaaonxsVe70p0ozztVdEVl1vZUad7WOwV/8X6HAinMDGmukdCqZuotDp BvK2CvmQfatfstbbEvvmtJUX1E+TngZgH7jIZUGi3DR1pFu53xgJQme+IT+UcZgcQfON 5G603uaeNfjqESP9nuEOL/Au6g2oZwo6bdz22BtrNEU2RdbszEC2MJhkQ1xZUnKQ6Jeq 8qBYNEHe5r560UUO4tg0Q05n5D+orZdP2KbqZRDMmjaZUT/jm2hYDmTksU2I1M+jhVEK 18XA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dXrDCcliqXFznAwN9UKmpIFnfCTr0AltCrpKcHBOhyI=; b=8HxgIu3ojm11YY9iEZbzJC0yJHFEFACsdQgu3kpCv1Wssqf2BKuuwDKxiBNcE54YHj K0NWlywUNMTRO8Li+0eXTYLzeONve1jsPnn9shcWtuSj3RKuAiyKEANPEkTvjMFfOEVs r62G2HTxSdbA9bqT1Zu8lXGrQclctdVC9xiJI2+QXoyeAcPla2Hnx1O/9BYoCyW7NmHS bNlFzx33ak1EDqulBebUlAEWOknf9jrUAastVXbMY0+pbziQv+7dNPZr8n8ES6dafZhZ CQrKCHiIpXmz/q2uPdErirlBjv5qwyOslawd7by1hF2r0ehc1N15ZMG9dZ66XNsC2E0Z ejzQ== X-Gm-Message-State: AOAM530BzIg+Hd9nnrzEfkn2kxQk3ECHlZqjyZIMTB4900EGGstvI9Lx fmuPMSIgaA/f4Pp1NCqNgAwR7H5cKYrQXvfFST9fvw== X-Google-Smtp-Source: ABdhPJyd8vNcqO73LtXnsYyTU+wTX6CnjbUBRm0qKYB+hv+NCyTiJtR9isxNXT4zUaugFzR/dpVMje33RcuTSxrzBNk= X-Received: by 2002:a25:f441:0:b0:611:4f60:aab1 with SMTP id p1-20020a25f441000000b006114f60aab1mr3441157ybe.598.1645039900830; Wed, 16 Feb 2022 11:31:40 -0800 (PST) MIME-Version: 1.0 References: <5b120f7cadcc0e0d8d5f41fd0cff35981b3f7f3a.1645038022.git.andreyknvl@google.com> In-Reply-To: <5b120f7cadcc0e0d8d5f41fd0cff35981b3f7f3a.1645038022.git.andreyknvl@google.com> From: Marco Elver Date: Wed, 16 Feb 2022 20:31:29 +0100 Message-ID: Subject: Re: [PATCH mm] kasan: print virtual mapping info in reports To: andrey.konovalov@linux.dev Cc: Alexander Potapenko , Andrew Morton , Andrey Konovalov , Dmitry Vyukov , Andrey Ryabinin , kasan-dev@googlegroups.com, Vincenzo Frascino , Catalin Marinas , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrey Konovalov Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: ymmubgnwc75inxybfzonji163i6mdii3 X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: BAAD4100002 Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b="qJ/yCvpE"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf14.hostedemail.com: domain of elver@google.com designates 209.85.219.174 as permitted sender) smtp.mailfrom=elver@google.com X-Rspam-User: X-HE-Tag: 1645039901-873681 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 16 Feb 2022 at 20:01, wrote: > > From: Andrey Konovalov > > Print virtual mapping range and its creator in reports affecting virtual > mappings. > > Also get physical page pointer for such mappings, so page information > gets printed as well. > > Signed-off-by: Andrey Konovalov > > --- > > Note: no need to merge this patch into any of the KASAN vmalloc patches > that are already in mm, better to keep it separate. > --- > mm/kasan/report.c | 12 +++++++++++- > 1 file changed, 11 insertions(+), 1 deletion(-) > > diff --git a/mm/kasan/report.c b/mm/kasan/report.c > index 137c2c0b09db..8002fb3c417d 100644 > --- a/mm/kasan/report.c > +++ b/mm/kasan/report.c > @@ -260,8 +260,18 @@ static void print_address_description(void *addr, u8 tag) > pr_err(" %pS\n", addr); > } > > + if (is_vmalloc_addr(addr)) { > + struct vm_struct *va = find_vm_area(addr); > + > + pr_err("The buggy address belongs to the virtual mapping at\n" > + " [%px, %px) created by:\n" > + " %pS\n", va->addr, va->addr + va->size, va->caller); Can you show an example of what this looks like? It's not showing a stack trace, so why not continue the line and just say "... created by: %pS\n" > + page = vmalloc_to_page(page); > + } > + > if (page) { > - pr_err("The buggy address belongs to the page:\n"); > + pr_err("The buggy address belongs to the physical page:\n"); > dump_page(page, "kasan: bad access detected"); > } > > -- > 2.25.1 >