From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F7C2C48BC2 for ; Mon, 21 Jun 2021 12:45:35 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 12EB560232 for ; Mon, 21 Jun 2021 12:45:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 12EB560232 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 90B7C6B006E; Mon, 21 Jun 2021 08:45:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8466A6B0070; Mon, 21 Jun 2021 08:45:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6E7276B0072; Mon, 21 Jun 2021 08:45:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0024.hostedemail.com [216.40.44.24]) by kanga.kvack.org (Postfix) with ESMTP id 3D3526B006E for ; Mon, 21 Jun 2021 08:45:34 -0400 (EDT) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id CB5E2F056 for ; Mon, 21 Jun 2021 12:45:33 +0000 (UTC) X-FDA: 78277702146.12.B058F0D Received: from mail-ot1-f42.google.com (mail-ot1-f42.google.com [209.85.210.42]) by imf22.hostedemail.com (Postfix) with ESMTP id 80A90C0237FE for ; Mon, 21 Jun 2021 12:45:29 +0000 (UTC) Received: by mail-ot1-f42.google.com with SMTP id h24-20020a9d64180000b029036edcf8f9a6so17585940otl.3 for ; Mon, 21 Jun 2021 05:45:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=O21GciyTpaxqmDgMZPyp7BhBIp+OaBFdrCDg/nqizCw=; b=CjH/y8SaoMXF3byYcObLTv0osehq88mbaxDpOhZs0Wde7MnJHOtQUe+kCASuohN8oG aOWjfAalOynXbrGRj/MB2LUyVcX9vr8SKfNkA6vR5F8unfVTmTYZtR49cCle1lEV11Xh Ej0cE2eP1kq4/I+8RSOKISdSP+5LyhiOFPyq9/3gcbEJQF0JV7o3XkzEI0ZvlwqsSBjm 1mTGYUNavnyfjgaO7A1ymewQLHi03NM0RPUjmuFWlioFGMBlH2hAjljmtBsJmO9pc7h4 RtUtfdeApE98KZ6pE/LExb0eKC8qA2+ShDr0eTtERUy9CEZRTeXGdg2uczBqW8+RnCuu J33Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=O21GciyTpaxqmDgMZPyp7BhBIp+OaBFdrCDg/nqizCw=; b=p6Vjh2CP02wH9jHv34ihrDre5s3HhnlAnEO28zTbZ7xQh292pmpXHVAOaZ2dxyohYl CiKI7TdizHq/faI28BCrduriIbngpjdLemzGW9W+cDYIhBTLPdaxWXoN2kcSaC6u5ivB q+ZvUoA6aY3k35Pbdqhrx3fON9bTz43CwkB13FfTP9HQiGd/4jfe+VbwWX0yTWbeOgcL nmiysIp2s9nrWK+6+wi0KRgAoDIU1mPNmOgPLuD9oykvkA90fQ5MB3Je/iRpJraK14PT c/jzn2EAU3ZbZtdMRPGZIHMDrCPYH8SMIn4UnCgH+IoqLgvZE7AYAFWhboi0DuJgCy05 cwCg== X-Gm-Message-State: AOAM5320C16yQNbJZJ5OqBfxYxCIL4Fl541DlZwfwS7rBHVZ6fV7WtHz JxVdUPxZPtNz4UU20OSSb9zSSXBTz+1d3t7DbCgvqw== X-Google-Smtp-Source: ABdhPJzU6m6lFzkIY/6suaM+3/SBqnWkGz1uc7je6Xn6rX8rQ595uL4fIZD/BMSlOIOl3gn/FRim1zid6MPDXSS0vfQ= X-Received: by 2002:a9d:4e7:: with SMTP id 94mr21273799otm.233.1624279532556; Mon, 21 Jun 2021 05:45:32 -0700 (PDT) MIME-Version: 1.0 References: <20210620114756.31304-1-Kuan-Ying.Lee@mediatek.com> In-Reply-To: <20210620114756.31304-1-Kuan-Ying.Lee@mediatek.com> From: Marco Elver Date: Mon, 21 Jun 2021 14:45:20 +0200 Message-ID: Subject: Re: [PATCH v3 0/3] kasan: add memory corruption identification support for hw tag-based kasan To: Kuan-Ying Lee Cc: Andrey Ryabinin , Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Andrew Morton , Matthias Brugger , kasan-dev , LKML , Linux Memory Management List , Linux ARM , linux-mediatek@lists.infradead.org, wsd_upstream , chinwen.chang@mediatek.com, nicholas.tang@mediatek.com Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=google.com header.s=20161025 header.b="CjH/y8Sa"; spf=pass (imf22.hostedemail.com: domain of elver@google.com designates 209.85.210.42 as permitted sender) smtp.mailfrom=elver@google.com; dmarc=pass (policy=reject) header.from=google.com X-Stat-Signature: ofeecxthmmshz6x5ro933pi14ppgamwj X-Rspamd-Queue-Id: 80A90C0237FE X-Rspamd-Server: rspam06 X-HE-Tag: 1624279529-61185 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, 20 Jun 2021 at 13:48, Kuan-Ying Lee wrote: > > Add memory corruption identification for hardware tag-based KASAN mode. > > Changes since v3: > - Preserve Copyright from hw_tags.c/sw_tags.c and > report_sw_tags.c/report_hw_tags.c > - Make non-trivial change in kasan sw tag-based mode > > Changes since v2: > - Thanks for Marco's Suggestion > - Rename the CONFIG_KASAN_SW_TAGS_IDENTIFY > - Integrate tag-based kasan common part > - Rebase to latest linux-next > > Kuan-Ying Lee (3): > kasan: rename CONFIG_KASAN_SW_TAGS_IDENTIFY to > CONFIG_KASAN_TAGS_IDENTIFY > kasan: integrate the common part of two KASAN tag-based modes > kasan: add memory corruption identification support for hardware > tag-based mode I think this looks fine, thank you for your efforts. How did you test this? Did you run the lib/test_kasan module with both SW_TAGS and HW_TAGS mode? I was about to run that before adding my Reviewed-by. Andrey, Alex, if you have time, please have a quick look at the series. Thanks, -- Marco