From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7944C4338F for ; Thu, 29 Jul 2021 12:27:44 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4A80360EFF for ; Thu, 29 Jul 2021 12:27:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4A80360EFF Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id E466D6B0036; Thu, 29 Jul 2021 08:27:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DF7508D0002; Thu, 29 Jul 2021 08:27:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D0CCA8D0001; Thu, 29 Jul 2021 08:27:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0111.hostedemail.com [216.40.44.111]) by kanga.kvack.org (Postfix) with ESMTP id B751C6B0036 for ; Thu, 29 Jul 2021 08:27:43 -0400 (EDT) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 6A6331842C4A5 for ; Thu, 29 Jul 2021 12:27:43 +0000 (UTC) X-FDA: 78415551606.05.4A9BF09 Received: from mail-oo1-f51.google.com (mail-oo1-f51.google.com [209.85.161.51]) by imf04.hostedemail.com (Postfix) with ESMTP id 2F1E450062F0 for ; Thu, 29 Jul 2021 12:27:43 +0000 (UTC) Received: by mail-oo1-f51.google.com with SMTP id o17-20020a4a64110000b0290263e1ba7ff9so1531228ooc.2 for ; Thu, 29 Jul 2021 05:27:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=jAeYpTpD86gcaq0fp6AOwIIDB2L6QnWwp67+iHCveIY=; b=ml7Q/Yn+L1JNrhw7y+0CfmimrYs8yNnxEQL5SIK39c4Q4kU9hmEqtqiUIj7p0lualS 0vl5sVIyOjyzAJs3BAYo00cW5Xuzev16ok5ctZ1VenR5k5EXd9Hs4EhZnOyoCHNxd2e8 h6gi/8lbU8DnWXPHHV9lzdhTWrNGRNs/TgW0907rIkBQJgmhpBfuZUCcl9P5uAbSbudl 6PY2SQe37ZnHdElfZ4fPaT+GKxN2JRT/bytQfZ5pkpMxa5xqutvqEJQNyuWCQq3v8OZD uIvrWImjE/wtpdzv+NDPzLdp+rslqBSRMHRTF3PRKSl0ihPR9C/7MqQwEX3Gsd5sw7Nl 5txg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jAeYpTpD86gcaq0fp6AOwIIDB2L6QnWwp67+iHCveIY=; b=bjlV4fYI3asKKgq6Bl5V+Oag4ZCXUqK2nNc+9UCtvt38dqu7SoYEcXXKr9uaNvYr9O nwYOyOz/2yXB6qCWkEuhyG1+LJOSdsaMtiqRS/1o2NTC15GwQLXUSLC0JDJjoLVEpE5v o7YaJiwIQJByInDpBsfyhDfWoFi1aPmSv54BV92rVfFsfNTHs+LMHhJQGRKAszP6TInj Q+PssMu9d38KvDpwQKFT2cLuyGzBI7n92AG5MYpaneFQ4Uv+v3PfMXM85ber432wS7Gl wJXihpNKbTmhQAmCy1iasjFOXC4Fv1au73bD/iXMiljl5IGOjSv/clXruInWdC53YhU+ gTwA== X-Gm-Message-State: AOAM532NLuDQSTa6smae0JokC7nKl3YewPQjbKRqx1z70dRZrmI+TqNy V6K4LetxEwS0pXwv3RSL7w0RmZvvV79gOkKEPSE+aQ== X-Google-Smtp-Source: ABdhPJzdZqCMYw/artCLUUOUtHTdZ/eyCd1qEAfxK53RlOp+/u7kO6WD0K9TwsO2g5IRhUr+gY/uSniuVTaTdFDFO3w= X-Received: by 2002:a4a:e502:: with SMTP id r2mr2827562oot.36.1627561662128; Thu, 29 Jul 2021 05:27:42 -0700 (PDT) MIME-Version: 1.0 References: <20210728190254.3921642-1-hca@linux.ibm.com> <20210728190254.3921642-3-hca@linux.ibm.com> In-Reply-To: From: Marco Elver Date: Thu, 29 Jul 2021 14:27:30 +0200 Message-ID: Subject: Re: [PATCH 2/4] kfence: add function to mask address bits To: Heiko Carstens Cc: Alexander Potapenko , Sven Schnelle , Vasily Gorbik , Christian Borntraeger , kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=google.com header.s=20161025 header.b="ml7Q/Yn+"; spf=pass (imf04.hostedemail.com: domain of elver@google.com designates 209.85.161.51 as permitted sender) smtp.mailfrom=elver@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspamd-Server: rspam02 X-Stat-Signature: c9mc855jeq3qz5mp3imzogmru4bmkwao X-Rspamd-Queue-Id: 2F1E450062F0 X-HE-Tag: 1627561663-549974 X-Bogosity: Ham, tests=bogofilter, spamicity=0.152068, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 29 Jul 2021 at 14:25, Heiko Carstens wrote: > On Thu, Jul 29, 2021 at 09:48:58AM +0200, Marco Elver wrote: > > On Wed, Jul 28, 2021 at 09:02PM +0200, Heiko Carstens wrote: > > > From: Sven Schnelle > > > > > > s390 only reports the page address during a translation fault. > > > To make the kfence unit tests pass, add a function that might > > > be implemented by architectures to mask out address bits. > > > > > > Signed-off-by: Sven Schnelle > > > Signed-off-by: Heiko Carstens > > > > I noticed this breaks on x86 if CONFIG_KFENCE_KUNIT_TEST=m, because x86 > > conditionally declares some asm functions if !MODULE. > > > > I think the below is the simplest to fix, and if you agree, please carry > > it as a patch in this series before this patch. > > Will do. > > > With the below, you can add to this patch: > > > > Reviewed-by: Marco Elver > > Done - Thank you! I silently assume this means also you have no > objections if we carry this via the s390 tree for upstreaming. I think that's reasonable. I'm not aware of any conflicts, nor am I expecting any for the upcoming cycle. Thanks, -- Marco