From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BD17C388F9 for ; Wed, 11 Nov 2020 19:05:13 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A19DD20678 for ; Wed, 11 Nov 2020 19:05:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="IHIZ/9tF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A19DD20678 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 072DD6B005D; Wed, 11 Nov 2020 14:05:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0220E6B006C; Wed, 11 Nov 2020 14:05:11 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E2DE26B006E; Wed, 11 Nov 2020 14:05:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0052.hostedemail.com [216.40.44.52]) by kanga.kvack.org (Postfix) with ESMTP id B877D6B005D for ; Wed, 11 Nov 2020 14:05:11 -0500 (EST) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 671D1181AEF09 for ; Wed, 11 Nov 2020 19:05:11 +0000 (UTC) X-FDA: 77473065222.11.pig67_160319527300 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin11.hostedemail.com (Postfix) with ESMTP id 367E7180F8B81 for ; Wed, 11 Nov 2020 19:05:11 +0000 (UTC) X-HE-Tag: pig67_160319527300 X-Filterd-Recvd-Size: 4209 Received: from mail-ot1-f66.google.com (mail-ot1-f66.google.com [209.85.210.66]) by imf22.hostedemail.com (Postfix) with ESMTP for ; Wed, 11 Nov 2020 19:05:10 +0000 (UTC) Received: by mail-ot1-f66.google.com with SMTP id y22so3139551oti.10 for ; Wed, 11 Nov 2020 11:05:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dqQUt8nF2kgPMW+WfpdEe9JIcv1VB4HVulAU3CTX4MU=; b=IHIZ/9tFgR6oUqI2s20AR2vQEbvYVpaiSYLJuPVf3iwe2ZQV1VwFJ9+pAW89ziWPTO 9dlpBiurvBMFq0/RivSJhV1RO9wMucn8oyQ/k8VPIc0KiK+mL+wcfVOwXQAYdACEdDiy Z1EtjzXKr4mVitKEWIKdU9HTi2vZdEXGthD/g42ZTPEfS/pgLTCxhjwev1uXzFhoO+WO 5PC2y9Kp0PNdwULAeFnTowPwEyAVV7srzimiCunf/CzRr+vzc+SoT5gnQGNjiQIxLC9o 5K1alRUaaVRVStwgo/41+Sxg8AIJE0nGGsCWwN6EgKZZ+dsBOyp8oawS5ER6EBBNZ6xY sFVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dqQUt8nF2kgPMW+WfpdEe9JIcv1VB4HVulAU3CTX4MU=; b=jdalnkCgO5oyy1XbMqBUjO6RILiLBoU6s4a5j31y48HDNt5lDN/WSkb1zpc2l/H2Gt 0UCreaOHb6v/kDxODvsz4XN+jqdvJVYom9MsPFc/zLYfsAmPJJa57G/KqnzMCk2wYJq0 CZLfWSV1H5mvNCCoNhWX9WTVGduztsth9rCYuMev7y7awb5JusX+n6DSi1/iSCY9EyH4 SBSbdiV1uGVqDu5V0svUJEajG/I1l2/5wtnl8OPNwG0oy3URRH1kji6/+Uxb3zoCZru2 gR9Fj9QxD74Ywh3xRSx6Onzmvtc8tM96yMtwl+Uq5/2gebr06QBsFpqGoUO7mykSwVpp JkCw== X-Gm-Message-State: AOAM533IEqEN1VNlJd+euOKo4YXj5g8jMOd8q7jzvQfr7uSW8mobmIqG Yvukl5Ra1wSwgPH5IrNx2HWZ7N7RtDwWulDnf0m2rA== X-Google-Smtp-Source: ABdhPJxXbQWUGNUMQElrxCpcnrSK7G4S7/uSGvEizPe9UE7YdETr/ssdRHzUaHNu9Qf5AnoDXsJutvt7An4JgEB67kk= X-Received: by 2002:a9d:65d5:: with SMTP id z21mr17412658oth.251.1605121509540; Wed, 11 Nov 2020 11:05:09 -0800 (PST) MIME-Version: 1.0 References: <85aba371903b749412fac34e44e54c89e5ddae30.1605046192.git.andreyknvl@google.com> In-Reply-To: From: Marco Elver Date: Wed, 11 Nov 2020 20:04:58 +0100 Message-ID: Subject: Re: [PATCH v9 10/44] kasan: define KASAN_GRANULE_PAGE To: Andrey Konovalov Cc: Alexander Potapenko , Catalin Marinas , Will Deacon , Vincenzo Frascino , Dmitry Vyukov , Andrey Ryabinin , Evgenii Stepanov , Branislav Rankov , Kevin Brodsky , Andrew Morton , kasan-dev , Linux ARM , Linux Memory Management List , LKML Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 11 Nov 2020 at 19:48, Andrey Konovalov wrote: > > On Wed, Nov 11, 2020 at 3:13 PM Alexander Potapenko wrote: > > > > On Tue, Nov 10, 2020 at 11:11 PM Andrey Konovalov wrote: > > > > > > Define KASAN_GRANULE_PAGE as (KASAN_GRANULE_SIZE << PAGE_SHIFT), which is > > > the same as (KASAN_GRANULE_SIZE * PAGE_SIZE), and use it across KASAN code > > > to simplify it. > > > > What's the physical sense behind KASAN_GRANULE_PAGE? Is it something > > more than just a product of two constants? > > No, just a product. > > > The name suggests it might be something page-sized, but in reality it is not. > > What name would you prefer? Is it actually KASAN_GRANULES_PER_SHADOW_PAGE ? AFAIK we're trying to calculate the granules that we can fit into a page of shadow memory.