From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBA39C010A3 for ; Tue, 5 Nov 2019 11:11:10 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 65CE121928 for ; Tue, 5 Nov 2019 11:11:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="UdD+cwSe" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 65CE121928 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D77C46B0003; Tue, 5 Nov 2019 06:11:09 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D2A006B0006; Tue, 5 Nov 2019 06:11:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C17256B0007; Tue, 5 Nov 2019 06:11:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0197.hostedemail.com [216.40.44.197]) by kanga.kvack.org (Postfix) with ESMTP id A537D6B0003 for ; Tue, 5 Nov 2019 06:11:09 -0500 (EST) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with SMTP id 68A81181AEF10 for ; Tue, 5 Nov 2019 11:11:09 +0000 (UTC) X-FDA: 76121957058.03.feast35_2721f91b5530d X-HE-Tag: feast35_2721f91b5530d X-Filterd-Recvd-Size: 12422 Received: from mail-ot1-f66.google.com (mail-ot1-f66.google.com [209.85.210.66]) by imf43.hostedemail.com (Postfix) with ESMTP for ; Tue, 5 Nov 2019 11:11:08 +0000 (UTC) Received: by mail-ot1-f66.google.com with SMTP id e17so8735895otk.6 for ; Tue, 05 Nov 2019 03:11:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5B6n8kH55VbZzEY+wjyqB8FdxqyxjbBetSMGjeJd+Zc=; b=UdD+cwSex9YqLUgmLDHvIdRuczHsP9I3go9ioWHKDeoQdh5OQ99sHfW3BLlN8Ff6HP 8R28ndXbv4hgtUQV3/XxhzEmvZkCXUzkhE0nYViO6ZMEk7CDLU4rpKAE9axwufvKNZ2L Kx71TrGgidPXzEKaXFxPZUZxJCOVqTCuO3XKhbrW8m1S3dQoWQyeL9HeqUeGocDTO96c GLAbijQEINerKedL2FS1iiDHMprU1EIBzoiZUUp4y/nrTCgy5U2hsY0NqNmMiV4n+JxJ LBqAP7ZrAjvi71F1SEMk5eMUKwrNp2pP6nFBEM+hnoQhCe+kfAdOXmA+RphJ9rpfJEGn OU9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5B6n8kH55VbZzEY+wjyqB8FdxqyxjbBetSMGjeJd+Zc=; b=Gc/WnF4uZVdhn6OdnlEbdbPug8TJV0iRc4Y3zMy+YRYvDMmXwHf3ThwtwDLUG6zARq u7APz5H3dkzbYAxnmk/gigwymhHU0iKzPjAerUEYAzyu2/jayIrhLa7gWxHlOmuJSrQH I7kn7azqJPO4y1A7N93k8obleWanT180qDfkbs/7l4Uqdg9xca+lhU6YPktR76FnU9Vw zPF8w22nMPplutC+47qw4pShPvXyobHgCA0lxM+2YTZU72w/h6Qg2YKr4OXiHF5Ahf0+ hW8fURngY9GYDfluJZyL3cOYnpgZYj9GehNeMiLbqe6SCRHcKTTIWG19zKeF9qYTu5au F3YQ== X-Gm-Message-State: APjAAAWUmjfxbK/Y8AinLy7EWbcWGZ/1eutlu5sYmxwq/uiDmIc01Eqt zpdWsLudxqpCzKB0kI8gEjyiMl37plPt0iRtfxvlPQ== X-Google-Smtp-Source: APXvYqxrBEp73s3i3gThYRaC4jrcPXypBj9UG+5da1MVtjpJ1hGe+870E3FHigNLsj9J2v5KeREkaOCk1yn4bHYd3bs= X-Received: by 2002:a9d:82e:: with SMTP id 43mr22800110oty.23.1572952267599; Tue, 05 Nov 2019 03:11:07 -0800 (PST) MIME-Version: 1.0 References: <20191104142745.14722-1-elver@google.com> <20191104164717.GE20975@paulmck-ThinkPad-P72> <20191104194658.GK20975@paulmck-ThinkPad-P72> In-Reply-To: <20191104194658.GK20975@paulmck-ThinkPad-P72> From: Marco Elver Date: Tue, 5 Nov 2019 12:10:56 +0100 Message-ID: Subject: Re: [PATCH v3 0/9] Add Kernel Concurrency Sanitizer (KCSAN) To: "Paul E. McKenney" Cc: LKMM Maintainers -- Akira Yokosawa , Alan Stern , Alexander Potapenko , Andrea Parri , Andrey Konovalov , Andy Lutomirski , Ard Biesheuvel , Arnd Bergmann , Boqun Feng , Borislav Petkov , Daniel Axtens , Daniel Lustig , Dave Hansen , David Howells , Dmitry Vyukov , "H. Peter Anvin" , Ingo Molnar , Jade Alglave , Joel Fernandes , Jonathan Corbet , Josh Poimboeuf , Luc Maranget , Mark Rutland , Nicholas Piggin , Peter Zijlstra , Thomas Gleixner , Will Deacon , kasan-dev , linux-arch , "open list:DOCUMENTATION" , linux-efi@vger.kernel.org, Linux Kbuild mailing list , LKML , Linux Memory Management List , "the arch/x86 maintainers" Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 4 Nov 2019 at 20:47, Paul E. McKenney wrote: > > On Mon, Nov 04, 2019 at 07:41:30PM +0100, Marco Elver wrote: > > On Mon, 4 Nov 2019 at 17:47, Paul E. McKenney wrote: > > > > > > On Mon, Nov 04, 2019 at 03:27:36PM +0100, Marco Elver wrote: > > > > This is the patch-series for the Kernel Concurrency Sanitizer (KCSAN). > > > > KCSAN is a sampling watchpoint-based data-race detector. More details > > > > are included in Documentation/dev-tools/kcsan.rst. This patch-series > > > > only enables KCSAN for x86, but we expect adding support for other > > > > architectures is relatively straightforward (we are aware of > > > > experimental ARM64 and POWER support). > > > > > > > > To gather early feedback, we announced KCSAN back in September, and > > > > have integrated the feedback where possible: > > > > http://lkml.kernel.org/r/CANpmjNPJ_bHjfLZCAPV23AXFfiPiyXXqqu72n6TgWzb2Gnu1eA@mail.gmail.com > > > > > > > > We want to point out and acknowledge the work surrounding the LKMM, > > > > including several articles that motivate why data-races are dangerous > > > > [1, 2], justifying a data-race detector such as KCSAN. > > > > [1] https://lwn.net/Articles/793253/ > > > > [2] https://lwn.net/Articles/799218/ > > > > > > > > The current list of known upstream fixes for data-races found by KCSAN > > > > can be found here: > > > > https://github.com/google/ktsan/wiki/KCSAN#upstream-fixes-of-data-races-found-by-kcsan > > > > > > Making this more accessible to more people seems like a good thing. > > > So, for the series: > > > > > > Acked-by: Paul E. McKenney > > > > Much appreciated. Thanks, Paul! > > > > Any suggestions which tree this could eventually land in? > > I would guess that Dmitry might have some suggestions. I checked and we're both unclear what the most obvious tree to land in is (the other sanitizers are mm related, which KCSAN is not). One suggestion that comes to my mind is for KCSAN to go through the same tree (rcu?) as the LKMM due to their inherent relationship. Would that make most sense? Thanks, -- Marco > > > > > > Changelog > > > > --------- > > > > v3: > > > > * Major changes: > > > > - Add microbenchmark. > > > > - Add instruction watchpoint skip randomization. > > > > - Refactor API and core runtime fast-path and slow-path. Compared to > > > > the previous version, with a default config and benchmarked using the > > > > added microbenchmark, this version is 3.8x faster. > > > > - Make __tsan_unaligned __alias of generic accesses. > > > > - Rename kcsan_{begin,end}_atomic -> > > > > kcsan_{nestable,flat}_atomic_{begin,end} > > > > - For filter list in debugfs.c use kmalloc+krealloc instead of > > > > kvmalloc. > > > > - Split Documentation into separate patch. > > > > > > > > v2: http://lkml.kernel.org/r/20191017141305.146193-1-elver@google.com > > > > * Major changes: > > > > - Replace kcsan_check_access(.., {true, false}) with > > > > kcsan_check_{read,write}. > > > > - Change atomic-instrumented.h to use __atomic_check_{read,write}. > > > > - Use common struct kcsan_ctx in task_struct and for per-CPU interrupt > > > > contexts. > > > > > > > > v1: http://lkml.kernel.org/r/20191016083959.186860-1-elver@google.com > > > > > > > > Marco Elver (9): > > > > kcsan: Add Kernel Concurrency Sanitizer infrastructure > > > > kcsan: Add Documentation entry in dev-tools > > > > objtool, kcsan: Add KCSAN runtime functions to whitelist > > > > build, kcsan: Add KCSAN build exceptions > > > > seqlock, kcsan: Add annotations for KCSAN > > > > seqlock: Require WRITE_ONCE surrounding raw_seqcount_barrier > > > > asm-generic, kcsan: Add KCSAN instrumentation for bitops > > > > locking/atomics, kcsan: Add KCSAN instrumentation > > > > x86, kcsan: Enable KCSAN for x86 > > > > > > > > Documentation/dev-tools/index.rst | 1 + > > > > Documentation/dev-tools/kcsan.rst | 217 +++++++++ > > > > MAINTAINERS | 11 + > > > > Makefile | 3 +- > > > > arch/x86/Kconfig | 1 + > > > > arch/x86/boot/Makefile | 2 + > > > > arch/x86/boot/compressed/Makefile | 2 + > > > > arch/x86/entry/vdso/Makefile | 3 + > > > > arch/x86/include/asm/bitops.h | 6 +- > > > > arch/x86/kernel/Makefile | 7 + > > > > arch/x86/kernel/cpu/Makefile | 3 + > > > > arch/x86/lib/Makefile | 4 + > > > > arch/x86/mm/Makefile | 3 + > > > > arch/x86/purgatory/Makefile | 2 + > > > > arch/x86/realmode/Makefile | 3 + > > > > arch/x86/realmode/rm/Makefile | 3 + > > > > drivers/firmware/efi/libstub/Makefile | 2 + > > > > include/asm-generic/atomic-instrumented.h | 393 +++++++-------- > > > > include/asm-generic/bitops-instrumented.h | 18 + > > > > include/linux/compiler-clang.h | 9 + > > > > include/linux/compiler-gcc.h | 7 + > > > > include/linux/compiler.h | 35 +- > > > > include/linux/kcsan-checks.h | 97 ++++ > > > > include/linux/kcsan.h | 115 +++++ > > > > include/linux/sched.h | 4 + > > > > include/linux/seqlock.h | 51 +- > > > > init/init_task.c | 8 + > > > > init/main.c | 2 + > > > > kernel/Makefile | 6 + > > > > kernel/kcsan/Makefile | 11 + > > > > kernel/kcsan/atomic.h | 27 ++ > > > > kernel/kcsan/core.c | 560 ++++++++++++++++++++++ > > > > kernel/kcsan/debugfs.c | 275 +++++++++++ > > > > kernel/kcsan/encoding.h | 94 ++++ > > > > kernel/kcsan/kcsan.h | 131 +++++ > > > > kernel/kcsan/report.c | 306 ++++++++++++ > > > > kernel/kcsan/test.c | 121 +++++ > > > > kernel/sched/Makefile | 6 + > > > > lib/Kconfig.debug | 2 + > > > > lib/Kconfig.kcsan | 119 +++++ > > > > lib/Makefile | 3 + > > > > mm/Makefile | 8 + > > > > scripts/Makefile.kcsan | 6 + > > > > scripts/Makefile.lib | 10 + > > > > scripts/atomic/gen-atomic-instrumented.sh | 17 +- > > > > tools/objtool/check.c | 18 + > > > > 46 files changed, 2526 insertions(+), 206 deletions(-) > > > > create mode 100644 Documentation/dev-tools/kcsan.rst > > > > create mode 100644 include/linux/kcsan-checks.h > > > > create mode 100644 include/linux/kcsan.h > > > > create mode 100644 kernel/kcsan/Makefile > > > > create mode 100644 kernel/kcsan/atomic.h > > > > create mode 100644 kernel/kcsan/core.c > > > > create mode 100644 kernel/kcsan/debugfs.c > > > > create mode 100644 kernel/kcsan/encoding.h > > > > create mode 100644 kernel/kcsan/kcsan.h > > > > create mode 100644 kernel/kcsan/report.c > > > > create mode 100644 kernel/kcsan/test.c > > > > create mode 100644 lib/Kconfig.kcsan > > > > create mode 100644 scripts/Makefile.kcsan > > > > > > > > -- > > > > 2.24.0.rc1.363.gb1bccd3e3d-goog > > > > > > > > > > -- > > > You received this message because you are subscribed to the Google Groups "kasan-dev" group. > > > To unsubscribe from this group and stop receiving emails from it, send an email to kasan-dev+unsubscribe@googlegroups.com. > > > To view this discussion on the web visit https://groups.google.com/d/msgid/kasan-dev/20191104164717.GE20975%40paulmck-ThinkPad-P72. > > -- > You received this message because you are subscribed to the Google Groups "kasan-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an email to kasan-dev+unsubscribe@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/kasan-dev/20191104194658.GK20975%40paulmck-ThinkPad-P72.