From: Shu Ming <sming56@gmail.com>
To: Xunlei Pang <xlpang@linux.alibaba.com>
Cc: Vlastimil Babka <vbabka@suse.cz>,
Christoph Lameter <cl@linux.com>,
Wen Yang <wenyang@linux.alibaba.com>,
Roman Gushchin <guro@fb.com>, Pekka Enberg <penberg@gmail.com>,
Konstantin Khlebnikov <khlebnikov@yandex-team.ru>,
David Rientjes <rientjes@google.com>,
LKML <linux-kernel@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>
Subject: Re: [PATCH v2 3/3] mm/slub: Use percpu partial free counter
Date: Tue, 2 Mar 2021 13:56:46 +0800 [thread overview]
Message-ID: <CANt8P=uyGF_QvpcW+BkHzPvdo-5cdH7OXw2Ozt1gFuXHmdizwQ@mail.gmail.com> (raw)
In-Reply-To: <1597061872-58724-4-git-send-email-xlpang@linux.alibaba.com>
On Mon, Aug 10, 2020 at 8:22 PM Xunlei Pang <xlpang@linux.alibaba.com> wrote:
> static inline void
> @@ -2429,12 +2439,12 @@ static unsigned long partial_counter(struct kmem_cache_node *n,
> unsigned long ret = 0;
>
> if (item == PARTIAL_FREE) {
> - ret = atomic_long_read(&n->partial_free_objs);
> + ret = get_partial_free(n);
> } else if (item == PARTIAL_TOTAL) {
> ret = atomic_long_read(&n->partial_total_objs);
> } else if (item == PARTIAL_INUSE) {
> ret = atomic_long_read(&n->partial_total_objs) -
> - atomic_long_read(&n->partial_free_objs);
> + get_partial_free(n);
Is it "ret = get_partial_free(n);" above?
> if ((long)ret < 0)
> ret = 0;
> }
next prev parent reply other threads:[~2021-03-02 5:57 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-10 12:17 [PATCH v2 0/3] mm/slub: Fix count_partial() problem Xunlei Pang
2020-08-10 12:17 ` [PATCH v2 1/3] mm/slub: Introduce two counters for partial objects Xunlei Pang
2020-08-10 12:17 ` [PATCH v2 2/3] mm/slub: Get rid of count_partial() Xunlei Pang
2020-08-10 12:17 ` [PATCH v2 3/3] mm/slub: Use percpu partial free counter Xunlei Pang
2021-03-02 5:56 ` Shu Ming [this message]
2021-03-02 9:14 ` Christoph Lameter
2021-03-03 13:46 ` Xunlei Pang
2021-03-03 14:26 ` Matthew Wilcox
2021-03-03 19:15 ` Christoph Lameter
2021-03-03 19:30 ` Matthew Wilcox
2021-03-03 19:55 ` Christoph Lameter
2021-03-03 20:16 ` Matthew Wilcox
2020-08-20 14:02 ` [PATCH v2 0/3] mm/slub: Fix count_partial() problem Pekka Enberg
2020-08-24 10:04 ` xunlei
2021-03-01 10:31 ` Shu Ming
2021-03-03 13:34 ` Xunlei Pang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANt8P=uyGF_QvpcW+BkHzPvdo-5cdH7OXw2Ozt1gFuXHmdizwQ@mail.gmail.com' \
--to=sming56@gmail.com \
--cc=cl@linux.com \
--cc=guro@fb.com \
--cc=khlebnikov@yandex-team.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@gmail.com \
--cc=rientjes@google.com \
--cc=vbabka@suse.cz \
--cc=wenyang@linux.alibaba.com \
--cc=xlpang@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).