From: Arjun Roy <arjunroy@google.com>
To: Shakeel Butt <shakeelb@google.com>
Cc: Arjun Roy <arjunroy.kdev@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
David Miller <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Cgroups <cgroups@vger.kernel.org>, Linux MM <linux-mm@kvack.org>,
Eric Dumazet <edumazet@google.com>,
Soheil Hassas Yeganeh <soheil@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Michal Hocko <mhocko@kernel.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Yang Shi <shy828301@gmail.com>, Roman Gushchin <guro@fb.com>
Subject: Re: [mm, net-next v2] mm: net: memcg accounting for TCP rx zerocopy
Date: Mon, 15 Mar 2021 23:22:27 -0700 [thread overview]
Message-ID: <CAOFY-A0v2BEwRinhPXspjL_3dvyw2kDSyzQgUiJxc+P-3OLP8g@mail.gmail.com> (raw)
In-Reply-To: <CALvZod7hgtdrN_KXD_5JdB2vzJzTc8tVz_5YFN53-xZjpHLLRw@mail.gmail.com>
On Mon, Mar 15, 2021 at 9:29 PM Shakeel Butt <shakeelb@google.com> wrote:
>
> On Mon, Mar 15, 2021 at 9:20 PM Arjun Roy <arjunroy@google.com> wrote:
> >
> [...]
> > >
> >
> > Apologies for the spam - looks like I forgot to rebase the first time
> > I sent this out.
> >
> > Actually, on a related note, it's not 100% clear to me whether this
> > patch (which in its current form, applies to net-next) should instead
> > be based on the mm branch - but the most recent (clean) checkout of mm
> > fails to build for me so net-next for now.
> >
>
> It is due to "mm: page-writeback: simplify memcg handling in
> test_clear_page_writeback()" patch in the mm tree. You would need to
> reintroduce the lock_page_memcg() which returns the memcg and make
> __unlock_page_memcg() non-static.
To clarify, Shakeel - the tag "tag: v5.12-rc2-mmots-2021-03-11-21-49"
fails to build on a clean checkout, without this patch, due to a
compilation failure in mm/shmem.c, for reference:
https://pastebin.com/raw/12eSGdGD
(and that's why I'm basing this patch off of net-next in this email).
-Arjun
next prev parent reply other threads:[~2021-03-16 6:22 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-16 4:16 [mm, net-next v2] mm: net: memcg accounting for TCP rx zerocopy Arjun Roy
2021-03-16 4:20 ` Arjun Roy
2021-03-16 4:29 ` Shakeel Butt
2021-03-16 6:22 ` Arjun Roy [this message]
2021-03-16 6:28 ` Arjun Roy
2021-03-16 21:02 ` Jakub Kicinski
2021-03-16 10:26 ` Johannes Weiner
2021-03-17 6:05 ` Arjun Roy
2021-03-17 22:12 ` Johannes Weiner
2021-03-22 21:35 ` Arjun Roy
2021-03-23 17:01 ` Johannes Weiner
2021-03-23 18:42 ` Arjun Roy
2021-03-24 18:25 ` Shakeel Butt
2021-03-24 22:21 ` Arjun Roy
2021-03-23 14:34 ` Michal Hocko
2021-03-23 18:47 ` Arjun Roy
2021-03-24 9:12 ` Michal Hocko
2021-03-24 20:39 ` Arjun Roy
2021-03-24 20:53 ` Shakeel Butt
2021-03-24 21:56 ` Michal Hocko
2021-03-24 21:24 ` Johannes Weiner
2021-03-24 22:49 ` Arjun Roy
2021-03-25 9:02 ` Michal Hocko
2021-03-25 16:47 ` Johannes Weiner
2021-03-25 17:50 ` Michal Hocko
-- strict thread matches above, loose matches on Subject: below --
2021-03-16 1:30 Arjun Roy
2021-03-18 3:21 ` Andrew Morton
2021-03-22 21:19 ` Arjun Roy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOFY-A0v2BEwRinhPXspjL_3dvyw2kDSyzQgUiJxc+P-3OLP8g@mail.gmail.com \
--to=arjunroy@google.com \
--cc=akpm@linux-foundation.org \
--cc=arjunroy.kdev@gmail.com \
--cc=cgroups@vger.kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shakeelb@google.com \
--cc=shy828301@gmail.com \
--cc=soheil@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).