From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08CC4C433E0 for ; Tue, 16 Mar 2021 06:28:22 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8D81C6520E for ; Tue, 16 Mar 2021 06:28:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8D81C6520E Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 237AE6B006C; Tue, 16 Mar 2021 02:28:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1E92B6B006E; Tue, 16 Mar 2021 02:28:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0616E6B0070; Tue, 16 Mar 2021 02:28:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0008.hostedemail.com [216.40.44.8]) by kanga.kvack.org (Postfix) with ESMTP id DA8A36B006C for ; Tue, 16 Mar 2021 02:28:20 -0400 (EDT) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 9573F640E for ; Tue, 16 Mar 2021 06:28:20 +0000 (UTC) X-FDA: 77924757960.26.8B020E4 Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) by imf28.hostedemail.com (Postfix) with ESMTP id 1CD282000382 for ; Tue, 16 Mar 2021 06:28:20 +0000 (UTC) Received: by mail-pj1-f45.google.com with SMTP id w8so10082143pjf.4 for ; Mon, 15 Mar 2021 23:28:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=4WMa4KM9fFev9zFfsGZL1hiGSj5b5g6V/60hVlEG9mE=; b=kAcbsz0zpfOoY1eq9SS2Tf5iLTvNd1+VONP1B0IXfqyjIamQ/j4B1AZIk/Xej3gtPO /BIJKwsMq09EtFF7rSx60NCz32pq4F0iifIm3ZnTszJ8+Cy3SC2zDrosJPDUfBgiRw8J WpHLksEvtnHLRgydskPl8+p21gRkN5lpSngr9qTO7Q67KinGKssJ587CCWB7ML6nMOgG WWUtoUx5a3pcObz5xEiO2hZ+De9kS5PVLrzFUU+crJuLFukr7fwGJFKRLugYMJrfpR1W hsEyw9ft7EZKEfo/EfK5YzaCP8Ub44Y9wBc5bjBOgUkNshjVw2aRLRBYfanaGFjrEYd7 4B7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4WMa4KM9fFev9zFfsGZL1hiGSj5b5g6V/60hVlEG9mE=; b=UFvvqRCjQC/LZdzRi+df0RwrTLSzgHcSFxGMz3eLbXRgBWukC8kGgigGVuVFX3kAvq /pn5Th7ZVuDz0TgyTyzHkig3pTQtR5npKKxMjhShF4PNURmDpKS1kQRi8mt0lMDxDqKa gIvITsaP70+aI0bI2IUbdugtBc2INz2xZIsALOEIENQJHFaf80TX2hPp5LECPnKC4mz/ R0+1mQ9F+tPVVO/3wCjLh73TyBCH044CQg8EbNpceKwGQSIVZgZke31g4RGE9/UD2ZP9 jsV7BLvVv9h4iiqSxNAk3beG7FxuFtMRwrwZmPTYw+ummNa3el5d8w74562UgJ7Qer6S Jixg== X-Gm-Message-State: AOAM530qwhIlGgV8wdJslXxitEsxfHklvpEV6Y5UYdPTQzW8bw/tvDnl dXJwjiun3SMOOeaRSO4cjdMZBXgYL1DI9LwSpmf7sA== X-Google-Smtp-Source: ABdhPJyQeEVtil+ykZ9O1pMASi07bihZgTaks/id/aa2GLXNnBC00VJaT6BjOTBO+Z04YQfBs6wAhZp8/sOeI97bcWg= X-Received: by 2002:a17:90a:ce0d:: with SMTP id f13mr3175085pju.85.1615876099037; Mon, 15 Mar 2021 23:28:19 -0700 (PDT) MIME-Version: 1.0 References: <20210316041645.144249-1-arjunroy.kdev@gmail.com> In-Reply-To: From: Arjun Roy Date: Mon, 15 Mar 2021 23:28:08 -0700 Message-ID: Subject: Re: [mm, net-next v2] mm: net: memcg accounting for TCP rx zerocopy To: Shakeel Butt Cc: Arjun Roy , Andrew Morton , David Miller , netdev , Linux Kernel Mailing List , Cgroups , Linux MM , Eric Dumazet , Soheil Hassas Yeganeh , Jakub Kicinski , Michal Hocko , Johannes Weiner , Yang Shi , Roman Gushchin Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: y9o4x9syqxjnxn8dq7rhunyxm6byd83j X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 1CD282000382 Received-SPF: none (google.com>: No applicable sender policy available) receiver=imf28; identity=mailfrom; envelope-from=""; helo=mail-pj1-f45.google.com; client-ip=209.85.216.45 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1615876100-261204 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Mar 15, 2021 at 11:22 PM Arjun Roy wrote: > > On Mon, Mar 15, 2021 at 9:29 PM Shakeel Butt wrote: > > > > On Mon, Mar 15, 2021 at 9:20 PM Arjun Roy wrote: > > > > > [...] > > > > > > > > > > Apologies for the spam - looks like I forgot to rebase the first time > > > I sent this out. > > > > > > Actually, on a related note, it's not 100% clear to me whether this > > > patch (which in its current form, applies to net-next) should instead > > > be based on the mm branch - but the most recent (clean) checkout of mm > > > fails to build for me so net-next for now. > > > > > > > It is due to "mm: page-writeback: simplify memcg handling in > > test_clear_page_writeback()" patch in the mm tree. You would need to > > reintroduce the lock_page_memcg() which returns the memcg and make > > __unlock_page_memcg() non-static. > > To clarify, Shakeel - the tag "tag: v5.12-rc2-mmots-2021-03-11-21-49" > fails to build on a clean checkout, without this patch, due to a > compilation failure in mm/shmem.c, for reference: > https://pastebin.com/raw/12eSGdGD > (and that's why I'm basing this patch off of net-next in this email). > > -Arjun Another seeming anomaly - the patch sent out passes scripts/checkpatch.pl but netdev/checkpatch finds plenty of actionable fixes here: https://patchwork.kernel.org/project/netdevbpf/patch/20210316041645.144249-1-arjunroy.kdev@gmail.com/ Is netdev using some other automated checker instead of scripts/checkpatch.pl? -Arjun