From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15C78C433E0 for ; Wed, 1 Jul 2020 15:48:08 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D1C782077D for ; Wed, 1 Jul 2020 15:48:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="oQSWsOf/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D1C782077D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 7F1758D0051; Wed, 1 Jul 2020 11:48:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7A15C8D0047; Wed, 1 Jul 2020 11:48:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6DEB28D0051; Wed, 1 Jul 2020 11:48:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0169.hostedemail.com [216.40.44.169]) by kanga.kvack.org (Postfix) with ESMTP id 580268D0047 for ; Wed, 1 Jul 2020 11:48:07 -0400 (EDT) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 0DDB3824805A for ; Wed, 1 Jul 2020 15:48:07 +0000 (UTC) X-FDA: 76989938214.22.base79_121006f26e81 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin22.hostedemail.com (Postfix) with ESMTP id C861918038E67 for ; Wed, 1 Jul 2020 15:48:06 +0000 (UTC) X-HE-Tag: base79_121006f26e81 X-Filterd-Recvd-Size: 3298 Received: from mail-qt1-f196.google.com (mail-qt1-f196.google.com [209.85.160.196]) by imf40.hostedemail.com (Postfix) with ESMTP for ; Wed, 1 Jul 2020 15:48:06 +0000 (UTC) Received: by mail-qt1-f196.google.com with SMTP id u17so18799520qtq.1 for ; Wed, 01 Jul 2020 08:48:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Y3UG6n4VQTWs/fVAEC23K75oC0/jZOs6aLjdj63Uxno=; b=oQSWsOf/T5UzRtiIn/lNWCaW/KhRq8xjHwk59ePKewTKUhZMfgmTNF6njX74f4hMvz USb8L0oFLPxSDDndo9bhrVIwZo1ofBIPHN+XjdErSdY8WalNPpdMOXg+bQFq7wIe2xPD WpImlaSDJ41rpEMTktvIyoUCWwS5HcPoGZIptMIHIhNAKYIp02UkL4p3FGMPHbeERdRP H35Qz1qaT6pQGx4ukxf0fTtUhiqIvTtwYjwUZeR+lULBEL72Q8IETWV/1UO/lK1HE2Tv trC5gSzDDY7LmJGXHiuujrvjrDQir2AABWRJFkCa+bUO1rm7tcPLbIj5Agt+KBRrldCl PhLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Y3UG6n4VQTWs/fVAEC23K75oC0/jZOs6aLjdj63Uxno=; b=elG+rceVzBtK90TlIx+1uQg0eqrhosRW/NC9p2y+6V/FNZhfSf+ZkctcYBWVVNiHLJ chM5BxfmJea1wfGDBLM9YK+UBjJPyFI8HaqvE1ZwCTntFhSrcSP/wxwNgLIsjLRVQRg6 DKghUpl/5S34lK9q5H0Znk8KBCKxFhaR9+CBiYYnIdWk6qx8wSCqikznAWNQebkzC8+x gucSyQ7WPEc2pm1qR4N4XrUQkb6e0d7ngmbeckgRCB1nI0/NjcO1gqtf+gB5nkxk3EdP IxxHW6I0w9YvXI/MqNSkPa7BHFB+UhcNKV/TU/41RHKrtB2n8XLCRqwVlEZgZg/wdir0 yKgQ== X-Gm-Message-State: AOAM530G97eqFQD/0ODhI4ecrjdJhEE9jog/UnK8l16SAyVNoLKM/cN7 1YaRnWjlUCbQMJEMyEsXMb3/kPNCxOENTCqVMAo= X-Google-Smtp-Source: ABdhPJzG+NgpLm234JldFRSOkVa1TeVz2nuMLMoKwcltaNvy5eWEqgwv82PYelA3uGPLvgzV66TTdA6WYUCpBI6knNA= X-Received: by 2002:ac8:4b5b:: with SMTP id e27mr25036652qts.96.1593618485897; Wed, 01 Jul 2020 08:48:05 -0700 (PDT) MIME-Version: 1.0 References: <20200701151645.GA26223@lilong> In-Reply-To: <20200701151645.GA26223@lilong> From: Pekka Enberg Date: Wed, 1 Jul 2020 18:47:49 +0300 Message-ID: Subject: Re: [PATCH v3] mm, slab: Check GFP_SLAB_BUG_MASK before alloc_pages in kmalloc_order To: Long Li Cc: willy@infradead.org, Christoph Lameter , David Rientjes , Joonsoo Kim , Andrew Morton , "linux-mm@kvack.org" , LKML Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: C861918038E67 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jul 1, 2020 at 6:19 PM Long Li wrote: > > kmalloc cannot allocate memory from HIGHMEM. Allocating large amounts > of memory currently bypasses the check and will simply leak the memory > when page_address() returns NULL. To fix this, factor the > GFP_SLAB_BUG_MASK check out of slab & slub, and call it from > kmalloc_order() as well. In order to make the code clear, the warning > message is put in one place. > > Signed-off-by: Long Li Reviewed-by: Pekka Enberg