From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED3E1C433E2 for ; Tue, 14 Jul 2020 15:12:33 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id AAB392076C for ; Tue, 14 Jul 2020 15:12:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QgbqGoc3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AAB392076C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 28DA86B0005; Tue, 14 Jul 2020 11:12:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2650A6B0006; Tue, 14 Jul 2020 11:12:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 153D56B0007; Tue, 14 Jul 2020 11:12:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0074.hostedemail.com [216.40.44.74]) by kanga.kvack.org (Postfix) with ESMTP id 0101F6B0005 for ; Tue, 14 Jul 2020 11:12:32 -0400 (EDT) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id AB4DD181AC9B6 for ; Tue, 14 Jul 2020 15:12:32 +0000 (UTC) X-FDA: 77037022944.30.dolls37_1a0fe6826ef1 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin30.hostedemail.com (Postfix) with ESMTP id 709FC180B3C83 for ; Tue, 14 Jul 2020 15:12:32 +0000 (UTC) X-HE-Tag: dolls37_1a0fe6826ef1 X-Filterd-Recvd-Size: 3737 Received: from mail-qk1-f196.google.com (mail-qk1-f196.google.com [209.85.222.196]) by imf31.hostedemail.com (Postfix) with ESMTP for ; Tue, 14 Jul 2020 15:12:31 +0000 (UTC) Received: by mail-qk1-f196.google.com with SMTP id l6so15860839qkc.6 for ; Tue, 14 Jul 2020 08:12:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=lPY0nKFKw8Xh+fQpn89J/uEUcRoylDvAgOjS6f+f+YA=; b=QgbqGoc3EpeCC0EJeM1hRblC8I4e2KKabqrfFBqfPiCekpfex6JB6ojBptjaeR5lYx 7qcv0OgfQlF4wY8ZCtpvruDgEY4d4zNsTz4WEzqkqXG2HWP1505zVWJimhu2Cp23HF3c 7+1jWAUXqLrnbBNGiZT7ZQ6UzQNf3Dyiuxx2AMkf533qpm9IQJFd+M01+dA6XnJlLc3v P5WkGOuGmeRlLoI41BFWPrTLZcvgquh0fNAyvC0Gyv0xyTnmqBYB/sGWt98KPAQ4TPyL jF3UxOaUkgf6BKCI0tktLfbln5SINT+SNL9fgV05p4d+E/kX6Ljccd0MHzn9v/T6pUxU II5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=lPY0nKFKw8Xh+fQpn89J/uEUcRoylDvAgOjS6f+f+YA=; b=T3kxoPJJ4tQUkW3e6Wa1aL+Z4FR8GAKI8tEFvN9r1ExP08e4IZmh8XEIOt9AnEkNtR MY5/LhEmdCJWzCq/8Xp6omIIT/7Hr1KzIovRrJsYXonqqxNxD4aNXlZ7hMhtLNH+1Ycj Qzn218EzrtDYkkw5MAEYtPDqKGN8B+DEhOnjuj0CYnm5V3bhg1126GhnnNjUYxO9Zt6q ssaaBMATCU7WFNqwk7MMLhsipXn79cLnAg2cjO8w3C33dT5U8VLe0n1729vWzyC9Q7m5 7jjmctDiFIFDIakSAtmbxHSPvVeeF6wd2E1mt3mvOZnN/exmqey1TahnzxvAxkXr3R48 MzXA== X-Gm-Message-State: AOAM533co61SGUenkLanLeTZ2gOYzZnAmS58Cs+JtNQYcz6dkTYJ9J3Q rrUUyN5EgXb3wKsxMfnib7OyWGQFd05bcc05Hac= X-Google-Smtp-Source: ABdhPJzp5y71Cl5iC+1fgXXPFCvds9tatsYOKuM+mUZJNt5qRokpYb5gzBe8SFxB8DRBH0l7+0ZV2wEUCJJ8kaNUyfQ= X-Received: by 2002:a37:4289:: with SMTP id p131mr4968739qka.28.1594739551071; Tue, 14 Jul 2020 08:12:31 -0700 (PDT) MIME-Version: 1.0 References: <20200626223625.199813-1-peterx@redhat.com> In-Reply-To: From: Pekka Enberg Date: Tue, 14 Jul 2020 18:12:14 +0300 Message-ID: Subject: Re: [PATCH 17/26] mm/riscv: Use general page fault accounting To: Palmer Dabbelt Cc: Peter Xu , "linux-mm@kvack.org" , LKML , Andrew Morton , Linus Torvalds , Gerald Schaefer , Andrea Arcangeli , Will Deacon , Michael Ellerman , Paul Walmsley , Albert Ou , linux-riscv Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 709FC180B3C83 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Palmer, On Sat, Jul 11, 2020 at 10:43 PM Palmer Dabbelt wrote: > This still slightly changes the accounting numbers, but I don't think it does > so in a way that's meaningful enough to care about. SIGBUS is the only one > that might happen frequently enough to notice, I doubt anyone cares about > whether faults are accounted for during OOM. What do you mean? AFAICT, this patch _fixes_ the accounting to be correct on page fault restarts. I sent a patch to fix this up some time ago, but of course this generic solutions is better: http://lists.infradead.org/pipermail/linux-riscv/2020-June/000775.html - Pekka