From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C862C3567B for ; Mon, 24 Feb 2020 06:51:47 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1D79920714 for ; Mon, 24 Feb 2020 06:51:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="r+VFg7nl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1D79920714 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 849CB6B0005; Mon, 24 Feb 2020 01:51:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7FA836B0006; Mon, 24 Feb 2020 01:51:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 711EE6B0007; Mon, 24 Feb 2020 01:51:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0078.hostedemail.com [216.40.44.78]) by kanga.kvack.org (Postfix) with ESMTP id 5AFB06B0005 for ; Mon, 24 Feb 2020 01:51:46 -0500 (EST) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id F1AA9824556B for ; Mon, 24 Feb 2020 06:51:45 +0000 (UTC) X-FDA: 76524100212.10.order74_f5fe9d524249 X-HE-Tag: order74_f5fe9d524249 X-Filterd-Recvd-Size: 5847 Received: from mail-il1-f193.google.com (mail-il1-f193.google.com [209.85.166.193]) by imf44.hostedemail.com (Postfix) with ESMTP for ; Mon, 24 Feb 2020 06:51:45 +0000 (UTC) Received: by mail-il1-f193.google.com with SMTP id l4so6846383ilj.1 for ; Sun, 23 Feb 2020 22:51:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=t9K0w7u9UlRucKDFse4Bnnz0TkvNHleyC4BCsa1RzrM=; b=r+VFg7nlYKjyz4ZE6FQLUysVX5WdvVgRm6WOY41svQjomwf0VXKN3PmH633+9Q2lI7 rsia25DTZrqeYZUzqIELM0ZPs9xk9RrR1zjvbYreOc8hFnT5pfTuk8+8G3Z3+v2ZKC0g 3+Uda6+pEZA47fwhjkuOGRiku+Z0p1HVHFqY54Xx1Th+9vhrJ/qnxiXHBlAOCapn0INg RIE2UbkfnEyHpOODwAIrese+8kda1BNJDaAH9nXkUn/5vKE97Jm60mZbshpHsb7scDjj jyhU99uHJmzK+BJhulAarPgiDvpWVdszTMddDibKFZjPLLrV/FmHpUdCY0G0wQkUeVCh oz1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=t9K0w7u9UlRucKDFse4Bnnz0TkvNHleyC4BCsa1RzrM=; b=Dvgt0aMLKZ3mXSW1mZ0u2FvkKHRogTl3KzPoLQ7GP5SRRqAMfdKxWJmBXsI/kWlU0i dX6y0eih7KAOb1o+66Bv0GWX/g/CfMnz5AyV7hiy4DhXVji1o+CMlN+YTK9Mn0vKtE9n zys8kLCiFIsQfjzVNc36xnCoqQHXzGFFnD9Yk8le8VUZFs6ZGmOOZpcfHtkB9bTHVSYT c8AsJTGdC7HzUDCLkNuMWBw6W5pxWyQc82HvRjrIc229jZWhtNtZRpQizbGjNAc554IX KalZPiXWuH6XI7MPURS0E23RJaiYP/Lfmphwcn4EQtUgajdTJ9coqn9U2dr5mA+mmRfy 2tHA== X-Gm-Message-State: APjAAAWuQ8j+pHYruChewqJaftgIkND8xnWLflT3Xrm1FlqT46PgmACK 8l9cpGMjj7NlOc2hq2a6Q+wr150BQAzBz99Z8LY= X-Google-Smtp-Source: APXvYqx+mUK6hh9BaSPGa0Msc1oHfQvPgztYvcYPrv+S9n6RraKbcSZyrnA+OcHji1IbgLT+tKjr35qmWcvjk1TYbOw= X-Received: by 2002:a92:d7c1:: with SMTP id g1mr59552764ilq.192.1582527104859; Sun, 23 Feb 2020 22:51:44 -0800 (PST) MIME-Version: 1.0 References: <20200221032720.33893-1-alastair@au1.ibm.com> <240fbefc6275ac0a6f2aa68715b3b73b0e7a8310.camel@au1.ibm.com> <20200224043750.GM24185@bombadil.infradead.org> <83034494d5c3da1fa63b172e844f85d0fec7910a.camel@au1.ibm.com> In-Reply-To: <83034494d5c3da1fa63b172e844f85d0fec7910a.camel@au1.ibm.com> From: "Oliver O'Halloran" Date: Mon, 24 Feb 2020 17:51:33 +1100 Message-ID: Subject: Re: [PATCH v3 00/27] Add support for OpenCAPI Persistent Memory devices To: "Alastair D'Silva" Cc: Matthew Wilcox , Dan Williams , "Aneesh Kumar K . V" , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Frederic Barrat , Andrew Donnellan , Arnd Bergmann , Greg Kroah-Hartman , Vishal Verma , Dave Jiang , Ira Weiny , Andrew Morton , Mauro Carvalho Chehab , "David S. Miller" , Rob Herring , Anton Blanchard , Krzysztof Kozlowski , Mahesh Salgaonkar , Madhavan Srinivasan , =?UTF-8?Q?C=C3=A9dric_Le_Goater?= , Anju T Sudhakar , Hari Bathini , Thomas Gleixner , Greg Kurz , Nicholas Piggin , Masahiro Yamada , Alexey Kardashevskiy , Linux Kernel Mailing List , linuxppc-dev , linux-nvdimm , Linux MM Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Feb 24, 2020 at 3:43 PM Alastair D'Silva wrote: > > On Sun, 2020-02-23 at 20:37 -0800, Matthew Wilcox wrote: > > On Mon, Feb 24, 2020 at 03:34:07PM +1100, Alastair D'Silva wrote: > > > V3: > > > - Rebase against next/next-20200220 > > > - Move driver to arch/powerpc/platforms/powernv, we now expect > > > this > > > driver to go upstream via the powerpc tree > > > > That's rather the opposite direction of normal; mostly drivers live > > under > > drivers/ and not in arch/. It's easier for drivers to get overlooked > > when doing tree-wide changes if they're hiding. > > This is true, however, given that it was not all that desirable to have > it under drivers/nvdimm, it's sister driver (for the same hardware) is > also under arch, and that we don't expect this driver to be used on any > platform other than powernv, we think this was the most reasonable > place to put it. Historically powernv specific platform drivers go in their respective subsystem trees rather than in arch/ and I'd prefer we kept it that way. When I added the papr_scm driver I put it in the pseries platform directory because most of the pseries paravirt code lives there for some reason; I don't know why. Luckily for me that followed the same model that Dan used when he put the NFIT driver in drivers/acpi/ and the libnvdimm core in drivers/nvdimm/ so we didn't have anything to argue about. However, as Matthew pointed out, it is at odds with how most subsystems operate. Is there any particular reason we're doing things this way or should we think about moving libnvdimm users to drivers/nvdimm/? Oliver