From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3246CC54EE9 for ; Sun, 18 Sep 2022 23:54:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 813B1940007; Sun, 18 Sep 2022 19:54:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7C3056B0075; Sun, 18 Sep 2022 19:54:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6637F940007; Sun, 18 Sep 2022 19:54:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 57CBB6B0072 for ; Sun, 18 Sep 2022 19:54:19 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 1DDBAC107A for ; Sun, 18 Sep 2022 23:54:19 +0000 (UTC) X-FDA: 79926862638.16.01FB7A9 Received: from mail-vs1-f44.google.com (mail-vs1-f44.google.com [209.85.217.44]) by imf03.hostedemail.com (Postfix) with ESMTP id CD1F42009F for ; Sun, 18 Sep 2022 23:54:18 +0000 (UTC) Received: by mail-vs1-f44.google.com with SMTP id h1so28273339vsr.11 for ; Sun, 18 Sep 2022 16:54:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=qNztOkYNUD1TNAuHzzGk17qN8mf2kAw6DraP60eErg4=; b=qwB5T+zhMpJBZNPw/FItC0uv1gshVLutmNsRE/P7MZTyZZqYitoCzAqzrx2rZ4NaTq bvQc4BGmIe5ssHzZU79mSNoSPBOqgjoBCCVDmzAJYn333u8A4snQxPLOO+F7ARq0BdKK msDH5foYi0LAj8QGiZoZ5o5nePUTUcOfMwPYOR1nRWfW9sGVfjOrE0t0CfiIQbB8pHGr B+zfX+zB/jKQVl75S2rROo2RON3XIOZeG1atoQo1qkJg+zC/n/+jepdVv2n9XCMXju8E IC2xuvNeXuek4dufrkCDI+DDsQ5spr19vwmNJCJw+BvCxJTyZTkrPWzElBzs0ZAYL2jg hHpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=qNztOkYNUD1TNAuHzzGk17qN8mf2kAw6DraP60eErg4=; b=AV6kZ04SiUDjJ8PTDkCIZAnmZ6nJv8eFX6q8vd6a9QWR8ZlUrtLEnSOGWChfQzKsOg O6WAzS9HNgsX0Ut33Gl9NEQ245eGF/q+GXit2pwZrNv1xXDuTsOTEalNj9ao9y1QADn0 HSnEn7rLUWjLWsGywY6UqWTNq3ogFHMVzHNN3ex2jcv4aAJuRCd/p68Ui7JXWcZBSFG2 c8Xb6CQAFEGHlaoJftGauXf9ORsjnwUR3wHQ+47mJOnwl2BeBD76Rl/npyWcsYerGTZj siaPyN1AYGGdLBGIDnAfEOl9dy0W6yv9gR3+CilwZNHHo5Ein2ApgNMJtS5ndQ78smW5 Dr8g== X-Gm-Message-State: ACrzQf0IY7NwcOrOK3n9DVQi7K6PLtsCwjRhIHkA0Po1vAIeKEuLKQbb zjrHUQ+d9lTV/YSWODt0uOGJUYg5rqfAJpJ3eex1aw== X-Google-Smtp-Source: AMsMyM5MQfnMr7TwjMki/ovxwciPStymX5lycFQr6uMx5ioqX8DoHBmrqbv/rSI4iDt4nTCh9EnurNQPXXAhz+tshC8= X-Received: by 2002:a05:6102:3309:b0:39a:e5eb:8508 with SMTP id v9-20020a056102330900b0039ae5eb8508mr1969170vsc.65.1663545257919; Sun, 18 Sep 2022 16:54:17 -0700 (PDT) MIME-Version: 1.0 References: <20220918204755.3135720-1-yuzhao@google.com> <20220918204755.3135720-3-yuzhao@google.com> <20220918164758.33759617e769197ea70a2870@linux-foundation.org> In-Reply-To: <20220918164758.33759617e769197ea70a2870@linux-foundation.org> From: Yu Zhao Date: Sun, 18 Sep 2022 17:53:41 -0600 Message-ID: Subject: Re: [PATCH v14-fix 03/11] mm: multi-gen LRU: warn on !ptep_test_and_clear_young() To: Andrew Morton Cc: Linux-MM , Nadav Amit Content-Type: text/plain; charset="UTF-8" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663545258; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qNztOkYNUD1TNAuHzzGk17qN8mf2kAw6DraP60eErg4=; b=leHp1/Vr7fhSfWEV2v5iLakbAwlBBnsvoxTX0yVYLIMJsCaJLvUUpnA4yIf5cDCsL5HSuv U3j+OYTg9fvjymzslE9tXYW3KTD/dgiypIfm4kbNEh2sU2uIO2/GkgKE6ZzhAZEo4r9kje 1fmt7fPsMEgOCHtGZUj5f1AJybFuFD4= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=qwB5T+zh; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf03.hostedemail.com: domain of yuzhao@google.com designates 209.85.217.44 as permitted sender) smtp.mailfrom=yuzhao@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663545258; a=rsa-sha256; cv=none; b=OnV2rcxA6E560C26tUpm4/EJK3S44MlU1FAVWMIQC86h96uIeaG9uxf/oGbKqOnP6qNDBl Xs+o8riMoAyVIHGKy/VT1H+MgherpXntkSL/8WhIdCe2zMawEWdosgfvU6owYv7fmTsEmQ iaD9Mfsb2sUqJt4kXdyG9jYMlAJy32s= X-Stat-Signature: 9jpupomn7cbw7ine1gu5nkwnbu4s3nge X-Rspamd-Queue-Id: CD1F42009F Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=qwB5T+zh; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf03.hostedemail.com: domain of yuzhao@google.com designates 209.85.217.44 as permitted sender) smtp.mailfrom=yuzhao@google.com X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1663545258-660390 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Sep 18, 2022 at 5:48 PM Andrew Morton wrote: > > On Sun, 18 Sep 2022 14:47:47 -0600 Yu Zhao wrote: > > > Link: https://lore.kernel.org/r/0F7CF2A7-F671-4196-B8FD-F35E9556391B@gmail.com/ > > Suggested-by: Nadav Amit > > Signed-off-by: Yu Zhao > > --- > > mm/vmscan.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/mm/vmscan.c b/mm/vmscan.c > > index 5c4d9d0867ec..629518813b59 100644 > > --- a/mm/vmscan.c > > +++ b/mm/vmscan.c > > @@ -3904,7 +3904,7 @@ static bool walk_pte_range(pmd_t *pmd, unsigned long start, unsigned long end, > > continue; > > > > if (!ptep_test_and_clear_young(args->vma, addr, pte + i)) > > - continue; > > + VM_WARN_ON_ONCE(true); > > > > young++; > > walk->mm_stats[MM_LEAF_YOUNG]++; > > @@ -4637,7 +4637,7 @@ void lru_gen_look_around(struct page_vma_mapped_walk *pvmw) > > continue; > > > > if (!ptep_test_and_clear_young(pvmw->vma, addr, pte + i)) > > - continue; > > + VM_WARN_ON_ONCE(true); > > > > This is a functional change? More than the Subject: describes. No, since ptep_test_and_clear_young() shouldn't fail here. We are under the PTL and ascertained (a few lines above) pte_young() is true. Neither the h/w nor another thread can clear the accessed bit under us.