From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC852C433EF for ; Thu, 14 Apr 2022 07:40:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 597A46B0073; Thu, 14 Apr 2022 03:40:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5461B6B0074; Thu, 14 Apr 2022 03:40:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 434C76B0075; Thu, 14 Apr 2022 03:40:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.28]) by kanga.kvack.org (Postfix) with ESMTP id 340D66B0073 for ; Thu, 14 Apr 2022 03:40:27 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 0B0BC20B42 for ; Thu, 14 Apr 2022 07:40:27 +0000 (UTC) X-FDA: 79354686894.01.19523FF Received: from mail-ua1-f52.google.com (mail-ua1-f52.google.com [209.85.222.52]) by imf13.hostedemail.com (Postfix) with ESMTP id 9EEAD20005 for ; Thu, 14 Apr 2022 07:40:26 +0000 (UTC) Received: by mail-ua1-f52.google.com with SMTP id y2so1443660uaq.5 for ; Thu, 14 Apr 2022 00:40:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=B+yelAQ9lNFMI5hOufKWMSWgyc6a2oTLMaNPif+dSo4=; b=Ijl0UlJLuQJNxeS+00+kEK00vT7ArQW3/qBUuWGouccrXcnwKXAWw0Bf/7Eh7QqqNl D9EqRcrZPWLUghmFk7OiLXimrH+3hNIl3Nz6tMFqxCoU4NG/2Cca8TRQJoEinJjqrPVN BNhVX8kqdEbC/l/gXB5MLjfZLSZE26oc/XdL5Gaw+YSUNUKXIfz92WIE/2WS6TilxEn3 d93AMeRD/WQjDbeEGPLL2MyJeEpnV5oLnlnyn8hfNxgms2NWblSSh4LFMyYDaCBCZDPu wyIv8asE4KzL4NwYWC+49wpSHFnOalpjBQu4vyHiDXzPal4tRoAVp+PTCi5fSm/rbxcB j/Dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=B+yelAQ9lNFMI5hOufKWMSWgyc6a2oTLMaNPif+dSo4=; b=zWaFaE1AKk1QHRhGQDhS33bjAHMCWI8V/wS4A4M2UboUygEO4zQ3PbzcNyAYWbg7xT MxJhVrTgowhWrqHgTt6v6Uu2qr98r1xyFnoeq1Hc1yvGUpa0kGO4wBlu3wtesRGiHM4D 6mwLsaXJ1XGdoDxVWyE3sT1DRo7rgAoVQncU079KMZc4xIKHXIALUH7bYAoBsxzB6Wv/ 1xGjQX2FkWkDSocCDBn3GhoNywaAj3dFn9QB6XpQCdzfumBmABItlkdbR4Fa7if3u84m CvV0ne9EV1hKvCkL+ZwXiQMC+mhJxFn2+MH5qqm7Dip6j/tznkiuku29o4TisczlarFR wHlw== X-Gm-Message-State: AOAM532HYcL6be2y9g0IHl3gh7/WHwxuLZaz9LBD00+GEh3Mf60zH8Ds FRPYMZPinpOosF1zvddNxS1OXTt1r46JWnO1Di6vyA== X-Google-Smtp-Source: ABdhPJwsuKEakZkW6AxrgqVK3TOMuqurXvhoD6CAwsnkFCY887FYnTbTSEXVRqQWTzwHH0e4AL4Fl1q1VwslrqlmPWo= X-Received: by 2002:ab0:77d5:0:b0:352:42d7:88c2 with SMTP id y21-20020ab077d5000000b0035242d788c2mr450693uar.1.1649922025781; Thu, 14 Apr 2022 00:40:25 -0700 (PDT) MIME-Version: 1.0 References: <20220404143501.2016403-1-Liam.Howlett@oracle.com> <20220413235051.3a4eb7c86d31656c7aea250c@linux-foundation.org> In-Reply-To: <20220413235051.3a4eb7c86d31656c7aea250c@linux-foundation.org> From: Yu Zhao Date: Thu, 14 Apr 2022 01:39:49 -0600 Message-ID: Subject: Re: [PATCH v7 00/70] Introducing the Maple Tree To: Andrew Morton Cc: Liam Howlett , "maple-tree@lists.infradead.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: 631qaurspdgz11uz69eii1b635yhbbbs Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=Ijl0UlJL; spf=pass (imf13.hostedemail.com: domain of yuzhao@google.com designates 209.85.222.52 as permitted sender) smtp.mailfrom=yuzhao@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspam-User: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 9EEAD20005 X-HE-Tag: 1649922026-434944 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Apr 14, 2022 at 12:50 AM Andrew Morton wrote: > > On Mon, 4 Apr 2022 14:35:26 +0000 Liam Howlett wrote: > > > Please add this patch set to your branch. They are based on v5.18-rc1. > > Do we get a nice [0/n] cover letter telling us all about this? > > I have that all merged up and it compiles. > > https://lkml.kernel.org/r/20220402094550.129-1-lipeifeng@oppo.com and > https://lkml.kernel.org/r/20220412081014.399-1-lipeifeng@oppo.com are > disabled for now. > > Several patches were marked > > From: Liam > Signed-off-by: Matthew > Signed-off-by: Liam > > Which makes me wonder whether the attribution was correct. Please > double-check. > > I made a lame attempt to fix up mglru's get_next_vma(), and it probably > wants a revisit in the maple-tree world anyway. Please check this and > send me a better version ;) Thanks. This looks good to me. > --- a/mm/vmscan.c~mglru-vs-maple-tree > +++ a/mm/vmscan.c > @@ -3704,7 +3704,7 @@ static bool get_next_vma(struct mm_walk > > while (walk->vma) { > if (next >= walk->vma->vm_end) { > - walk->vma = walk->vma->vm_next; > + walk->vma = find_vma(walk->mm, walk->vma->vm_end); > continue; > } > > @@ -3712,7 +3712,7 @@ static bool get_next_vma(struct mm_walk > return false; > > if (should_skip_vma(walk->vma->vm_start, walk->vma->vm_end, walk)) { > - walk->vma = walk->vma->vm_next; > + walk->vma = find_vma(walk->mm, walk->vma->vm_end); > continue; > } > > @@ -4062,7 +4062,7 @@ static void walk_mm(struct lruvec *lruve > /* the caller might be holding the lock for write */ > if (mmap_read_trylock(mm)) { > unsigned long start = walk->next_addr; > - unsigned long end = mm->highest_vm_end; > + unsigned long end = TASK_SIZE; > > err = walk_page_range(mm, start, end, &mm_walk_ops, walk); > > > I flung a tree up at > git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mmtemp containing > mglru and mapletree and a few other things. Could the mglru and > mapletree people please runtime test it, send any fixes? Will do.