From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 990B1ECAAD3 for ; Sat, 17 Sep 2022 08:25:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B29528D0002; Sat, 17 Sep 2022 04:25:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AD7578D0001; Sat, 17 Sep 2022 04:25:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9C6308D0002; Sat, 17 Sep 2022 04:25:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 8DFBE8D0001 for ; Sat, 17 Sep 2022 04:25:22 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 22143A04F9 for ; Sat, 17 Sep 2022 08:25:22 +0000 (UTC) X-FDA: 79920892884.24.56AA5D7 Received: from mail-vs1-f53.google.com (mail-vs1-f53.google.com [209.85.217.53]) by imf05.hostedemail.com (Postfix) with ESMTP id BFF1D1000B4 for ; Sat, 17 Sep 2022 08:25:21 +0000 (UTC) Received: by mail-vs1-f53.google.com with SMTP id j7so19578226vsr.13 for ; Sat, 17 Sep 2022 01:25:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=OWnkPdXKu3Vra2dQWOvgwi58h1KBjnOZlFX9hnEdd7Q=; b=JDr1TzcMbmAMAChokHfQnOl3YbvJYwLwo4eptnMbgpTg/AvbiP1G/E0uB0hL1E/PKB j7z6kL3QPv7tJzN852LdOY3wvt42yG8KffAy5/xPRAr9YM/uEfaQRlhYtA0WEu2DbNiN sEs1lgKpTB6hT9tb0LB3p0LAhSApEeicFFB28aTUzGMtSG8tmP12xmnrI7Ra+GS52/tL Bh+u3T9SPc5zJRZyuKabce5hzwOcVSKCFR5lG5jGOS8KCJgt3hQOIDqiWFvUAI1MxKS7 ON5v0tC6kiOOuvIiijapd8QDhTtzVaiAU5e1H6lIT/Q00JIvz9SgaB/W6MIHNGvb8S90 Za0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=OWnkPdXKu3Vra2dQWOvgwi58h1KBjnOZlFX9hnEdd7Q=; b=BTaxWoUufEq1sMi+ythAmMiRG94pGpLzPqA0jJAStQO1/i7UmxmWchinUXftXZACFh kKVsI+VMxeFgeXvEUnWS4G2CfjIfI/O+7kWIlnYjPSP1VkwFvR2mcr+aGp7cEvpinux7 Xh5C7gVtqy4oofiu7ZmvsmLFZk9UxFKmA5Rrh86/nRlE3h0fTMjg+MwudEP7Jfm4mFTI tC+KV+exRGmi152uS96KpMMn7m30ihnHmiod2twyfgS5plNgkm/Lv69+/BNnlg4J0/jU hTAWtvW44nnVe2s1uXTKyw7ut0oX2wJyru5U9DfgPKeln51gCBrNnP2iwW+IK/DtctVG jWEw== X-Gm-Message-State: ACrzQf1yLq301Z1GzZ+mLmj5Q3wspAT6pPoob7GViBSwppLcHrv5nsvv zrONvIKhaTRxWNQFZi9bt62y+Z31EzOQd4Ach4502w== X-Google-Smtp-Source: AMsMyM5tw7tey7pw+h3W7lbyoEHyV4uKxGVlol1rnMiFY9PpvXjI3oFhOU2gjjg24sbixaCFvbqa0KVVN2Tnyf7401w= X-Received: by 2002:a05:6102:3309:b0:39a:e5eb:8508 with SMTP id v9-20020a056102330900b0039ae5eb8508mr123939vsc.65.1663403120873; Sat, 17 Sep 2022 01:25:20 -0700 (PDT) MIME-Version: 1.0 References: <20220906194824.2110408-1-Liam.Howlett@oracle.com> <20220911172051.ff5faed962c365e203790137@linux-foundation.org> In-Reply-To: From: Yu Zhao Date: Sat, 17 Sep 2022 02:24:44 -0600 Message-ID: Subject: Re: [PATCH v14 00/70] Introducing the Maple Tree To: Liam Howlett Cc: "maple-tree@lists.infradead.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Andrew Morton Content-Type: text/plain; charset="UTF-8" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663403121; a=rsa-sha256; cv=none; b=vYVn2AAVGLXBO7WQEoTDOq1HLmEJ58lHCGRfanjZi2958xsB+HT17NHnC3Il7Cm7mGQqng UFnel5pYuvzp4YMm7I/un2sbapZ7VJkvddIU+u+FX977zwoLiMYbUtsw/4EXVnXsllcwlL c0EuqO/9pNMb9WdfNWbRHjDUDXVGuA0= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=JDr1TzcM; spf=pass (imf05.hostedemail.com: domain of yuzhao@google.com designates 209.85.217.53 as permitted sender) smtp.mailfrom=yuzhao@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663403121; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OWnkPdXKu3Vra2dQWOvgwi58h1KBjnOZlFX9hnEdd7Q=; b=DXVy8P7MmVYjeQklH3SdMb5yUltWvssPbJn0ndkCxXC+ktKwijbw4f0EFV9JtA8xth0uit foShJMET6rOmVg08jkgTkQO89TDJocBDzipn8X4yScL15YhayHNMprCfjVGkMRA8nddsQ1 ZRnXrtD/ccqd51Av/DyE8N6BIZ8s1To= Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=JDr1TzcM; spf=pass (imf05.hostedemail.com: domain of yuzhao@google.com designates 209.85.217.53 as permitted sender) smtp.mailfrom=yuzhao@google.com; dmarc=pass (policy=reject) header.from=google.com X-Stat-Signature: 48g3hbiine47466qiuggna6jowzn58rb X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: BFF1D1000B4 X-HE-Tag: 1663403121-957694 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Sep 15, 2022 at 12:03 PM Yu Zhao wrote: > > On Sun, Sep 11, 2022 at 6:20 PM Andrew Morton wrote: > > > > On Tue, 6 Sep 2022 19:48:38 +0000 Liam Howlett wrote: > > > > > Patch series "Introducing the Maple Tree". > > > > I haven't seen any issues attributed to maple tree in 2+ weeks. Unless > > there be weighty objections, I plan to move this series into mm-stable > > soon after mglru is added. Perhaps a week from now. > > Tested-by: Yu Zhao > > stress/fuzzing: arm64, mips64, ppc64 and x86_64 > performance: arm64 (nodejs), mips64 (memcached), ppc64 (specjbb2015) > and x86_64 (mmtests) > boot: riscv64 > not covered: m68knommu and s390 (no hardware available) This should be easy to fix: ====================================================== WARNING: possible circular locking dependency detected 6.0.0-dbg-DEV #1 Tainted: G S O ------------------------------------------------------ stress-ng/21813 is trying to acquire lock: ffffffff9b043388 (fs_reclaim){+.+.}-{0:0}, at: kmem_cache_alloc_bulk+0x3f/0x460 but task is already holding lock: ffffa2a509f8d080 (&anon_vma->rwsem){++++}-{3:3}, at: do_brk_flags+0x19d/0x410 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&anon_vma->rwsem){++++}-{3:3}: down_read+0x3c/0x50 folio_lock_anon_vma_read+0x147/0x180 rmap_walk_anon+0x55/0x230 try_to_unmap+0x65/0xa0 shrink_folio_list+0x8c5/0x1c70 evict_folios+0x6af/0xb50 lru_gen_shrink_lruvec+0x1b6/0x430 shrink_lruvec+0xa7/0x470 shrink_node_memcgs+0x116/0x1f0 shrink_node+0xb4/0x2e0 balance_pgdat+0x3b9/0x710 kswapd+0x2b1/0x320 kthread+0xe5/0x100 ret_from_fork+0x1f/0x30 -> #0 (fs_reclaim){+.+.}-{0:0}: __lock_acquire+0x16f4/0x30c0 lock_acquire+0xb2/0x190 fs_reclaim_acquire+0x57/0xd0 kmem_cache_alloc_bulk+0x3f/0x460 mas_alloc_nodes+0x148/0x1e0 mas_nomem+0x45/0x90 mas_store_gfp+0xf3/0x160 do_brk_flags+0x1f2/0x410 __do_sys_brk+0x214/0x3b0 __x64_sys_brk+0x12/0x20 do_syscall_64+0x3d/0x80 entry_SYSCALL_64_after_hwframe+0x63/0xcd other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&anon_vma->rwsem); lock(fs_reclaim); lock(&anon_vma->rwsem); lock(fs_reclaim); *** DEADLOCK *** 2 locks held by stress-ng/21813: #0: ffffa285087f2a58 (&mm->mmap_lock#2){++++}-{3:3}, at: __do_sys_brk+0x98/0x3b0 #1: ffffa2a509f8d080 (&anon_vma->rwsem){++++}-{3:3}, at: do_brk_flags+0x19d/0x410