From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, HTML_MESSAGE,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C403C4338F for ; Sun, 8 Aug 2021 18:40:01 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D3A0260EBD for ; Sun, 8 Aug 2021 18:40:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D3A0260EBD Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 44F616B0071; Sun, 8 Aug 2021 14:40:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3FF766B0073; Sun, 8 Aug 2021 14:40:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2EE7F8D0002; Sun, 8 Aug 2021 14:40:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0156.hostedemail.com [216.40.44.156]) by kanga.kvack.org (Postfix) with ESMTP id 129626B0071 for ; Sun, 8 Aug 2021 14:40:00 -0400 (EDT) Received: from forelay.prod.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by fograve05.hostedemail.com (Postfix) with ESMTP id 15AAF18172B13 for ; Sun, 8 Aug 2021 17:20:48 +0000 (UTC) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id DD1E41F858 for ; Sun, 8 Aug 2021 17:20:44 +0000 (UTC) X-FDA: 78452578008.11.7617760 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) by imf19.hostedemail.com (Postfix) with ESMTP id 91389B011D66 for ; Sun, 8 Aug 2021 17:20:44 +0000 (UTC) Received: by mail-wm1-f47.google.com with SMTP id o11so2844176wms.0 for ; Sun, 08 Aug 2021 10:20:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=LEkDVnRNvWx8UcSyfRlppbZdly2KOZF1IPGaRBm/Jg8=; b=YoGZXSK5d6g26MKfWj9mP2PKq+2Gj0R3xN1z00prEVv0NJ0JBqedHYPdZgxThUNS0n DYnznidgw/6P+Vjr/CJaxStgjnrVKoSEyaEEe1haT4pI+EZdZHrD3+DDaZRdjqzb0gFw /1n2TnfMByucIPPGS8iNsBbl+PAXmoZuWSMaPWEEcmKTMB+T7Sl42hVpRM95BFxWP44j 8CnkZOTrbWkzoYCx0sadoBdRVbDUfEvABJMj75sISnd/+EC35gL8akhnE/YmdnCRDWTO aZ3YbXbi/Z9nAd7P7C+Ux+Uwwuk+svI0ocS8nWRmM+NV0ntbQfSM8SocCFsqpfiMsYND bz0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=LEkDVnRNvWx8UcSyfRlppbZdly2KOZF1IPGaRBm/Jg8=; b=AjemuQpigaQb3HG2CiHviBfIRPXA4sFos1fmnZB7ViTB5ByVC4JUf+tYZ888EoCLZ0 sHm1Nuo28ROlmjPl11EayzJtTfPH1uT4ZoxoVFY86AxBtd7xIlX5eQnRmFrLWDGQt5sd +r8GMTvGaVvEqGXp9G8z/uCGKSQiEP3EEXAd8U5gAAtDx+bl8EJsZ7bdPGUIVA/OrI8k F+Fk7L5NfvN1UYt/18ah6WVr0C0X3BoOf7mCkoUpbBAmR3DkTAlQJA3t5nDk6TEucVqG Q6AmlTzYAwhqqXq2C0q6NG32H+M0twcErRTB/YWlTfEEYeHp0I4gVs6reftTtarsyuF9 fQBw== X-Gm-Message-State: AOAM531XIJOAVZUG7UCqzeuWABbD1pCiDyYsbdwaB+6AkZ7K2B0/O+OG PyxlpGqT0+y03/Kfx96duGw9CX8faYUfLmJbp7cbig== X-Google-Smtp-Source: ABdhPJzW34PH32UeQ+s1dPEcxn+M9TbIzbZ9dSVwk4xVg9gIhQmwksO+gj8DQXqysgoLL6o/psbrXupw0rs5SJLsjTw= X-Received: by 2002:a05:600c:2049:: with SMTP id p9mr7087729wmg.37.1628443242032; Sun, 08 Aug 2021 10:20:42 -0700 (PDT) MIME-Version: 1.0 References: <20210731063938.1391602-1-yuzhao@google.com> <20210731063938.1391602-4-yuzhao@google.com> <20210804142729.iqtslnn3utvqgec3@box.shutemov.name> In-Reply-To: <20210804142729.iqtslnn3utvqgec3@box.shutemov.name> From: Yu Zhao Date: Sun, 8 Aug 2021 11:20:30 -0600 Message-ID: Subject: Re: [PATCH 3/3] mm: don't remap clean subpages when splitting isolated thp To: "Kirill A. Shutemov" Cc: Linux-MM , Andrew Morton , Hugh Dickins , "Kirill A . Shutemov" , Matthew Wilcox , Vlastimil Babka , Yang Shi , Zi Yan , linux-kernel , Shuang Zhai Content-Type: multipart/alternative; boundary="000000000000fb32a105c90f7cc4" Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=google.com header.s=20161025 header.b=YoGZXSK5; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf19.hostedemail.com: domain of yuzhao@google.com designates 209.85.128.47 as permitted sender) smtp.mailfrom=yuzhao@google.com X-Stat-Signature: 41xhfmiyy6p3bwn88fj1hbycyfitdffz X-Rspamd-Queue-Id: 91389B011D66 X-Rspamd-Server: rspam01 X-HE-Tag: 1628443244-940532 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --000000000000fb32a105c90f7cc4 Content-Type: text/plain; charset="UTF-8" On Wed, Aug 4, 2021 at 8:27 AM Kirill A. Shutemov wrote: > On Sat, Jul 31, 2021 at 12:39:38AM -0600, Yu Zhao wrote: > > @@ -267,13 +308,19 @@ static bool remove_migration_pte(struct page > *page, struct vm_area_struct *vma, > > * Get rid of all migration entries and replace them by > > * references to the indicated page. > > */ > > -void remove_migration_ptes(struct page *old, struct page *new, bool > locked) > > +void remove_migration_ptes(struct page *old, struct page *new, bool > locked, bool unmap_clean) > > { > > + struct rmap_walk_arg rmap_walk_arg = { > > + .page = old, > > + .unmap_clean = unmap_clean, > > + }; > > struct rmap_walk_control rwc = { > > .rmap_one = remove_migration_pte, > > - .arg = old, > > + .arg = &rmap_walk_arg, > > }; > > 'old' pointer has few low always-zero bit :P > Will do. Thanks. --000000000000fb32a105c90f7cc4 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

On Wed, Aug 4, 2021 at 8:27 AM Kirill A. = Shutemov <kirill@shutemov.name> wrote:
On= Sat, Jul 31, 2021 at 12:39:38AM -0600, Yu Zhao wrote:
> @@ -267,13 +308,19 @@ static bool remove_migration_pte(struct page *pa= ge, struct vm_area_struct *vma,
>=C2=A0 =C2=A0* Get rid of all migration entries and replace them by
>=C2=A0 =C2=A0* references to the indicated page.
>=C2=A0 =C2=A0*/
> -void remove_migration_ptes(struct page *old, struct page *new, bool l= ocked)
> +void remove_migration_ptes(struct page *old, struct page *new, bool l= ocked, bool unmap_clean)
>=C2=A0 {
> +=C2=A0 =C2=A0 =C2=A0struct rmap_walk_arg rmap_walk_arg =3D {
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0.page =3D old,
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0.unmap_clean =3D unma= p_clean,
> +=C2=A0 =C2=A0 =C2=A0};
>=C2=A0 =C2=A0 =C2=A0 =C2=A0struct rmap_walk_control rwc =3D {
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0.rmap_one =3D re= move_migration_pte,
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0.arg =3D old,
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0.arg =3D &rmap_wa= lk_arg,
>=C2=A0 =C2=A0 =C2=A0 =C2=A0};

'old' pointer has few low always-zero bit :P
--000000000000fb32a105c90f7cc4--