From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C63C7C433F5 for ; Tue, 19 Apr 2022 21:59:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3952A6B0072; Tue, 19 Apr 2022 17:59:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 344986B0073; Tue, 19 Apr 2022 17:59:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1E5EB6B0074; Tue, 19 Apr 2022 17:59:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.a.hostedemail.com [64.99.140.24]) by kanga.kvack.org (Postfix) with ESMTP id 106B16B0072 for ; Tue, 19 Apr 2022 17:59:13 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id C8ECE6222A for ; Tue, 19 Apr 2022 21:59:12 +0000 (UTC) X-FDA: 79374994944.08.150579E Received: from mail-vk1-f178.google.com (mail-vk1-f178.google.com [209.85.221.178]) by imf27.hostedemail.com (Postfix) with ESMTP id 650E940008 for ; Tue, 19 Apr 2022 21:59:11 +0000 (UTC) Received: by mail-vk1-f178.google.com with SMTP id w128so8155949vkd.3 for ; Tue, 19 Apr 2022 14:59:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=VjKt+RtbR1k15kh1tqHX+ikjM6kJamgbyERntatiKfs=; b=LGj905/wmhK22s9AWhEYpxGIPBFA4gQKrEF/F5J77dAA2dtklqdI4oLRg9mFgkdTf0 qWaOWWalTRzHbrK60/AxZjAJ3wmRJf0GLbkwiihLlpCca8Z1iu9SPDMhAr6Y1p1jxLCI sihxCsymgrjPESVLGrdxmnszzoOCwZ2YO0sAcdV10BQiZlr6r7C/XHBP9rsbO1088jYS EVXUmrSHuOFpXGixSv+jvqRWSrfMPxyyusaLkJXvWslOL4zyYSMWgvTgbWz1l//PQizL QMCLKHrB3Wuq2rj9tQ+W2wDwryvxQNmOG8bgIapWtDgDJwu/qF2tHuW9mp2XietnLbqk v29w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=VjKt+RtbR1k15kh1tqHX+ikjM6kJamgbyERntatiKfs=; b=3wduaxbO1TVFnyxS/7ejdtsyfZf+ycgzAOD0fGwrmhfbHOJ5wpqMWY/wlMp3g8LmIF LoJt4l8c4hk56cDCCXuRn8YsZK7NpoTObAJzORfxIHGaPgong+zb4O2T/WD/c7+PXqOc dK57ApiJnBWTFTWW0KenojZDfMJeDIhLz7qGZT0ZPcgWcGdOu1RuQydCecDtaIlvghdw LmoKhEU/6Xb8s8H5S+AXhvVJoRAu4+JINly9GKSDqxgniltsLfXE6n/erUfi9PLAV0Bw eb10cyuYmwzlHtm8NH0/vSBMBMl4FbzoB0cQFPK7NylAjSRjEcisEJUar7QjcliAN8uY 3olA== X-Gm-Message-State: AOAM5323Tqvwu9txVvq9ICbcHm6Gro5ubprvzlyIQlpGwI1xZ1v5j77F sGfnbl6ftW8EOu89zdVqHri6RU+NZMa3sL9Jo0ucv4TZKP417eSq X-Google-Smtp-Source: ABdhPJx+yyAkCv1sGORw0XUgLueRk1MDSGFQYXOlBaTzkXslvEZrf0oSx+CfB7wu9ZU8D89RmpUVqLxw2WalgPdssnM= X-Received: by 2002:a1f:314b:0:b0:331:fff6:a89e with SMTP id x72-20020a1f314b000000b00331fff6a89emr5081691vkx.26.1650405551196; Tue, 19 Apr 2022 14:59:11 -0700 (PDT) MIME-Version: 1.0 References: <20220413235051.3a4eb7c86d31656c7aea250c@linux-foundation.org> <20220414135706.rcn7zr36s2hcd5re@revolver> <20220414171521.bgdvrirumd4atjhs@revolver> <20220414121911.8bb89fc3681b13af1566d79c@linux-foundation.org> <20220416010259.4gbz5hgvm2lgr3sj@revolver> <20220416151923.ig5zavuptjsufm3d@revolver> <20220419155055.qf52xpcftqb3r5nj@revolver> In-Reply-To: <20220419155055.qf52xpcftqb3r5nj@revolver> From: Yu Zhao Date: Tue, 19 Apr 2022 15:58:34 -0600 Message-ID: Subject: Re: [PATCH v7 00/70] Introducing the Maple Tree To: Liam Howlett Cc: Andrew Morton , "maple-tree@lists.infradead.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 650E940008 X-Rspam-User: Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b="LGj905/w"; spf=pass (imf27.hostedemail.com: domain of yuzhao@google.com designates 209.85.221.178 as permitted sender) smtp.mailfrom=yuzhao@google.com; dmarc=pass (policy=reject) header.from=google.com X-Stat-Signature: 59pe61o3t75wucoktn1op5rb1e9cbczq X-HE-Tag: 1650405551-649349 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Apr 19, 2022 at 9:51 AM Liam Howlett wrote: > > * Yu Zhao [220416 15:30]: > > On Sat, Apr 16, 2022 at 9:19 AM Liam Howlett wrote: > > > > > > > > > > > > How did you hit this issue? Just on boot? > > > > I was hoping this is known to you or you have something I can verify for you. > > > Thanks, yes. I believe that both crashes are the same root cause. The > cause is that I was not cleaning up after the kmem bulk allocation > failure on my side. Please test with this patch. Thanks. I applied this patch and hit a LOCKDEP and then a BUG_ON: lib/maple_tree.c:847 suspicious rcu_dereference_protected() usage! Call Trace: dump_stack_lvl+0x6c/0x9a dump_stack+0x10/0x12 lockdep_rcu_suspicious+0x12c/0x140 __mt_destroy+0x96/0xd0 exit_mmap+0x2a0/0x360 __mmput+0x34/0x100 mmput+0x2f/0x40 free_bprm+0x64/0xe0 kernel_execve+0x129/0x330 call_usermodehelper_exec_async+0xd8/0x130 ? proc_cap_handler+0x210/0x210 ret_from_fork+0x1f/0x30 BUG: unable to handle page fault for address: ffffa6072aff0060 RIP: 0010:mab_calc_split+0x103/0x1a0 Code: 29 c1 8b 86 64 02 00 00 0f b6 80 dc 7d a7 96 39 c1 7e 05 83 c3 01 eb 06 81 c3 ff 00 00 00 0f b6 c3 45 84 d2 74 3f 41 0f b6 ca <48> 83 bc ce 10 01 00 00 00 75 2d 41 83 c0 ff 41 39 c8 7e 20 0f b6 RSP: 0018:ffffa6072afef6d0 EFLAGS: 00010286 RAX: 0000000000000054 RBX: 0000000000000154 RCX: 00000000000000aa RDX: ffffa6072afef83f RSI: ffffa6072afefa00 RDI: ffffa6072afefe80 RBP: ffffa6072afef6e0 R08: 0000000000000010 R09: 00000000000000ff R10: 00000000000000aa R11: 0000000000000001 R12: 00000000000000ff R13: ffffa6072afefa00 R14: ffffa6072afef9c0 R15: 0000000000000008 FS: 0000000001d75340(0000) GS:ffff8a56bf980000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: ffffa6072aff0060 CR3: 00000004986ca002 CR4: 00000000001706e0 Call Trace: mas_spanning_rebalance+0x416/0x2060 mas_wr_store_entry+0xa6d/0xa80 mas_store_gfp+0xf6/0x170 do_mas_align_munmap+0x32b/0x5c0 do_mas_munmap+0xf3/0x110 __vm_munmap+0xd4/0x180 __x64_sys_munmap+0x1b/0x20 do_syscall_64+0x44/0xa0 $ ./scripts/faddr2line vmlinux mab_calc_split+0x103 mab_calc_split+0x103/0x1a0: mab_no_null_split at lib/maple_tree.c:1787 (inlined by) mab_calc_split at lib/maple_tree.c:1866