From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41CD6C433EF for ; Mon, 14 Feb 2022 12:27:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 844406B0078; Mon, 14 Feb 2022 07:27:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7F2E66B007B; Mon, 14 Feb 2022 07:27:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6E2706B007D; Mon, 14 Feb 2022 07:27:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0045.hostedemail.com [216.40.44.45]) by kanga.kvack.org (Postfix) with ESMTP id 608196B0078 for ; Mon, 14 Feb 2022 07:27:48 -0500 (EST) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 1DC628248D52 for ; Mon, 14 Feb 2022 12:27:48 +0000 (UTC) X-FDA: 79141311816.12.D3B0315 Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) by imf19.hostedemail.com (Postfix) with ESMTP id 9C9DA1A000F for ; Mon, 14 Feb 2022 12:27:47 +0000 (UTC) Received: by mail-pj1-f43.google.com with SMTP id qe15so14375099pjb.3 for ; Mon, 14 Feb 2022 04:27:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=Aghhqn/htRrgre499q7GMYfV+L/mSjjN9xcVM1cq6dg=; b=XErgwuDc89InSkoavSqC7d0/BsMzFKfrKw/0mFW8j+6ddgBCL3twFEGRrkcsuVCxNJ 6f7AK8RdnU/9orEm8YY3ui5S1JMDhIxiSSYDYJp3o7tZD+KkIHdNPtcNEk+EM9h7xHu5 3Kqto0Bkp31jdrAYNGQzqDU9H1QkafXOZH3MSzKfnSvkBmPfKFsYc6WHL9p4Og3uJH3l MifRV58zBRk30RCsYQaflChtnLu5tTnOt6O9Xt+nZvbBIOIR+mdwHj9jJs6fEtxeAGXn BVUQdx+iWoyrEvcc76hN3mV2oRUOk0nmJfejjh1/rFeiw2B33qEaMyJYDJZKrLmQmHIk hC3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Aghhqn/htRrgre499q7GMYfV+L/mSjjN9xcVM1cq6dg=; b=VXQKfa1JQfvELDtshg6iQ4sS/n8zK0exHTmjwC+rdxvQhxnGzSRsmG1DOOzpKM2H16 q42vcu2F9C9/AMVSEGpzaD6Wv4D/lmZo/6uo2nsLJvWBBKgHpKbASFVH0YJBusGzmi65 thOCD8LV2CP1bJNIQZovP0cUTuCQWdCxOflI1voetYTANYNQ7zsixzyNgzcwaRCv/lQp qETQMrX4uANfOlnXMYi+GWf6mmjiChOK6kwEgu8fsRDVyQMDuv0SvikMBfpU17RlcYAm R/k0etfgXFZkrbeRa0WBPPtMHw0vL4afwR9bXLcso+SFEXaPLISPe99rq6RzZyCDvH3I kC7A== X-Gm-Message-State: AOAM532rq0cLb2F2GtRWeREbc8E3hZF4aNV0wIhIv/kRcPFK/1IkbHwN hHe1oPRFrRVe+Re6V9o372lVgZ5WjjZE1rpptmxJ492acww= X-Google-Smtp-Source: ABdhPJxoUawAOkqG5aOxyr7G//l8I0SkzmVqjWbILht/my8+Ql8zBkSs1qsZ72CE3FQaKwCvzLBvL4N3ADCYfGw2giA= X-Received: by 2002:a17:902:ef44:: with SMTP id e4mr13770365plx.145.1644841666589; Mon, 14 Feb 2022 04:27:46 -0800 (PST) MIME-Version: 1.0 References: <202202120520.NbWJGvF2-lkp@intel.com> In-Reply-To: <202202120520.NbWJGvF2-lkp@intel.com> From: =?UTF-8?B?SmFuIETEhWJyb8Wb?= Date: Mon, 14 Feb 2022 13:27:35 +0100 Message-ID: Subject: Re: [linux-next:master 4897/5417] drivers/i2c/busses/i2c-designware-amdpsp.c:165:25: sparse: sparse: incorrect type in argument 1 (different address spaces) To: kernel test robot Cc: kbuild-all@lists.01.org, Linux Memory Management List , Wolfram Sang , Andy Shevchenko Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 9C9DA1A000F X-Stat-Signature: bjc6ekgmboawwt6xtk4fmpq4ctnff873 Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=semihalf-com.20210112.gappssmtp.com header.s=20210112 header.b=XErgwuDc; spf=none (imf19.hostedemail.com: domain of jsd@semihalf.com has no SPF policy when checking 209.85.216.43) smtp.mailfrom=jsd@semihalf.com; dmarc=none X-HE-Tag: 1644841667-471776 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: pt., 11 lut 2022 o 22:24 kernel test robot napisa=C5=82(a): > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.g= it master > head: 6d9bd4ad4ca08b1114e814c2c42383b8b13be631 > commit: 91560fe37f81ba8145427477a39cea88f4422385 [4897/5417] i2c: designw= are: Add AMD PSP I2C bus support > config: i386-allyesconfig (https://download.01.org/0day-ci/archive/202202= 12/202202120520.NbWJGvF2-lkp@intel.com/config) > compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 > reproduce: > # apt-get install sparse > # sparse version: v0.6.4-dirty > # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next= .git/commit/?id=3D91560fe37f81ba8145427477a39cea88f4422385 > git remote add linux-next https://git.kernel.org/pub/scm/linux/ke= rnel/git/next/linux-next.git > git fetch --no-tags linux-next master > git checkout 91560fe37f81ba8145427477a39cea88f4422385 > # save the config file to linux build tree > mkdir build_dir > make W=3D1 C=3D1 CF=3D'-fdiagnostic-prefix -D__CHECK_ENDIAN__' O= =3Dbuild_dir ARCH=3Di386 SHELL=3D/bin/bash drivers/i2c/busses/ > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > > > sparse warnings: (new ones prefixed by >>) > >> drivers/i2c/busses/i2c-designware-amdpsp.c:165:25: sparse: sparse: inc= orrect type in argument 1 (different address spaces) @@ expected void c= onst volatile [noderef] __iomem *addr @@ got unsigned int * @@ > drivers/i2c/busses/i2c-designware-amdpsp.c:165:25: sparse: expecte= d void const volatile [noderef] __iomem *addr > drivers/i2c/busses/i2c-designware-amdpsp.c:165:25: sparse: got uns= igned int * > > vim +165 drivers/i2c/busses/i2c-designware-amdpsp.c > > 159 > 160 /* Helper to verify status returned by PSP */ > 161 static int check_i2c_req_sts(struct psp_i2c_req *req) > 162 { > 163 int status; > 164 > > 165 status =3D readl(&req->hdr.status); Actually the above error points to something hidden but important - for reading from command-response buffer, we shouldn't use __iomem specifier (nor readl() family of functions) since this is normal memory - however updated by PSP. Thus I will refactor this to use 'volatile u32 *' and reading status by de-referencing pointer. Best Regards, Jan > 166 > 167 switch (status) { > 168 case PSP_I2C_REQ_STS_OK: > 169 return 0; > 170 case PSP_I2C_REQ_STS_BUS_BUSY: > 171 return -EBUSY; > 172 case PSP_I2C_REQ_STS_INV_PARAM: > 173 default: > 174 return -EIO; > 175 }; > 176 } > 177 > > --- > 0-DAY CI Kernel Test Service, Intel Corporation > https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org