From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36AB5C433E0 for ; Sat, 13 Jun 2020 04:44:53 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E34CD207D8 for ; Sat, 13 Jun 2020 04:44:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Lh03iQ9S" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E34CD207D8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 560078D00DD; Sat, 13 Jun 2020 00:44:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5111E8D00A0; Sat, 13 Jun 2020 00:44:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 426968D00DD; Sat, 13 Jun 2020 00:44:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0215.hostedemail.com [216.40.44.215]) by kanga.kvack.org (Postfix) with ESMTP id 2B0AD8D00A0 for ; Sat, 13 Jun 2020 00:44:52 -0400 (EDT) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id E6D17357B for ; Sat, 13 Jun 2020 04:44:51 +0000 (UTC) X-FDA: 76922948382.25.money33_2c162d326de2 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin25.hostedemail.com (Postfix) with ESMTP id BA5531804E3A0 for ; Sat, 13 Jun 2020 04:44:51 +0000 (UTC) X-HE-Tag: money33_2c162d326de2 X-Filterd-Recvd-Size: 4516 Received: from mail-il1-f196.google.com (mail-il1-f196.google.com [209.85.166.196]) by imf25.hostedemail.com (Postfix) with ESMTP for ; Sat, 13 Jun 2020 04:44:51 +0000 (UTC) Received: by mail-il1-f196.google.com with SMTP id j19so6517929ilk.9 for ; Fri, 12 Jun 2020 21:44:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=Cx2PDT4tTqeir+6bsWnKiVj//PIMKhOoR8f76t54cLM=; b=Lh03iQ9SAV6KYubI78RQKIFOTDE1FU3IAJ0dYQuP7q88IDiF/oe3MemPn9utySVmhx Wts5Z8K1vIlvqd1B2q8DSfo5p393zIPQgVpsIm9USwI1EJ1JUFHXor4NxjaGaoAHqun1 KE3mBwFyVhnXddH5okxKo4rMGtlRvGIXpu/uBzkbpDHEuAxMEnhltmSQ+7RurIKVXhGz VzwaRewUWZh7HPrmH91dbZ+69egx2gKv8RvJ3QTX6QTdXIeMwLfi9JTCU7HC1RR7a3wV Okj8vS1W8WxMTbwosmVRkh8FaMPo2+MhJJLKOz+hzAUSlqHtPIbmLJwKnzgce9jLbwfo y0ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=Cx2PDT4tTqeir+6bsWnKiVj//PIMKhOoR8f76t54cLM=; b=FcIR6YbVBrF+ehxP31/VWTBWOef0ii380qKPXWIBnDTISBk1pAPMHWVkzA8G9W7qMp 4vOulcvd7LH6GVEIToydP/OGFjssYsU5LcQeZvPEGe+ITuLPzmIkvZwzD/Zjj/hO7qc0 muF83EVJmNgHNlDdPz3csu0uFdzuUoOSKLfuRYJpR9gOzCm1CzByhB3Vz6nkgrDHqpae MZEoHRw/ZvECeIv3u/s/Cv7YJwWqcLVn0U94da6bSPsu7JD6txwIPF7UUSB4bTKUfaI3 5yVaNciR+G1/CtT/e5Xi5LMNTFDxCbKp+RFRxws4wGpiGDRm2+kcezRUBYvC6ryfIoFC FZPA== X-Gm-Message-State: AOAM530IORn2LLjbcHNOt3NSZBNe2tTLcWjUsrmQ4JWRukk0NQijc/Sz jbMSoE3jb5v1WLohBDq96actmhGLR/+eGzeFG1g= X-Google-Smtp-Source: ABdhPJzI4T4eSQMWpvx7OTzHdnAfKgH2WKNsN8xKJ+7TEAT0GR/60aVBUxhkosxWrXdRv3/fqPdvQzlQjzirTfwpwqQ= X-Received: by 2002:a92:c941:: with SMTP id i1mr14927825ilq.94.1592023490745; Fri, 12 Jun 2020 21:44:50 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:ac0:d54a:0:0:0:0:0 with HTTP; Fri, 12 Jun 2020 21:44:50 -0700 (PDT) In-Reply-To: References: From: youling 257 Date: Sat, 13 Jun 2020 12:44:50 +0800 Message-ID: Subject: Re: [PATCH v6 10/12] mmap locking API: rename mmap_sem to mmap_lock To: Michel Lespinasse Cc: "Liam R . Howlett" , Andrew Morton , Daniel Jordan , Davidlohr Bueso , Hugh Dickins , Jason Gunthorpe , Jerome Glisse , John Hubbard , Laurent Dufour , LKML , linux-mm , Peter Zijlstra , David Rientjes , Vlastimil Babka , Matthew Wilcox , Ying Han Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: BA5531804E3A0 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: today test linux kernel master branch, I have kernel/sys.c build error. can you make a fix patch and push to linus? 2020-06-04 16:38 GMT+08:00, Michel Lespinasse : > On Thu, Jun 4, 2020 at 1:16 AM youling 257 wrote: >> 2020-06-04 13:57 GMT+08:00, Michel Lespinasse : >> > However I would like more information about your report. Did you apply >> > the series yourself ? If so, what base tree did you apply it onto ? If >> > not, what tree did you use that already included the series ? >> >> I build linux next-20200603 tree have the kernel/sys.c error. > > Thanks for the info. > > The proper fix is to replace down_write(&mm->mmap_sem) with > mmap_write_lock(mm) and up_write(&mm->mmap_sem) with > mmap_write_unlock(mm) > > If you just needed a quick fix to get the tree to build, what you did > (replacing mmap_sem with mmap_lock) is also fine. > > Thanks again ! > > -- > Michel "Walken" Lespinasse > A program is never fully debugged until the last user dies. >