From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7625FC433E2 for ; Mon, 13 Jul 2020 15:42:55 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 39A0820773 for ; Mon, 13 Jul 2020 15:42:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=intel-com.20150623.gappssmtp.com header.i=@intel-com.20150623.gappssmtp.com header.b="shNHxqlE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 39A0820773 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id CDB678D0003; Mon, 13 Jul 2020 11:42:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C8B7C8D0002; Mon, 13 Jul 2020 11:42:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B7A478D0003; Mon, 13 Jul 2020 11:42:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0161.hostedemail.com [216.40.44.161]) by kanga.kvack.org (Postfix) with ESMTP id A03828D0002 for ; Mon, 13 Jul 2020 11:42:54 -0400 (EDT) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 0D7D51E18 for ; Mon, 13 Jul 2020 15:42:54 +0000 (UTC) X-FDA: 77033470668.11.slope87_02148af26ee9 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin11.hostedemail.com (Postfix) with ESMTP id D4B3E180F8B82 for ; Mon, 13 Jul 2020 15:42:53 +0000 (UTC) X-HE-Tag: slope87_02148af26ee9 X-Filterd-Recvd-Size: 4293 Received: from mail-ej1-f66.google.com (mail-ej1-f66.google.com [209.85.218.66]) by imf21.hostedemail.com (Postfix) with ESMTP for ; Mon, 13 Jul 2020 15:42:52 +0000 (UTC) Received: by mail-ej1-f66.google.com with SMTP id p20so17709851ejd.13 for ; Mon, 13 Jul 2020 08:42:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=KYHsayQ+qnaeJrGEqb3AbWD3OCs6eDEgmK0sEjz5stk=; b=shNHxqlEshcLM+d6HS5/rUuF/G7IfTpZe/gUMK2OQCtYZavKPmFx9lPmSy+8XWB0KK 35jBVVrUdNO+Jfvrrp+eIP/JvR08WY9U0DdkU6T89bTgCxQCuK1PVuWJIjGMTLjE8rE3 XTJ5PHCfIDj2m3E204SFtns5sNa6dcgofuJWbiwgwOmwi0NipOUB6QrkLZ+DoEueqmMB PgWCgNO4So36JTX6IgokxC3NYAKVD194ZFfivEOk1MU5Ch8Hq+JnhQK68aoXqc58zKh0 6H4qLbRrffd4vFYKWrXDmxbjRxZ7jEpY4zZCg4XrAX2YN8jpDHcMkBByyN832GpItPwM QGlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KYHsayQ+qnaeJrGEqb3AbWD3OCs6eDEgmK0sEjz5stk=; b=KDxK61mRR3XcIsIezmIyDZRmYmaGNVyNS8Gmq/CacbhU/XmLzhTs7UeR1EUhg+3aZT XJIEU9zbF4nZANPtbyuO65WoWrDGNPh54OUpQUOqHVQUA6MBWNxrWKNafeMQHO2Qp6JM Cd85LWZ+rsHG7xu4zI/Br5PwAraABCKpyiMFZl5QlhxLoTaY/83OxkEbvmO+GAX+5OL5 VdzuXFVpA6KwuQ/7v47IGB8SetDoldFKRb45DK/To4oyMtHv+gfwlvF+xKR4rMoApKGa 2eksmVpHHRPgq6Ghi6+2J35bB1rH0FFRhQvvs/+eND9K6VgP10mLAiZqdlTY6ggTpE53 xJ+g== X-Gm-Message-State: AOAM533g0CxWfJHYu4n7NBrP4k7R6p4ZTLP6Q3b8NufltY+C9TWbLsE2 ggKbz2LVmry66SBkqNfAGgh8I+Mc2PohEMM38H499A== X-Google-Smtp-Source: ABdhPJxUImaKchQhePlG2M01YtnBmwJfKXSrMtOhR08dhoQCgRWcxaVYGh90/4tQIBcAr8wpwsrZSqeoZAyg7POGAfM= X-Received: by 2002:a17:907:20af:: with SMTP id pw15mr393528ejb.204.1594654971733; Mon, 13 Jul 2020 08:42:51 -0700 (PDT) MIME-Version: 1.0 References: <159457116473.754248.7879464730875147365.stgit@dwillia2-desk3.amr.corp.intel.com> <159457120334.754248.12908401960465408733.stgit@dwillia2-desk3.amr.corp.intel.com> <20200713065801.GB11000@linux.ibm.com> In-Reply-To: <20200713065801.GB11000@linux.ibm.com> From: Dan Williams Date: Mon, 13 Jul 2020 08:42:41 -0700 Message-ID: Subject: Re: [PATCH v2 07/22] numa: Introduce a generic memory_add_physaddr_to_nid() To: Mike Rapoport Cc: linux-nvdimm , Jia He , Will Deacon , David Hildenbrand , Andrew Morton , Peter Zijlstra , Vishal L Verma , Dave Hansen , Ard Biesheuvel , Linux MM , Linux Kernel Mailing List , Linux ACPI , Christoph Hellwig , Joao Martins Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: D4B3E180F8B82 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Jul 12, 2020 at 11:58 PM Mike Rapoport wrote: > > Hi Dan, > > On Sun, Jul 12, 2020 at 09:26:43AM -0700, Dan Williams wrote: > > For architectures that opt into storing their numa data in memblock > > (only ARM64 currently), add a memblock generic way to interrogate that > > data for memory_add_physaddr_to_nid(). This requires ARCH_KEEP_MEMBLOCK > > to keep memblock text and data around after boot. > > I afraid we are too far from using memblock as a generic placeholder for > numa data. Although all architectures now have the numa info in > memblock, only arm64 uses memblock as the primary source of that data. > > I'd rather prefer Jia's solution [1] to have a weak default for > memory_add_physaddr_to_nid() and let architectures override it. I'm ok with that as long as we do the same for phys_to_target_node(). Will had the concern about adding a generic numa-info facility the last I tried this. I just don't see a practical way to get there in the near term.