From: Dan Williams <dan.j.williams@intel.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: David Rientjes <rientjes@google.com>,
Thomas Gleixner <tglx@linutronix.de>,
Wei Yang <richard.weiyang@gmail.com>,
kbuild test robot <lkp@intel.com>, X86 ML <x86@kernel.org>,
Linux MM <linux-mm@kvack.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86/numa_emulation: Fix uniform size build failure
Date: Fri, 6 Jul 2018 09:06:59 -0700 [thread overview]
Message-ID: <CAPcyv4gTVr7wiN5t4wUsqoWYpNajjj=77SEHC0Ew_gw0eDs93Q@mail.gmail.com> (raw)
In-Reply-To: <20180706100310.GB3483@gmail.com>
On Fri, Jul 6, 2018 at 3:03 AM, Ingo Molnar <mingo@kernel.org> wrote:
>
> * Dan Williams <dan.j.williams@intel.com> wrote:
>
>> > config attached.
>
> Doh, I intended to attach the config - attached now.
>
>> > These numa_emulation changes are a bit of a trainwreck - I'm removing both
>> > num_emulation commits from -tip for now, could you please resubmit a fixed/tested
>> > combo version?
>>
>> So I squashed the fix and let the 0day robot chew on it all day with no reports
>> as of yet. I just recompiled it here and am not seeing the link failure, can you
>> send me the details of the kernel config + gcc version that is failing?
>
> My guess: it's some weird Kconfig combination in this 32-bit config.
>
> Can you reproduce it with this config?
Yup, got it, thanks!
Turning on debuginfo I get:
arch/x86/mm/numa_emulation.o: In function `split_nodes_size_interleave_uniform':
arch/x86/mm/numa_emulation.c:257: undefined reference to `__udivdi3'
Previously we were dividing by a power-of-2 constant MAX_NUM_NODES,
and I believe in my builds the compiler was still deducing the
constant from the "nr_nodes = MAX_NUM_NODES" assignment. Fix inbound,
and I believe it will make it even clearer the difference between the
typical split and the new uniform split capability.
prev parent reply other threads:[~2018-07-06 16:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-03 21:00 [PATCH] x86/numa_emulation: Fix uniform size build failure Dan Williams
2018-07-05 8:24 ` Ingo Molnar
2018-07-06 2:55 ` Dan Williams
2018-07-06 10:03 ` Ingo Molnar
2018-07-06 16:06 ` Dan Williams [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPcyv4gTVr7wiN5t4wUsqoWYpNajjj=77SEHC0Ew_gw0eDs93Q@mail.gmail.com' \
--to=dan.j.williams@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
--cc=mingo@kernel.org \
--cc=richard.weiyang@gmail.com \
--cc=rientjes@google.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).