From: Dan Williams <dan.j.williams@intel.com>
To: Robin Murphy <robin.murphy@arm.com>
Cc: "Linux MM" <linux-mm@kvack.org>, "Jérôme Glisse" <jglisse@redhat.com>
Subject: Re: __HAVE_ARCH_PTE_DEVMAP - bug or intended behaviour?
Date: Wed, 31 Oct 2018 13:41:06 -0700 [thread overview]
Message-ID: <CAPcyv4gZyDWYiQ8DHwei+FQRL22LGo3Sr6a-9VPESnuRJy7jtg@mail.gmail.com> (raw)
In-Reply-To: <9cf5c075-c83f-0915-99ef-b2aa59eca685@arm.com>
On Wed, Oct 31, 2018 at 10:08 AM Robin Murphy <robin.murphy@arm.com> wrote:
>
> Hi mm folks,
>
> I'm looking at ZONE_DEVICE support for arm64, and trying to make sense
> of a build failure has led me down the rabbit hole of pfn_t.h, and
> specifically __HAVE_ARCH_PTE_DEVMAP in this first instance.
>
> The failure itself is a link error in remove_migration_pte() due to a
> missing definition of pte_mkdevmap(), but I'm a little confused at the
> fact that it's explicitly declared without a definition, as if that
> breakage is deliberate.
It's deliberate, it's only there to allow mm/memory.c to compile. The
compiler can see that pfn_t_devmap(pfn) is always false in the
!__HAVE_ARCH_PTE_DEVMAP case and throws away the attempt to link to
pte_devmap().
The summary is that an architecture needs to devote a free/software
pte bit for Linux to indicate "device pfns".
next prev parent reply other threads:[~2018-10-31 20:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-31 17:08 __HAVE_ARCH_PTE_DEVMAP - bug or intended behaviour? Robin Murphy
2018-10-31 19:00 ` Jerome Glisse
2018-10-31 20:35 ` Dan Williams
2018-10-31 20:41 ` Dan Williams [this message]
2018-11-01 20:10 ` Robin Murphy
2018-11-01 20:58 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPcyv4gZyDWYiQ8DHwei+FQRL22LGo3Sr6a-9VPESnuRJy7jtg@mail.gmail.com \
--to=dan.j.williams@intel.com \
--cc=jglisse@redhat.com \
--cc=linux-mm@kvack.org \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).