From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61FF0C433B4 for ; Mon, 10 May 2021 19:20:13 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B70A1611C1 for ; Mon, 10 May 2021 19:20:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B70A1611C1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id BF5F66B0070; Mon, 10 May 2021 15:20:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BCC576B0071; Mon, 10 May 2021 15:20:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A6CDF6B0072; Mon, 10 May 2021 15:20:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0018.hostedemail.com [216.40.44.18]) by kanga.kvack.org (Postfix) with ESMTP id 8A5506B0070 for ; Mon, 10 May 2021 15:20:11 -0400 (EDT) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 3228318038B64 for ; Mon, 10 May 2021 19:20:11 +0000 (UTC) X-FDA: 78126287022.28.458CE29 Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com [209.85.218.45]) by imf23.hostedemail.com (Postfix) with ESMTP id 90082A000180 for ; Mon, 10 May 2021 19:20:00 +0000 (UTC) Received: by mail-ej1-f45.google.com with SMTP id f24so26194436ejc.6 for ; Mon, 10 May 2021 12:20:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=uYWAx/GVWalndOcYOu02DjsV8gfmpcaozEycxHwwb08=; b=hQiDm7liVQizlEq991s/huupFIAIRbDMQs0rIBB8pYXXX0E40psanEfZMAZxU7yZgA pjNO98KgV71tHMH+KE5rn3es4Voh9hWnevABaM7hGpgta9goeA/BwCfjwaisAgPIQpAD EoKgFGyM9C5jPRkV6O23nNalBR60I56IqGbODhaPWhFjV26Xn0JiV+gVsb5RnqCRfj2W yYCgg9AXjoYRbYC26davkf7Vrrfh+QjKLXADDsy1b9ED+UofrgQzmw18c6euyChOutxc FP4dzzol+/VOabZ8+GPwwLq5eTQJa0ufSJE/YZbevg42T/uWr57QChbISQT7uBnNLHb/ FvFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=uYWAx/GVWalndOcYOu02DjsV8gfmpcaozEycxHwwb08=; b=lzU3dRNy6G2IcSm7bHKmOnqsuIsul7kfRbs/BMQpBHy6q6EYYIEO/8lpysbcbucXzs KsA1/mkZM0Ux8gNJKXe68WPfIFbTKazoNyd5dPaxJtRPtpzhTNYl6Be4Y4tFCuhPVoyU yOZ4Aw9LwsodxVjCK0su7kLofsS3JiFUf14zbPyDxyYp8/fJyVnaO+oZCr8t93CU+2/W o31Agd/a4bbiksXsswmA7OlqxL3LJTyXHhFdEr7ujQ4pHANjbVfaJhmh97w9BMdCrHOj cSLyx//mnRdhS3IwvP40c5vrxDfnsM3P0S24NUOPEXCG+USBuA9+PlWz+w3de7li2NMN IPiw== X-Gm-Message-State: AOAM531WguPiZ1x4MQYxXgIy0CGePiGlziHERLEtqVEG2JH7B2y2f5XG fr1WquyA93ALT3hZkRP05arEfpW80C/BhuTn7xMmHQ== X-Google-Smtp-Source: ABdhPJzw6HKGgR+vihd+OqgUFjKjHIncCGCJNhZQ0q/KlbHLSbaN1zudTYoKT2gXDUdUyHIHCRcnArwtGH+QxMClEmI= X-Received: by 2002:a17:907:1183:: with SMTP id uz3mr26880105ejb.264.1620674407187; Mon, 10 May 2021 12:20:07 -0700 (PDT) MIME-Version: 1.0 References: <20210325230938.30752-1-joao.m.martins@oracle.com> <20210325230938.30752-8-joao.m.martins@oracle.com> <63ce653d-4d21-c955-7b81-abba25b9e4b6@oracle.com> In-Reply-To: <63ce653d-4d21-c955-7b81-abba25b9e4b6@oracle.com> From: Dan Williams Date: Mon, 10 May 2021 12:19:56 -0700 Message-ID: Subject: Re: [PATCH v1 07/11] mm/sparse-vmemmap: populate compound pagemaps To: Joao Martins Cc: Linux MM , Ira Weiny , linux-nvdimm , Matthew Wilcox , Jason Gunthorpe , Jane Chu , Muchun Song , Mike Kravetz , Andrew Morton Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 90082A000180 Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=intel-com.20150623.gappssmtp.com header.s=20150623 header.b=hQiDm7li; spf=none (imf23.hostedemail.com: domain of dan.j.williams@intel.com has no SPF policy when checking 209.85.218.45) smtp.mailfrom=dan.j.williams@intel.com; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=intel.com (policy=none) X-Rspamd-Server: rspam04 X-Stat-Signature: ehhyrtbm55w1679p64ohdm6fuebzikz3 Received-SPF: none (intel.com>: No applicable sender policy available) receiver=imf23; identity=mailfrom; envelope-from=""; helo=mail-ej1-f45.google.com; client-ip=209.85.218.45 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1620674400-18047 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, May 6, 2021 at 4:02 AM Joao Martins wrote: [..] > >> +static pte_t * __meminit vmemmap_lookup_address(unsigned long addr) > > > > I think this can be replaced with a call to follow_pte(&init_mm...). > > > > Ah, of course! That would shorten things up too. Now that I look closely, I notice that function disclaims being suitable as a general purpose pte lookup utility. If it works for you, great, but if not I think it's past time to create such a helper. I know Ira is looking for one, and I contributed to the proliferation when I added dev_pagemap_mapping_shift().