From: Dan Williams <dan.j.williams@intel.com>
To: Oscar Salvador <osalvador@suse.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
David Hildenbrand <david@redhat.com>,
Pavel Tatashin <pasha.tatashin@soleen.com>,
Michal Hocko <mhocko@suse.com>,
"Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>,
Linux MM <linux-mm@kvack.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] mm,memory_hotplug: Fix shrink_{zone,node}_span
Date: Wed, 17 Jul 2019 11:45:05 -0700 [thread overview]
Message-ID: <CAPcyv4gxhjNmy=8e0MiB88LO5oWPmAPL-gnkG-jF5LpKn1E4vA@mail.gmail.com> (raw)
In-Reply-To: <20190717090725.23618-3-osalvador@suse.de>
On Wed, Jul 17, 2019 at 2:07 AM Oscar Salvador <osalvador@suse.de> wrote:
>
> Since [1], shrink_{zone,node}_span work on PAGES_PER_SUBSECTION granularity.
> We need to adapt the loop that checks whether a zone/node contains only holes,
> and skip the whole range to be removed.
>
> Otherwise, since sub-sections belonging to the range to be removed have not yet
> been deactivated, pfn_valid() will return true on those and we will be left
> with a wrong accounting of spanned_pages, both for the zone and the node.
>
> Fixes: mmotm ("mm/hotplug: prepare shrink_{zone, pgdat}_span for sub-section removal")
> Signed-off-by: Oscar Salvador <osalvador@suse.de>
Looks good,
Reviewed-by: Dan Williams <dan.j.williams@intel.com>
prev parent reply other threads:[~2019-07-17 18:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-17 9:07 [PATCH v2 0/2] Fixes for sub-section hotplug Oscar Salvador
2019-07-17 9:07 ` [PATCH v2 1/2] mm,sparse: Fix deactivate_section for early sections Oscar Salvador
2019-07-17 9:07 ` [PATCH v2 2/2] mm,memory_hotplug: Fix shrink_{zone,node}_span Oscar Salvador
2019-07-17 18:45 ` Dan Williams [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPcyv4gxhjNmy=8e0MiB88LO5oWPmAPL-gnkG-jF5LpKn1E4vA@mail.gmail.com' \
--to=dan.j.williams@intel.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.ibm.com \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=osalvador@suse.de \
--cc=pasha.tatashin@soleen.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).