From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CE07C4338F for ; Fri, 20 Aug 2021 16:07:43 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 129866121F for ; Fri, 20 Aug 2021 16:07:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 129866121F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id ACFBA8D0006; Fri, 20 Aug 2021 12:07:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A80328D0001; Fri, 20 Aug 2021 12:07:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 96F658D0006; Fri, 20 Aug 2021 12:07:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0201.hostedemail.com [216.40.44.201]) by kanga.kvack.org (Postfix) with ESMTP id 7E7618D0001 for ; Fri, 20 Aug 2021 12:07:42 -0400 (EDT) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 1DB1E184C076C for ; Fri, 20 Aug 2021 16:07:42 +0000 (UTC) X-FDA: 78495939564.19.9F5ADF5 Received: from mail-pg1-f173.google.com (mail-pg1-f173.google.com [209.85.215.173]) by imf17.hostedemail.com (Postfix) with ESMTP id E0E54F0003A0 for ; Fri, 20 Aug 2021 16:07:41 +0000 (UTC) Received: by mail-pg1-f173.google.com with SMTP id o2so9629663pgr.9 for ; Fri, 20 Aug 2021 09:07:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=epIvCzmEqd8lfEkp+zSX1z8FhC6G4rECGu8AkMD5cjk=; b=P7Uh70GB0OX3B5Tk5r5zIxGh0NGQ540vdB1mNKc2+JutGdaZMDOkgUxO7d7iWDuhYZ z1tCB9283izawrMkSTNVGS7wgAXNGmlA3+Cr1pWkT1AUl7J8yzzbAfduwNz8D3V9fHfW 6RZt94rmopS/jx/A8V3arfNqYRWF4Gb2BH8IG7P2QkRuA12Qi+9LAd16WMy1VBKta2EW 6fU2eSUDVOsSjU2nRgaifSK1mQmCZIk5O3n/hYxktE56ZNMrEERZzMgxXuvQoedf5AQ1 +n2gl1cUovGWZFtsMrCPt+gUTucffn2xvgJEpGG8k+mhCO/9SqQlDQ6VWtpgkGfa16cD fs1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=epIvCzmEqd8lfEkp+zSX1z8FhC6G4rECGu8AkMD5cjk=; b=nh+AEzq0ro/3JW36HWyRFZPcVt8Yo9yPmKMU7rmiTY97gGLMs+2P8eIwaP0vgnC73v gORdo4D2/TQlot3TTMvpg4tEiBeBp+CPbJcul6aiPgWredkSJDs+1QKDfbuMuKMAsgAa Zvau5awBsP/YHKN6gXiliioQBq7I9fr8T8o6B8N/7zuN5IeSSkJe8qbaw/ebmbBMqEnu Nmbu8wriJL4IeGbz6WSrkeKdpgHMCnTQ/6L9EhPhngd3NlH7AWD+9NBY7mLvwgQgRMv+ 41YU3NNFNwPHLG3tHhiS5pucQIe982wS8eCdO54f9jYGYngEgmIaA3+3RlbA03O4Yhe0 cMow== X-Gm-Message-State: AOAM530zhbEQ2JeWGUdUtuSAFxhx5fpJtjLmRsparyrVagnZaDQXE2Zf zBMCntHOPbbElxVrWkdB062swfzfBsceqxMZBj17Uw== X-Google-Smtp-Source: ABdhPJxyfy7kK0en0qSo4G5Lluu8ZezasgOhs9PpGIhkynMyXLeeasrkdLx8NF/nNzuMhI/nhpOTrwat9vU59+Lgzvc= X-Received: by 2002:a05:6a00:9a4:b0:3e2:f6d0:c926 with SMTP id u36-20020a056a0009a400b003e2f6d0c926mr13253034pfg.31.1629475661105; Fri, 20 Aug 2021 09:07:41 -0700 (PDT) MIME-Version: 1.0 References: <20210730100158.3117319-1-ruansy.fnst@fujitsu.com> <20210730100158.3117319-2-ruansy.fnst@fujitsu.com> In-Reply-To: <20210730100158.3117319-2-ruansy.fnst@fujitsu.com> From: Dan Williams Date: Fri, 20 Aug 2021 09:07:30 -0700 Message-ID: Subject: Re: [PATCH RESEND v6 1/9] pagemap: Introduce ->memory_failure() To: Shiyang Ruan Cc: Linux Kernel Mailing List , linux-xfs , Linux NVDIMM , Linux MM , linux-fsdevel , device-mapper development , "Darrick J. Wong" , david , Christoph Hellwig , Alasdair Kergon , Mike Snitzer Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=intel-com.20150623.gappssmtp.com header.s=20150623 header.b=P7Uh70GB; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=none (imf17.hostedemail.com: domain of dan.j.williams@intel.com has no SPF policy when checking 209.85.215.173) smtp.mailfrom=dan.j.williams@intel.com X-Stat-Signature: ektem4pwfkr1uhwpg3qr9quekm7rusnq X-Rspamd-Queue-Id: E0E54F0003A0 X-Rspamd-Server: rspam01 X-HE-Tag: 1629475661-13160 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jul 30, 2021 at 3:02 AM Shiyang Ruan wrote: > > When memory-failure occurs, we call this function which is implemented > by each kind of devices. For the fsdax case, pmem device driver > implements it. Pmem device driver will find out the filesystem in which > the corrupted page located in. And finally call filesystem handler to > deal with this error. > > The filesystem will try to recover the corrupted data if necessary. This patch looks good to me, but I would fold it into the patch that first populates ->memory_failure().