From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB5BCC43331 for ; Wed, 1 Apr 2020 08:48:29 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6E211215A4 for ; Wed, 1 Apr 2020 08:48:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=intel-com.20150623.gappssmtp.com header.i=@intel-com.20150623.gappssmtp.com header.b="Bh1JR39j" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6E211215A4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 200816B00AC; Wed, 1 Apr 2020 04:48:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1AFFD6B00AD; Wed, 1 Apr 2020 04:48:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 051436B00AE; Wed, 1 Apr 2020 04:48:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0072.hostedemail.com [216.40.44.72]) by kanga.kvack.org (Postfix) with ESMTP id E26F56B00AC for ; Wed, 1 Apr 2020 04:48:28 -0400 (EDT) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 9CF58180AD81A for ; Wed, 1 Apr 2020 08:48:28 +0000 (UTC) X-FDA: 76658659896.19.dime12_84308fabd1214 X-HE-Tag: dime12_84308fabd1214 X-Filterd-Recvd-Size: 6377 Received: from mail-ed1-f68.google.com (mail-ed1-f68.google.com [209.85.208.68]) by imf40.hostedemail.com (Postfix) with ESMTP for ; Wed, 1 Apr 2020 08:48:28 +0000 (UTC) Received: by mail-ed1-f68.google.com with SMTP id a43so28678191edf.6 for ; Wed, 01 Apr 2020 01:48:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=feZj/1ocB6XIjJoDVsEEUrA2KaXFHt0B9wSHktP2ddQ=; b=Bh1JR39j+h1CpltTDW6HGFEOaXTLaNjNFTs/HHcXupyutEFcwNSNmspuDLCGf1ngc3 3JpOjmwFyMJKqlOxTzogrVowaOb1QIi3j8ZxAAP5+dTIDs2wrDYNiFzAC1pNenb81J4x Y0o8J2WvYge0HdtQtAaBdaJuC6fhVWSw5yAjGewymen6zoiqepG1Pu2f2Syh3qjkbnM9 63NpYqgZavpVqDdE02NRa8sgSS+1zoZJSGdCFyiEDE6u1Wuo2Qc2ha1yyqNmK6L2A0tu +GaivKSH2OYfiaNQXJyXBJPXwLpUUs6miQI82ISI/kufkqup77wKyM4fD8QUJdtlbmOJ Hi9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=feZj/1ocB6XIjJoDVsEEUrA2KaXFHt0B9wSHktP2ddQ=; b=a1yTTf1IPw7GwCY8ZezESVY8BQSvksq4QYwuz+qUc8XkjIOm9+3wAg2EAfR2lBg43B TLQ5AM2YtkJk0Wg7TRLILi/diRrMSUuoEMfxzIiAJ3KF286d6qlH8ZEd/3jzHbdY7ike 5lv8BGZHRHzJcZ2LHvtlLw2tvYA1t7bzMQK5PTOeCFMIcsgmB5Pla+pgQ2jkY8Sd3mFI QeQHqzXpLuAY4g6SCYB6gCYUbU9jSenoit4Ny/2LuYQpDL3NYcPCXM4DR5bA1gIFgI29 7JN3BWzvg44UYy7rbMY48145jTH5m5v9sim9JB6Yknb1C1yr1Ixx6L3q/9z6Gp2nSj1X 4+qg== X-Gm-Message-State: ANhLgQ2Q7I3U0+yFBUHyGLhXmcAWUr1be9DCzHHUOC4uffvnndO9nY2Q cVqfZ1ZM3WQ7sbIDK2RLlogCo9tBvGFrwgodGTmRKw== X-Google-Smtp-Source: ADFU+vuVdufBykICW7DqF15W3KALGotPW1gMa6p2yo6taAqlQuWcuvysMS1tCXsRtLbaLnYvh0bX4T16tZYwkhRj3fU= X-Received: by 2002:a05:6402:b17:: with SMTP id bm23mr19586972edb.165.1585730907196; Wed, 01 Apr 2020 01:48:27 -0700 (PDT) MIME-Version: 1.0 References: <20200327071202.2159885-1-alastair@d-silva.org> <20200327071202.2159885-3-alastair@d-silva.org> In-Reply-To: <20200327071202.2159885-3-alastair@d-silva.org> From: Dan Williams Date: Wed, 1 Apr 2020 01:48:16 -0700 Message-ID: Subject: Re: [PATCH v4 02/25] mm/memory_hotplug: Allow check_hotplug_memory_addressable to be called from drivers To: "Alastair D'Silva" Cc: "Aneesh Kumar K . V" , "Oliver O'Halloran" , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Frederic Barrat , Andrew Donnellan , Arnd Bergmann , Greg Kroah-Hartman , Vishal Verma , Dave Jiang , Ira Weiny , Andrew Morton , Mauro Carvalho Chehab , "David S. Miller" , Rob Herring , Anton Blanchard , Krzysztof Kozlowski , Mahesh Salgaonkar , Madhavan Srinivasan , =?UTF-8?Q?C=C3=A9dric_Le_Goater?= , Anju T Sudhakar , Hari Bathini , Thomas Gleixner , Greg Kurz , Nicholas Piggin , Masahiro Yamada , Alexey Kardashevskiy , Linux Kernel Mailing List , linuxppc-dev , linux-nvdimm , Linux MM Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Mar 29, 2020 at 10:23 PM Alastair D'Silva wrote: > > When setting up OpenCAPI connected persistent memory, the range check may > not be performed until quite late (or perhaps not at all, if the user does > not establish a DAX device). > > This patch makes the range check callable so we can perform the check while > probing the OpenCAPI Persistent Memory device. > > Signed-off-by: Alastair D'Silva > Reviewed-by: Andrew Donnellan > --- > include/linux/memory_hotplug.h | 5 +++++ > mm/memory_hotplug.c | 4 ++-- > 2 files changed, 7 insertions(+), 2 deletions(-) > > diff --git a/include/linux/memory_hotplug.h b/include/linux/memory_hotplug.h > index f4d59155f3d4..9a19ae0d7e31 100644 > --- a/include/linux/memory_hotplug.h > +++ b/include/linux/memory_hotplug.h > @@ -337,6 +337,11 @@ static inline void __remove_memory(int nid, u64 start, u64 size) {} > extern void set_zone_contiguous(struct zone *zone); > extern void clear_zone_contiguous(struct zone *zone); > > +#ifdef CONFIG_MEMORY_HOTPLUG_SPARSE > +int check_hotplug_memory_addressable(unsigned long pfn, > + unsigned long nr_pages); > +#endif /* CONFIG_MEMORY_HOTPLUG_SPARSE */ Let's move this to include/linux/memory.h with the other CONFIG_MEMORY_HOTPLUG_SPARSE declarations, and add a dummy implementation for the CONFIG_MEMORY_HOTPLUG_SPARSE=n case. Also, this patch can be squashed with the next one, no need for it to be stand alone. > + > extern void __ref free_area_init_core_hotplug(int nid); > extern int __add_memory(int nid, u64 start, u64 size); > extern int add_memory(int nid, u64 start, u64 size); > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > index 0a54ffac8c68..14945f033594 100644 > --- a/mm/memory_hotplug.c > +++ b/mm/memory_hotplug.c > @@ -276,8 +276,8 @@ static int check_pfn_span(unsigned long pfn, unsigned long nr_pages, > return 0; > } > > -static int check_hotplug_memory_addressable(unsigned long pfn, > - unsigned long nr_pages) > +int check_hotplug_memory_addressable(unsigned long pfn, > + unsigned long nr_pages) > { > const u64 max_addr = PFN_PHYS(pfn + nr_pages) - 1; > > -- > 2.24.1 >