From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 897C9C4320A for ; Fri, 20 Aug 2021 16:54:20 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 241A0610A3 for ; Fri, 20 Aug 2021 16:54:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 241A0610A3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id B86E76B0071; Fri, 20 Aug 2021 12:54:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B37EC6B0072; Fri, 20 Aug 2021 12:54:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A26158D0001; Fri, 20 Aug 2021 12:54:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0181.hostedemail.com [216.40.44.181]) by kanga.kvack.org (Postfix) with ESMTP id 844E46B0071 for ; Fri, 20 Aug 2021 12:54:19 -0400 (EDT) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 38AB42D008 for ; Fri, 20 Aug 2021 16:54:19 +0000 (UTC) X-FDA: 78496057038.13.79FB149 Received: from mail-pg1-f172.google.com (mail-pg1-f172.google.com [209.85.215.172]) by imf04.hostedemail.com (Postfix) with ESMTP id 9896B50000A4 for ; Fri, 20 Aug 2021 16:54:18 +0000 (UTC) Received: by mail-pg1-f172.google.com with SMTP id 17so9743903pgp.4 for ; Fri, 20 Aug 2021 09:54:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=x/jv/65/o/pr3Arrh3DCsUW+kuq3VQXikqXf2iTWhR0=; b=wmKOKlHKACOKqcXgGfzOyuS+T8nTPa0UTHRKzXqyEB7n1oMhL9ybIy4re4kL145HF1 bMtrau52pfw/I1Kc5cdxzuDtd0Et/jJkS5US+hv/mTQyQM7TcCklar0bSyyEBZaFQivs wSYZ7huQEIGoNty7O9v1HlhEnIt+psE5sGUDc9it5+LPZ7q/ulbelZHxwf3w1Cir636k IGP2ByU9d0ypCXvfCnbVJxTWgVNrKwxvWAw8s1imwihI5Uzzw1LN35likbg8w9wlGZNJ vEpJZYYjxE1je5/O/8C/dWmlALP8frPW0a+yHWctwSdYLH99P7ISs6wJ2ZSV9hwtj/V7 R6+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=x/jv/65/o/pr3Arrh3DCsUW+kuq3VQXikqXf2iTWhR0=; b=GvuGkYZZLy5Z+R+Pov/YzQH2kcafhdjc7EhdIU9zqDxAgD/PeBDENUuryj64oG+jTn wuG3BhH8a8PQiEURC63+qeEsZbffHYOaI+H5nn/yycoC1X16ot8+/4QOBqiQ55/gqY2L 7xRL/FzB2tI9rfhiMJQ9LqovmLM7klgzZlOTmfxSqmHtfD19FF1zIEJWCR8iHIa3HBnx nzbV1t7rlg8ZtaoYddOXk+q0MOjyKNmgKT0KI3ikUSHHf4aGAMcJpOVMiRD424w+bj2t ECjasdrs0ZZnHc7gbDE+HWo4QqcqdABgC5TnGQqOBsPDBvb7YFc9JLiF63d0Mf/N1U4U npVg== X-Gm-Message-State: AOAM5301iu74E45m4C/O8JfQx8ZrMkdzUHMTCRQ1H2H7qsT5/Eg5Xc3g tUyiQIa8Bx33DKVsb919IMv3nBPDWcR6mWvXYSsYEg== X-Google-Smtp-Source: ABdhPJxOaSnUuSDnQi5DeVTlIJ2tZRX4+NfWecFNtpOa2DU5Lh7Ot8DcjqxkMAwkp+e/mA/IvF4DoFjucZJd3KA/Wvo= X-Received: by 2002:a65:6642:: with SMTP id z2mr7510515pgv.240.1629478457626; Fri, 20 Aug 2021 09:54:17 -0700 (PDT) MIME-Version: 1.0 References: <20210730100158.3117319-1-ruansy.fnst@fujitsu.com> <20210730100158.3117319-4-ruansy.fnst@fujitsu.com> In-Reply-To: From: Dan Williams Date: Fri, 20 Aug 2021 09:54:06 -0700 Message-ID: Subject: Re: [PATCH RESEND v6 3/9] mm: factor helpers for memory_failure_dev_pagemap To: Jane Chu Cc: Shiyang Ruan , Linux Kernel Mailing List , linux-xfs , Linux NVDIMM , Linux MM , linux-fsdevel , device-mapper development , "Darrick J. Wong" , david , Christoph Hellwig , Alasdair Kergon , Mike Snitzer Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=intel-com.20150623.gappssmtp.com header.s=20150623 header.b=wmKOKlHK; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=none (imf04.hostedemail.com: domain of dan.j.williams@intel.com has no SPF policy when checking 209.85.215.172) smtp.mailfrom=dan.j.williams@intel.com X-Stat-Signature: xskn5jbtc4k3irjk9zpc4k6zc64jsc3m X-Rspamd-Queue-Id: 9896B50000A4 X-Rspamd-Server: rspam01 X-HE-Tag: 1629478458-966678 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Aug 5, 2021 at 6:01 PM Jane Chu wrote: > > > On 7/30/2021 3:01 AM, Shiyang Ruan wrote: > > - /* > > - * Prevent the inode from being freed while we are interrogating > > - * the address_space, typically this would be handled by > > - * lock_page(), but dax pages do not use the page lock. This > > - * also prevents changes to the mapping of this pfn until > > - * poison signaling is complete. > > - */ > > - cookie = dax_lock_page(page); > > - if (!cookie) > > - goto out; > > - > > if (hwpoison_filter(page)) { > > rc = 0; > > - goto unlock; > > + goto out; > > } > > why isn't dax_lock_page() needed for hwpoison_filter() check? Good catch. hwpoison_filter() is indeed consulting page->mapping->host which needs to be synchronized against inode lifetime.